Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201111051859.2776-1-ivan.zaentsev@wirenboard.ru>
In-Reply-To: <20201111051859.2776-1-ivan.zaentsev@wirenboard.ru>
From:   Fabio Estevam <festevam@gmail.com>
Date:   Wed, 11 Nov 2020 16:46:49 -0300
Message-ID: <CAOMZO5DXcQaZhujAq_KOEQgUNDx5cDsGnObVtadE5=qvWhUs7Q@mail.gmail.com>
Subject: Re: [PATCH] ARM: mxs: Add serial number support for i.MX23, i.MX28 SoCs
To:     Ivan Zaentsev <ivan.zaentsev@wirenboard.ru>
Cc:     Russell King <linux@armlinux.org.uk>,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        NXP Linux Team <linux-imx@nxp.com>,
        Evgeny Boger <boger@wirenboard.com>,
        "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@lists.infradead.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Ivan,

On Wed, Nov 11, 2020 at 2:19 AM Ivan Zaentsev
<ivan.zaentsev@wirenboard.ru> wrote:
>
> i.MX23 and i.MX28 SoCs unique identifiers are factory-programmed
> in On-Chip OTP memory. i.MX28's 64-bit unique id is in
> HW_OCOTP_OPS2:HW_OCOTP_OPS3 (see MCIMX28 Ref. Man., sec. 20.4.22-23).
>
> i.MX23 provides 32-bit long unique id in HW_OCOTP_OPS3.
> Though not clearly documented, there is a clue in sec. 35.9.3.
>
> The unique id is reported in /sys/devices/soc0/serial_number
> and in /proc/cpuinfo
>
> Signed-off-by: Ivan Zaentsev <ivan.zaentsev@wirenboard.ru>
> Suggested-by: Evgeny Boger <boger@wirenboard.com>

It looks good, thanks:

Reviewed-by: Fabio Estevam <festevam@gmail.com>