Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 11 Nov 2020 21:40:43 +0100
From:   Thierry Reding <thierry.reding@gmail.com>
To:     Rahul Tanwar <rahul.tanwar@linux.intel.com>,
        Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= 
        <u.kleine-koenig@pengutronix.de>
Cc:     linux-pwm@vger.kernel.org, lee.jones@linaro.org,
        p.zabel@pengutronix.de, robh+dt@kernel.org,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
        andriy.shevchenko@intel.com, songjun.Wu@intel.com,
        cheol.yong.kim@intel.com, qi-ming.wu@intel.com,
        rahul.tanwar.linux@gmail.com
Subject: Re: [PATCH v15 0/2] pwm: intel: Add PWM driver for a new SoC
Message-ID: <20201111204043.GO6125@ulmo>
References: <cover.1604555266.git.rahul.tanwar@linux.intel.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="kVcb4xucqmsYUpQy"
Content-Disposition: inline
In-Reply-To: <cover.1604555266.git.rahul.tanwar@linux.intel.com>
User-Agent: Mutt/1.14.7 (2020-08-29)
Precedence: bulk


--kVcb4xucqmsYUpQy
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Nov 05, 2020 at 01:49:38PM +0800, Rahul Tanwar wrote:
> Patch 1 adds dt binding document in YAML format.
> Patch 2 add PWM fan controller driver for LGM SoC.
>=20
> v15:
> - Rebase to latest linux 5.10-rc2
>=20
> v14:
> - Address below review concerns from Uwe Kleine-K?nig.
>  * Add limitations info about fixed 2-wire mode support.
>  * Rename clk/reset _disable function names to _release.
>  * Remove clk & rst from driver data structure. Instead
>    use them as arguments.
>  * Add pwm_chip.base =3D -1.
> - Resolve missing MODULE_LICENSE warning.
>=20
> v13:
> - Address below review concerns (Philipp Zabel)
>  * Make unnecessary 2 line comment as 1 line comment.
>  * Move reset_deassert at the last after clk_enable.
>  * Remove unnecessary return ret statement from .remove()
> - Move platform_set_drvdata() at the top of probe.=20

Uwe,

you had concerns about v13 of this. Can you take a look if all your
comments have been addressed?

Thanks,
Thierry

--kVcb4xucqmsYUpQy
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAl+sTEsACgkQ3SOs138+
s6F0hQ//c+xpl0v3szV/zRkc3zKiV3TB85jHifUCleXO6DLDpsu9Jz2plr4jmUet
Bop1aM6rd314PLbN3HBfpcND8wqQ8VhoBMY2Fb47uIpdwD0xGmulb2JPJquc0RpR
NSock2udeC4gKSDDAZR/OlRhNxhJb/sPPk4PBYjY/4fSDrKXKkSTmanQeouF780P
2HKoGbmry2QZylB2RG1ugyZWTguAWdlnLacIzpcxiVaTlnDOwndRu2C42XaE2Uy3
vxFLvhaNZ555KMZXQqA9ojFfvhPpMMUfON8ndf08UXuQn4ncdt9mmhTiTg8VEFME
vBzrnXj8S5MjrWdc9Dk4QfZPYiY4LqVKZTigybMGSG2TyogZqLso9WXONA1A15zI
0tEZP1mc2NtoMDV8GzzruJuNyrU4LhGEaIYHs2f5nMbiux2ULLUM8z3RUSGqKW4R
lZfVA3SWTSf9EGES5jQOZ6RcloMshExrkdM60HAS8KIUw+2q8T6082yIupUwjYJf
+FMM9vwesgZnLCP8FEv8FvzOiPDtrxX4x9ec/kH6KOHItWxzGBGd41PjYFjGzRi3
wcuzTxysQAqWZK4HQGRTsb4lLSaiw+tA5tFF0oFYDGt3lEHy1IeCDMnQHW6WWQiC
oI5pqLRokRn75pyQatgxmUvQ6GrrazdmvX2iOOOY0Gmzdh4z3gg=
=nTJP
-----END PGP SIGNATURE-----

--kVcb4xucqmsYUpQy--