Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 11 Nov 2020 22:14:32 +0100
From:   Thierry Reding <thierry.reding@gmail.com>
To:     Rahul Tanwar <rahul.tanwar@linux.intel.com>
Cc:     u.kleine-koenig@pengutronix.de, linux-pwm@vger.kernel.org,
        lee.jones@linaro.org, p.zabel@pengutronix.de, robh+dt@kernel.org,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
        andriy.shevchenko@intel.com, songjun.Wu@intel.com,
        cheol.yong.kim@intel.com, qi-ming.wu@intel.com,
        rahul.tanwar.linux@gmail.com
Subject: Re: [PATCH v15 0/2] pwm: intel: Add PWM driver for a new SoC
Message-ID: <20201111211432.GA571441@ulmo>
References: <cover.1604555266.git.rahul.tanwar@linux.intel.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="gBBFr7Ir9EOA20Yy"
Content-Disposition: inline
In-Reply-To: <cover.1604555266.git.rahul.tanwar@linux.intel.com>
User-Agent: Mutt/1.14.7 (2020-08-29)
Precedence: bulk


--gBBFr7Ir9EOA20Yy
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Nov 05, 2020 at 01:49:38PM +0800, Rahul Tanwar wrote:
> Patch 1 adds dt binding document in YAML format.
> Patch 2 add PWM fan controller driver for LGM SoC.
>=20
> v15:
> - Rebase to latest linux 5.10-rc2
>=20
> v14:
> - Address below review concerns from Uwe Kleine-K?nig.
>  * Add limitations info about fixed 2-wire mode support.
>  * Rename clk/reset _disable function names to _release.
>  * Remove clk & rst from driver data structure. Instead
>    use them as arguments.
>  * Add pwm_chip.base =3D -1.
> - Resolve missing MODULE_LICENSE warning.
>=20
> v13:
> - Address below review concerns (Philipp Zabel)
>  * Make unnecessary 2 line comment as 1 line comment.
>  * Move reset_deassert at the last after clk_enable.
>  * Remove unnecessary return ret statement from .remove()
> - Move platform_set_drvdata() at the top of probe.=20
>=20
> v12:
> - Rebase to linux 5.9-rc4
> - Add Reviewed-by tags from Andy Shevchenko & Rob Herring.
>=20
> v11:
> - Address below review concerns (Andy Shevchenko)
>   * Fix a issue with dev_err_probe() usage & improve the usage.
>   * Fix & improve a ordering issue with clk_enable/disable &
>     reset_control assert/deassert.
>=20
> v10:
> - Removed unused of_device.h and added platform_device.h
>   & mod_devicetable.h
>=20
> v9:
> - Address code quality related review concerns (Andy Shevchenko)
> - Use devm_add_action_or_reset() instead of explicit unwind calls.
>=20
> v8:
> - Remove fan related optional properties usage, keep
>   them as default. If needed, change pwm-fan driver
>   separately in future to add them as generic properties.
>=20
> v7:
> - Address code quality related review concerns.
> - Rename fan related property to pwm-*.
> - Fix one make dt_binding_check reported error.
>=20
> v6:
> - Readjust .apply op as per review feedback.
> - Add back pwm-cells property to resolve make dt_binding_check error.
>   pwm-cells is a required property for PWM driver.
> - Add back fan related optional properties.
>=20
> v5:
> - Address below review concerns from Uwe Kleine-K?nig.
>   * Improve comments about Limitations.
>   * Use return value of regmap_update_bits if container function returns
>     error code.
>   * Modify .apply op to have strict checking for fixed period supported
>     by PWM HW.
>   * Use u64 as type when use min_t for duty_cycle.
>   * Add reset_control_assert() in failure case in probe where it was miss=
ing
>     earlier.
> - Remove fan specific optional properties from pwm dt binding document (R=
ob Herring)
>=20
> v4:
> - Address below review concerns from Uwe Kleine-K?nig.
>   * Improve notes and limitations comments.
>   * Add common prefixes for all #defines.
>   * Modify/Improve logic in .apply & .get_state ops as advised.
>   * Skip error messages in probe when error is -EPROBE_DEFER.
>   * Add dependencies in Kconfig (OF & HAS_IOMEM) and add select REGMAP_MM=
IO.
>   * Address other code quality related review concerns.
> - Fix make dt_binding_check reported error in YAML file.
>=20
> v3:
> - Address below review concerns from Uwe Kleine-K?nig.
>   * Remove fan rpm calibration task from the driver.
>   * Modify apply op as per the review feedback.
>   * Add roundup & round down where necessary.
>   * Address other misc code quality related review concerns.
>   * Use devm_reset_control_get_exclusive(). (Philipp Zabel)
>   * Improve dt binding document.
>=20
> v2:
> - Address below review concerns from Uwe Kleine-K?nig.
>   * Add notes and limitations about PWM HW.
>   * Rename all functions and structure to lgm_pwm_*=20
>   * Readjust space aligninment in structure fields to single space.
>   * Switch to using apply instead of config/enable/disable.
>   * Address other code quality related concerns.
>   * Rebase to 5.8-rc1.
> - Address review concerns in dt binding YAML from Rob Herring.
>=20
> v1:
> - Initial version.
>=20
>=20
> Rahul Tanwar (2):
>   Add DT bindings YAML schema for PWM fan controller of LGM SoC
>   Add PWM fan controller driver for LGM SoC
>=20
>  .../devicetree/bindings/pwm/intel,lgm-pwm.yaml     |  44 ++++
>  drivers/pwm/Kconfig                                |  11 +
>  drivers/pwm/Makefile                               |   1 +
>  drivers/pwm/pwm-intel-lgm.c                        | 244 +++++++++++++++=
++++++
>  4 files changed, 300 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/pwm/intel,lgm-pwm.y=
aml
>  create mode 100644 drivers/pwm/pwm-intel-lgm.c

Both patches applied, thanks.

Thierry

--gBBFr7Ir9EOA20Yy
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAl+sVDQACgkQ3SOs138+
s6FAgA//bkEboSKJlHm6SeyDedY/54jZJJ743Gsg3m+KrPwS1JvLILrLuZDSCWxC
zdAG6+2OSeKTbtZn0dcNkG6/v3ng1mKMqCYhJrXOFPWwaBT8TmrvBaAOY9UJIr3E
aWXjN7AogW6U8zOAK08T5S18hlwxdPZIVUcs6fheSbeEzb9ux2rNiCtNbY0LCJah
nqp+3TLfR6b6lyd7vgB2iM8Ut2won9M21ig2HiNAST/+ixV7AyW/ejSmy62QcY+K
iDOOO6h7VfNt5DUSqNkdA0OBGZPcrKKgHD2UqKpSc0rywEaAGlOn2RhsjK9/x5Ru
9VZhvpQGHLK9yNeS9746EKeE07gMocaHqGXGhh57ltxHFGbm9m79of+SHJB6JzEM
NxJqQo7Bb2WZVkHaDsk1vkO7KhZ5nitcEUvI8T1lD/Id5eF8F03ghzCrc7OYp4fo
KlWTNj5F/4sc/IcF55sayceqQu/jKigKgfVIr2ur/o7z81ykh99Ghvm5cGSRfpO/
2xqBPvYvmhFgumuY+fUKWJzePJxXmAyt3DHWFhL8kfj3sdChTgua8BdgMYurbxLz
f6i4KH3yHm3lZWXovGFv3LzeCKGGGcLYPI/jvKGyEXeT5b4/u5ksrOHMiOVE8xXW
H4sY+Is81ABh8dVXsKdhWgPId1//jrUPgISYPDlBhh/P5n3UMlU=
=MrmB
-----END PGP SIGNATURE-----

--gBBFr7Ir9EOA20Yy--