Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: UQMY7DpzyrG/ucXXb3ZziAvTEMOXYANZWIEJlYiA7Ca2VvO40iP0WgVt3dQpyWLRcGnsZXqufX
 wV19+UeIU6GA==
IronPort-SDR: ZWVZ785rIL5gz3V66m3Rngatgnao4gMINkrgMEZ4Tl6+c4HIkEM29kgv4+JjtBBzFn6rWxvJZJ
 gSZ/4/NY+TXw==
Subject: Re: [PATCH v1 1/2] dt-bindings: leds: Add bindings for intel LGM SOC
To:     Pavel Machek <pavel@ucw.cz>
Cc:     linux-leds@vger.kernel.org, dmurphy@ti.com,
        devicetree@vger.kernel.org, robh+dt@kernel.org,
        linux-kernel@vger.kernel.org, cheol.yong.kim@intel.com,
        qi-ming.wu@intel.com, malliamireddy009@gmail.com,
        yixin.zhu@intel.com
References: <c9c963a2d03fbd03bd21f71f3d776ac5800cf6cc.1604331498.git.mallikarjunax.reddy@linux.intel.com>
 <20201105095257.GA7994@amd>
From:   "Reddy, MallikarjunaX" <mallikarjunax.reddy@linux.intel.com>
Message-ID: <06f20e58-405a-438e-641b-a7e0bf7d48e9@linux.intel.com>
Date:   Thu, 12 Nov 2020 06:34:34 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.12.1
MIME-Version: 1.0
In-Reply-To: <20201105095257.GA7994@amd>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Precedence: bulk

Hi Pavel,

Thanks for your valuable comments, Please see my comments inline.

On 11/5/2020 5:52 PM, Pavel Machek wrote:
> On Thu 2020-11-05 17:43:50, Amireddy Mallikarjuna reddy wrote:
>> Add DT bindings YAML schema for SSO controller driver
>> of Lightning Mountain(LGM) SoC.
>>
> intel -> Intel in the title.
> "Lightning Mountain(LGM)" -> 'Lightning Mountain (LGM)"

ok.

>
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/leds/leds-lgm.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Intel LGM Soc LED SSO driver
> Please spell out LGM and SSO here. Soc -> SoC?
ok.

>
>
>> +          intel,sso-brightness:
>> +            $ref: /schemas/types.yaml#/definitions/uint32
>> +            description: brightness level of the LED.
>> +            minimum: 0
>> +            maximum: 255
> ?
In case of using "default-state" property, it is redundant.
>
>> +          intel,sso-hw-trigger:
>> +            type: boolean
>> +            description: This property indicates Hardware driven/control LED.
> Why is this intel specific?
This is not common property, so i used vendor name.
do you suggest only property name without vendor name?
>
>> +          intel,sso-hw-blink:
>> +            type: boolean
>> +            description: This property indicates Enable LED blink by Hardware.
> ?
This is not common property, so i used vendor name.
do you suggest only property name without vendor name?
>
>> +          intel,sso-blink-rate:
>> +            $ref: /schemas/types.yaml#/definitions/uint32
>> +            description: LED HW blink frequency.
> ?
This is not common property, so i used vendor name.
do you suggest only property name without vendor name?
>
> Best regards,
> 						Pavel