Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750702AbWHUSe2 (ORCPT ); Mon, 21 Aug 2006 14:34:28 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750707AbWHUSe2 (ORCPT ); Mon, 21 Aug 2006 14:34:28 -0400 Received: from server6.greatnet.de ([83.133.96.26]:5043 "EHLO server6.greatnet.de") by vger.kernel.org with ESMTP id S1750702AbWHUSe2 (ORCPT ); Mon, 21 Aug 2006 14:34:28 -0400 Message-ID: <44E9FCB5.4050101@nachtwindheim.de> Date: Mon, 21 Aug 2006 20:34:29 +0200 From: Henne User-Agent: Thunderbird 1.5.0.5 (X11/20060725) MIME-Version: 1.0 To: akpm@osdl.org Cc: linux-kernel@vger.kernel.org Subject: [PATCH] [DOCBOOK] fix segfault in docproc.c Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 924 Lines: 26 From: Henrik Kretzschmar Adds a missing exit, if the file that should be parsed couldn't be opened. Without it crashes with a segfault, cause the filedescriptor is accessed even if the file could not be opened. This error happens on 2.6.18-rc4-mm[12] when executing make xmldocs. Signed-off-by: Henrik Kretzschmar --- --- linux-2.6.18-rc4/scripts/basic/docproc.c 2006-06-18 03:49:35.000000000 +0200 +++ linux/scripts/basic/docproc.c 2006-08-18 22:19:48.000000000 +0200 @@ -177,6 +177,7 @@ { fprintf(stderr, "docproc: "); perror(real_filename); + exit(1); } while(fgets(line, MAXLINESZ, fp)) { char *p; - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/