Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH V2 net-next 11/11] net: hns3: add debugfs support for
 interrupt coalesce
To:     Jakub Kicinski <kuba@kernel.org>
CC:     <davem@davemloft.net>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <salil.mehta@huawei.com>,
        <yisen.zhuang@huawei.com>, <linuxarm@huawei.com>
References: <1604892159-19990-1-git-send-email-tanhuazhong@huawei.com>
 <1604892159-19990-12-git-send-email-tanhuazhong@huawei.com>
 <20201110172858.5eddc276@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
 <faf8854a-329d-8064-a832-02b08d3f5bad@huawei.com>
 <20201111081520.670fc37f@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
From:   tanhuazhong <tanhuazhong@huawei.com>
Message-ID: <d5ec4fa1-6e49-7554-a4fd-26ce56f5737f@huawei.com>
Date:   Thu, 12 Nov 2020 08:48:32 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.2
MIME-Version: 1.0
In-Reply-To: <20201111081520.670fc37f@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 2020/11/12 0:15, Jakub Kicinski wrote:
> On Wed, 11 Nov 2020 11:16:37 +0800 tanhuazhong wrote:
>> On 2020/11/11 9:28, Jakub Kicinski wrote:
>>> On Mon, 9 Nov 2020 11:22:39 +0800 Huazhong Tan wrote:
>>>> Since user may need to check the current configuration of the
>>>> interrupt coalesce, so add debugfs support for query this info,
>>>> which includes DIM profile, coalesce configuration of both software
>>>> and hardware.
>>>>
>>>> Signed-off-by: Huazhong Tan <tanhuazhong@huawei.com>
>>>
>>> Please create a file per vector so that users can just read it instead
>>> of dumping the info into the logs.
>>>    
>>
>> This patch should be removed from this series right now. Since this new
>> read method needs some adaptations and verifications, and there maybe
>> another better ways to dump this info.
>>
>>> Even better we should put as much of this information as possible into
>>> the ethtool API. dim state is hardly hardware-specific.
>>>    
>>
>> Should the ethtool API used to dump the hardware info? Could you provide
>> some hints to do it?
> 
> Not necessarily hardware info but if there is a use case for inspecting
> DIM state we can extend
> 
> coalesce_fill_reply() in net/ethtool/coalesce.c
> 
> to report it.
> 

ok, thanks.

> .
>