Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201111232330.30843-1-rentao.bupt@gmail.com>
In-Reply-To: <20201111232330.30843-1-rentao.bupt@gmail.com>
From:   Joel Stanley <joel@jms.id.au>
Date:   Wed, 11 Nov 2020 23:34:10 +0000
Message-ID: <CACPK8XdC8FRKOLQ9e583gVuDrL5829MOfx5L=O68dou6mjW_6g@mail.gmail.com>
Subject: Re: [PATCH 0/4] ARM: dts: aspeed: Add Facebook Galaxy100 BMC
To:     Tao Ren <rentao.bupt@gmail.com>
Cc:     Rob Herring <robh+dt@kernel.org>, Andrew Jeffery <andrew@aj.id.au>,
        devicetree <devicetree@vger.kernel.org>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>,
        linux-aspeed <linux-aspeed@lists.ozlabs.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        OpenBMC Maillist <openbmc@lists.ozlabs.org>,
        Tao Ren <taoren@fb.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, 11 Nov 2020 at 23:23, <rentao.bupt@gmail.com> wrote:
>
> From: Tao Ren <rentao.bupt@gmail.com>
>
> The patch series adds the initial version of device tree for Facebook
> Galaxy100 (AST2400) BMC.
>
> Patch #1 adds common dtsi to minimize duplicated device entries across
> Facebook Network AST2400 BMC device trees.
>
> Patch #2 simplfies Wedge40 device tree by using the common dtsi.
>
> Patch #3 simplfies Wedge100 device tree by using the common dtsi.
>
> Patch #4 adds the initial version of device tree for Facebook Galaxy100
> BMC.

Nice. They look good to me.

Reviewed-by: Joel Stanley <joel@jms.id.au>

Is there another person familiar with the design you would like to
review before I merge?


>
> Tao Ren (4):
>   ARM: dts: aspeed: Common dtsi for Facebook AST2400 Network BMCs
>   ARM: dts: aspeed: wedge40: Use common dtsi
>   ARM: dts: aspeed: wedge100: Use common dtsi
>   ARM: dts: aspeed: Add Facebook Galaxy100 (AST2400) BMC
>
>  arch/arm/boot/dts/Makefile                    |   1 +
>  .../dts/aspeed-bmc-facebook-galaxy100.dts     |  57 +++++++++
>  .../boot/dts/aspeed-bmc-facebook-wedge100.dts | 120 +++---------------
>  .../boot/dts/aspeed-bmc-facebook-wedge40.dts  | 112 +---------------
>  .../dts/ast2400-facebook-netbmc-common.dtsi   | 117 +++++++++++++++++
>  5 files changed, 191 insertions(+), 216 deletions(-)
>  create mode 100644 arch/arm/boot/dts/aspeed-bmc-facebook-galaxy100.dts
>  create mode 100644 arch/arm/boot/dts/ast2400-facebook-netbmc-common.dtsi
>
> --
> 2.17.1
>