Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp103267pxb; Wed, 11 Nov 2020 21:40:35 -0800 (PST) X-Google-Smtp-Source: ABdhPJwv0TbTCkSS3dYTvxVN1U0yDg8luOEMGi9Q9sxx96PvBb7lgfljjIFohgxOHaoPAoNU8id5 X-Received: by 2002:a17:906:578b:: with SMTP id k11mr29008595ejq.330.1605159635769; Wed, 11 Nov 2020 21:40:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605159635; cv=none; d=google.com; s=arc-20160816; b=v8Ti5rrCsxoIXZN2KWmtLHt6jR03bkTO2kY0udr5mq9WeXAgVpaCnG7jvoA5cNZlke EEXD0SQhx4TWKtVduanAiD4FUFUrZeYUMcWR8EoD/9Eg95Tq2i3HS4IFxi9Jv5aMGtRE x8Zpo6hVWm4drtpAGV2oJqHMB+N34RPP09me6uFc0wNMfsY1fIPhuJ9hziqthwq/K8a+ bzSt/pUb2o528DR947aAS2O5wI692JTigqwU6iZkMzwiLMC3v6FY4ThNXYjZ0yEyfSm5 yEmwECNpGoKVLykHlqQOi18cUX/Jc/PsKvRvrIbUjU8nbdxBgvin495qh6Obe2WYOPMv pN6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=/sdquviPkooay6TTrYK0X7xKPr4o0uKxRrcpUmK8lqo=; b=glWnpKcWxcOfli9d6L3W4wYc1boshAkR6Vgh37PPVyXBGJJzckRFIdlv+R75bhjZwE 33n/BoeTHHEljwY5pvhUlD7BTqYMfphWvzXwLVJstE4kccpkNdQmjyqqaGxWuTZSq5Zj lUEmph0/E4DUWnHczBGt2RP6JD07BPmOFKQ/O/UskTPwWhdyPOotDxGBHfbjGnwyVgad u3ar16D643jtsN/fnh1UwogtC1S2ILdagogcE9eSj/pa8QtaMIcixJpckmowdj5UrGzG avk2b4PdUXXg4q0pGqQi6YGyEnVXoJ6mrqw/3PVJxNRqdss69rzN2iIcEPrA1wDnVlLL 0A0A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=E60S7XqW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y23si3328900edm.338.2020.11.11.21.40.13; Wed, 11 Nov 2020 21:40:35 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=E60S7XqW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729349AbgKLFhd (ORCPT + 99 others); Thu, 12 Nov 2020 00:37:33 -0500 Received: from mail.kernel.org ([198.145.29.99]:41594 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728769AbgKLEXu (ORCPT ); Wed, 11 Nov 2020 23:23:50 -0500 Received: from kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com (unknown [163.114.132.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0481B216FD; Thu, 12 Nov 2020 04:23:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1605155029; bh=VviEERgd2t6FUCvmgqE0g5Z+LFAmEtTYDlIaiVZfBbk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=E60S7XqWtfmq/GlDZgTN2TIt2aEhfiB3np1vnJWXcgY4B+G/8cNFOr5zKqZ+7nWeP jyx2r7qRH/e1lIONBZz76DzllaCRylGJstklmRSNLGAw/s9w6KmPBfp9QP3KMJNYSD jPdbPNpkj4Po9V3EyJpxKFmdNAncUjnfINxZvTeE= Date: Wed, 11 Nov 2020 20:23:48 -0800 From: Jakub Kicinski To: =?UTF-8?B?546L5pOO?= Cc: Richard Cochran , Grygorii Strashko , "David S. Miller" , Samuel Zou , Kurt Kanzenbach , Ivan Khoronzhuk , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V4 net-bugfixs] net/ethernet: Update ret when ptp_clock is ERROR Message-ID: <20201111202348.0c9a051a@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: References: <20201111173218.25f89965@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 12 Nov 2020 10:48:37 +0800 (GMT+08:00) =E7=8E=8B=E6=93=8E wrote: > >On Thu, 12 Nov 2020 09:15:05 +0800 (GMT+08:00) =E7=8E=8B=E6=93=8E wrote:= =20 > >> >Grygorii, would you mind sending a correct patch in so Wang Qing can > >> >see how it's done? I've been asking for a fixes tag multiple times > >> >already :( =20 > >>=20 > >> I still don't quite understand what a fixes tag means=EF=BC=8C > >> can you tell me how to do this, thanks. =20 > > > >Please read: Documentation/process/submitting-patches.rst > > > >You can search for "Fixes:" =20 >=20 > I see, but this bug is not caused by a specific patch, it exists at the b= eginning, so=20 > there is no need to add a fixes tag. Please point out if I understand it = incorrectly,thanks! Please put whatever constitutes the beginning here (first commit of the driver or first commit of git history).