Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp103771pxb; Wed, 11 Nov 2020 21:41:52 -0800 (PST) X-Google-Smtp-Source: ABdhPJzefJfGdrYB3RFkVXqXZxlH1AN7UJnV3+Xfa2NAcF6fGtvJm7crG69rO4/KZtHPYHDbSyZb X-Received: by 2002:a17:906:6d13:: with SMTP id m19mr28735435ejr.345.1605159712507; Wed, 11 Nov 2020 21:41:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605159712; cv=none; d=google.com; s=arc-20160816; b=VeaDfljOP2l4mKaYJzkQ3ohSuD87HXA8VzDr4gRG/joTgJwEhSyBWPRz/0Ibbd+y1B 5G02L8FLaaZbcMc95qPb80R4IwqYpCWkKLCB/gerTnY9nicDP8dY4fOOb/i4EOqWZaDE pamuHBfkdthYx3kgbxCtXyHEDhC5+1EKDKKzYpdhK7/38Y+2vAqKjNefce5Qu9dJx7Uo Ih6re9nSiKWuDV50p3Fr2nNJp4rpPNtOPUyIijSXQZrDMAts9hynmOQpB2uD33S2lKRR KCNOZO/F34Zf4bYoF9HofKyfgobkWyrSFiyu9yCSp3XLeBejKxKijOB0X0WB4iMJtWMN kCmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to :mime-version:user-agent:date:message-id:from:references:cc:to :subject; bh=VfbEZnc01jv0e0GB8X6Qp+lbpgQkeKA4+O4JqnXr/0U=; b=Qi8EShenLGnuDRQE/bU00PuHsQ+G4oTQOHVyq2ZOpUFYTkUZ3hNV777wXrFSGWEU78 9Q2hUPZ+lhCVIzdGmHc+WUZ4Lkxo79Gsg3lG1+MaiRxkUjZXmVznSv/qrVxjY1fNBoqp uT+7EkVT/NXjTWfr+KNi8Kvb4ewbsKI6VuIzKS259Y0deNJDHth3uSAz9vQ3Qwve/U1m 7/Dw+QWWltD2Wu+ePSPADpo8UB29oWhfDRTIGKErn0JVPon07xFKvJ15AJKcwt1TTNX6 kmAsKCl1Wta7x/xOBhSGMzel4o34TXs4ZV+rOqi/CgDFsG5PgspnYMB89OSTmHDimS3U emIg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c1si3139178edq.286.2020.11.11.21.41.29; Wed, 11 Nov 2020 21:41:52 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729220AbgKLFgr (ORCPT + 99 others); Thu, 12 Nov 2020 00:36:47 -0500 Received: from out30-43.freemail.mail.aliyun.com ([115.124.30.43]:57356 "EHLO out30-43.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728329AbgKLDgP (ORCPT ); Wed, 11 Nov 2020 22:36:15 -0500 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R101e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04394;MF=alex.shi@linux.alibaba.com;NM=1;PH=DS;RN=22;SR=0;TI=SMTPD_---0UF1vPTE_1605152168; Received: from IT-FVFX43SYHV2H.local(mailfrom:alex.shi@linux.alibaba.com fp:SMTPD_---0UF1vPTE_1605152168) by smtp.aliyun-inc.com(127.0.0.1); Thu, 12 Nov 2020 11:36:09 +0800 Subject: Re: [PATCH v21 15/19] mm/compaction: do page isolation first in compaction To: Hugh Dickins , Vlastimil Babka Cc: akpm@linux-foundation.org, mgorman@techsingularity.net, tj@kernel.org, khlebnikov@yandex-team.ru, daniel.m.jordan@oracle.com, willy@infradead.org, hannes@cmpxchg.org, lkp@intel.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, shakeelb@google.com, iamjoonsoo.kim@lge.com, richard.weiyang@gmail.com, kirill@shutemov.name, alexander.duyck@gmail.com, rong.a.chen@intel.com, mhocko@suse.com, vdavydov.dev@gmail.com, shy828301@gmail.com References: <1604566549-62481-1-git-send-email-alex.shi@linux.alibaba.com> <1604566549-62481-16-git-send-email-alex.shi@linux.alibaba.com> From: Alex Shi Message-ID: <6d2d215e-fd72-b8cc-331f-189ea04a361d@linux.alibaba.com> Date: Thu, 12 Nov 2020 11:35:23 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=gbk Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ?? 2020/11/12 ????10:28, Hugh Dickins ะด??: >>> * Page become compound since the non-locked check, >>> * and it's on LRU. It can only be a THP so the order >>> @@ -990,16 +1002,13 @@ static bool too_many_isolated(pg_data_t *pgdat) > Completely off-topic, and won't matter at all when Andrew rediffs into > mmotm: but isn't it weird that this is showing "too_many_isolated(", > when actually the function is isolate_migratepages_block()? > My git version is too low for this. Thanks for reminder. the latest git work fine on correct function name. Thanks