Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp136501pxb; Wed, 11 Nov 2020 22:54:10 -0800 (PST) X-Google-Smtp-Source: ABdhPJw3UZcFB/sWp7oCgObQOBJZsb28uBc26CCk0n5niXmZfNqrgKlBS3EYG9/435GZ+oT0IW85 X-Received: by 2002:a17:906:5a88:: with SMTP id l8mr19124848ejq.407.1605164049832; Wed, 11 Nov 2020 22:54:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605164049; cv=none; d=google.com; s=arc-20160816; b=rgwceygs1Rs8AurYKfwPMqGD0LWTbCYl5MejCT5u+nxycM4FLO3mwwkdCgvmwPzcMt imHN40uy6BfLKyzqB8VbmEW9ufs/tRkRHEWfVXHoNw3n88liVjkuDinQaPrB7QON6Swu HSGYic2e2OyodkTYYYrbSYF0z22WzIGJRzqNz2eYXKWiBvNNBH1xwvFRupjErUHBvGut KkIsSjU5sSbeHaHh0B0Sv1A8EEkuxe2QAf0nDKLVAOgKeVZEYWPoqp1kTKHSyD/mGO6P VEtwsY3zsRoKvJgrVDK32ZahL+/oagssqHIow02vMuzvq3lXlZmV9wjVVePvn+5V57z3 ceMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=RXNksITiYSobSPRH362H2VhuhpXaaVGPBRzNHwuJK4M=; b=xB6EOvTa3vYu5TzfPETSUqqrrBEos2BFP6UD3D5zN/64KCIVsaci0O/a/9hSNhfQTE mnYq3n5jMIGOZPe/PUvQBK3vUtmkdBFsXf9CCm1eq9k28GSgxFYHPwXURzBw9ql6XfJO S36MeN10u4uGisAPslyDaPMk29oYVEYYSgRFWo5hygGh7adOFZ5Lop6nq0xlfQxkGm5H m9ov8fYdIVmuS+Ss5Tm0Y9UJilqtWz2A77nz2rxaf+UwCeM/k0io0r2++wPjTVcbBBUw rQtjna+WJsxwxn7vLan5QqPfzmCe4Bs9SfMawXL4Bsgvrl4oxlUe+oxJrSiuI4HmVX2M ED2A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c15si3419995edf.17.2020.11.11.22.53.46; Wed, 11 Nov 2020 22:54:09 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726634AbgKLGwF (ORCPT + 99 others); Thu, 12 Nov 2020 01:52:05 -0500 Received: from a.mx.secunet.com ([62.96.220.36]:33850 "EHLO a.mx.secunet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726203AbgKLGwE (ORCPT ); Thu, 12 Nov 2020 01:52:04 -0500 Received: from localhost (localhost [127.0.0.1]) by a.mx.secunet.com (Postfix) with ESMTP id 7FCCB20265; Thu, 12 Nov 2020 07:52:02 +0100 (CET) X-Virus-Scanned: by secunet Received: from a.mx.secunet.com ([127.0.0.1]) by localhost (a.mx.secunet.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ooKxlV0UZRKt; Thu, 12 Nov 2020 07:52:01 +0100 (CET) Received: from cas-essen-01.secunet.de (unknown [10.53.40.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by a.mx.secunet.com (Postfix) with ESMTPS id F0069200BB; Thu, 12 Nov 2020 07:52:01 +0100 (CET) Received: from mbx-essen-01.secunet.de (10.53.40.197) by cas-essen-01.secunet.de (10.53.40.201) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1979.3; Thu, 12 Nov 2020 07:52:01 +0100 Received: from gauss2.secunet.de (10.182.7.193) by mbx-essen-01.secunet.de (10.53.40.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2044.4; Thu, 12 Nov 2020 07:52:01 +0100 Received: by gauss2.secunet.de (Postfix, from userid 1000) id 4ECF53181489; Thu, 12 Nov 2020 07:52:01 +0100 (CET) Date: Thu, 12 Nov 2020 07:52:01 +0100 From: Steffen Klassert To: Yu Kuai CC: , , , <0x7f454c46@gmail.com>, , , , Subject: Re: [PATCH] net: xfrm: fix memory leak in xfrm_user_policy() Message-ID: <20201112065201.GE15658@gauss3.secunet.de> References: <20201110011443.2482437-1-yukuai3@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20201110011443.2482437-1-yukuai3@huawei.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-ClientProxiedBy: cas-essen-01.secunet.de (10.53.40.201) To mbx-essen-01.secunet.de (10.53.40.197) X-EXCLAIMER-MD-CONFIG: 2c86f778-e09b-4440-8b15-867914633a10 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 10, 2020 at 09:14:43AM +0800, Yu Kuai wrote: > if xfrm_get_translator() failed, xfrm_user_policy() return without > freeing 'data', which is allocated in memdup_sockptr(). > > Fixes: 96392ee5a13b ("xfrm/compat: Translate 32-bit user_policy from sockptr") > Reported-by: Hulk Robot > Signed-off-by: Yu Kuai Patch applied, thanks!