Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] Input: ads7846 - fix unaligned access on 7845
To:     Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        linux-input@vger.kernel.org
Cc:     Anatolij Gustschin <agust@denx.de>, linux-kernel@vger.kernel.org,
        Oleksij Rempel <o.rempel@pengutronix.de>
References: <20201112012742.GA3608551@dtor-ws>
From:   Oleksij Rempel <linux@rempel-privat.de>
Message-ID: <de67681c-b392-198c-f73e-4c9073d8f1e3@rempel-privat.de>
Date:   Thu, 12 Nov 2020 09:04:23 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.3.2
MIME-Version: 1.0
In-Reply-To: <20201112012742.GA3608551@dtor-ws>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hello Dmitry,

Am 12.11.20 um 02:27 schrieb Dmitry Torokhov:
> req->sample[1] is not naturally aligned at word boundary, and therefore
> we should use get_unaligned_be16() when accessing it.
>
> Fixes: 3eac5c7e44f3 ("Input: ads7846 - extend the driver for ads7845 con=
troller support")
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

I do not have ads7845, but i  assume i need to resend my patch with the sa=
me fix. Correct?

> ---
>
> Not tested on hardware, so if somebody has the controller and can verify
> that would be great.
>
>
>  drivers/input/touchscreen/ads7846.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/input/touchscreen/ads7846.c b/drivers/input/touchsc=
reen/ads7846.c
> index 95e89f675ad5..35d14bc44aff 100644
> --- a/drivers/input/touchscreen/ads7846.c
> +++ b/drivers/input/touchscreen/ads7846.c
> @@ -33,6 +33,7 @@
>  #include <linux/regulator/consumer.h>
>  #include <linux/module.h>
>  #include <asm/irq.h>
> +#include <asm/unaligned.h>
>
>  /*
>   * This code has been heavily tested on a Nokia 770, and lightly
> @@ -443,7 +444,7 @@ static int ads7845_read12_ser(struct device *dev, un=
signed command)
>
>  	if (status =3D=3D 0) {
>  		/* BE12 value, then padding */
> -		status =3D be16_to_cpu(*((u16 *)&req->sample[1]));
> +		status =3D get_unaligned_be16(&req->sample[1]);
>  		status =3D status >> 3;
>  		status &=3D 0x0fff;
>  	}
>


=2D-
Regards,
Oleksij