Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 12 Nov 2020 09:02:02 +0100
From:   Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To:     Chris Packham <chris.packham@alliedtelesis.co.nz>
Cc:     akpm@linux-foundation.org, rppt@kernel.org,
        thomas.petazzoni@free-electrons.com, arnd@arndb.de,
        jason@lakedaemon.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bus: mvebu-mbus: make iounmap() symmetric with
 ioremap()
Message-ID: <20201112090202.638c0c13@windsurf>
In-Reply-To: <20201112032149.21906-1-chris.packham@alliedtelesis.co.nz>
References: <20201112032149.21906-1-chris.packham@alliedtelesis.co.nz>
Organization: Bootlin
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Thu, 12 Nov 2020 16:21:49 +1300
Chris Packham <chris.packham@alliedtelesis.co.nz> wrote:

> make coccicheck complains:
> 
>   ./drivers/bus/mvebu-mbus.c:1113:2-8: ERROR: missing iounmap; ioremap on line 1106 and execution via conditional on line 1111
> 
> It took some staring but I don't think there is a problem because the
> file global `mbus_state` is passed mvebu_mbus_common_init() as the
> `mbus` parameter so `mbus_state.mbuswins_base` and `mbus->mbuswins_base`
> are the same thing. But this is confusing for anyone reading the code
> and one less complaint from coccicheck would be nice so lets fix it.
> 
> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>

Acked-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com