Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp192666pxb; Thu, 12 Nov 2020 00:56:05 -0800 (PST) X-Google-Smtp-Source: ABdhPJwfbQed0PAjAmWOPRv/GFy34rKd+YtJ+PPH+JZ9JgShEFv2vjowajp5+0V8Wb/Jzaauk0xs X-Received: by 2002:a17:906:5d9:: with SMTP id t25mr28727720ejt.443.1605171365455; Thu, 12 Nov 2020 00:56:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605171365; cv=none; d=google.com; s=arc-20160816; b=T7+vXJ0Orsm5TF+4vZKfVp0psnAjkxKHakij/WTCl8T04pLu7Qdk5wA0O7NFOUp1uU zHFpIKSZIE6UbXUq3R2IXIXVaZ/FsD8OztG1FgC/V+1aviDyH2MBCxfTg0vxgpLFG0Lh RP/5xG6M7Duz6hnvLZpTqsSi3kGPAKyhDh5uGxBez8nmL6uy4GBH3fN1Qf2WZGX7Tmk3 41eJsPLjS4URxmPGZZaGh4dK+a/uoAfG8ZhEeJ6Z3PTI72iTvbVwUkkUeSOpeSDCerDF dTgC9gRvP5rAyGkUEjVIkcGs7Lfp3WjYYx6Hu2sbbAqsYvthsyg+A7lva32n9nwjZt2Q NETw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=U+4OvaJsJyfJg3CRjdXPF89yjmQfXFvFFMvlAQpUbuQ=; b=Xl6V9OoDokwVPz4Fx0HQekGgnFJawNKbX/qyTt4ijf6we1MQ2IXAjY6ovLEOPQJTuu mvnz4g3Uk+3H3wTQ7xZNMbCqh2Ta4zHYdIXMMDrVkrNBNWP7VsEuC8q8ZcFR1duQMxLS iQNJdE4Wm0lf7JZVS4hLi9HzmfUYYGkl+iDkkOilMiBeaKpw+2sNXWdiGF74EIzAwSHF 8B6/3yrwInLF4CMxlnN64VXYDhD6KlaotogHAdWCiErcReaubfl7oxY4IrccR487g2h9 OWiOAqpKT8gBpadoquIaSbZuowt5OijIpJt8eMTTJ6/NS4LkpJlXl4b9/TWLj6JDl8er oSyw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y4si3198637ejj.723.2020.11.12.00.55.40; Thu, 12 Nov 2020 00:56:05 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726671AbgKLIwi (ORCPT + 99 others); Thu, 12 Nov 2020 03:52:38 -0500 Received: from lgeamrelo13.lge.com ([156.147.23.53]:34154 "EHLO lgeamrelo11.lge.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725902AbgKLIwi (ORCPT ); Thu, 12 Nov 2020 03:52:38 -0500 Received: from unknown (HELO lgeamrelo01.lge.com) (156.147.1.125) by 156.147.23.53 with ESMTP; 12 Nov 2020 17:52:35 +0900 X-Original-SENDERIP: 156.147.1.125 X-Original-MAILFROM: byungchul.park@lge.com Received: from unknown (HELO X58A-UD3R) (10.177.222.33) by 156.147.1.125 with ESMTP; 12 Nov 2020 17:52:35 +0900 X-Original-SENDERIP: 10.177.222.33 X-Original-MAILFROM: byungchul.park@lge.com Date: Thu, 12 Nov 2020 17:51:14 +0900 From: Byungchul Park To: Ingo Molnar Cc: torvalds@linux-foundation.org, peterz@infradead.org, mingo@redhat.com, will@kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, rostedt@goodmis.org, joel@joelfernandes.org, alexander.levin@microsoft.com, daniel.vetter@ffwll.ch, chris@chris-wilson.co.uk, duyuyang@gmail.com, johannes.berg@intel.com, tj@kernel.org, tytso@mit.edu, willy@infradead.org, david@fromorbit.com, amir73il@gmail.com, bfields@fieldses.org, gregkh@linuxfoundation.org, kernel-team@lge.com Subject: Re: [RFC] Are you good with Lockdep? Message-ID: <20201112085114.GC14554@X58A-UD3R> References: <20201111050559.GA24438@X58A-UD3R> <20201111105441.GA78848@gmail.com> <20201112061532.GA14554@X58A-UD3R> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201112061532.GA14554@X58A-UD3R> User-Agent: Mutt/1.5.21 (2010-09-15) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 12, 2020 at 03:15:32PM +0900, Byungchul Park wrote: > > If on the other hand there's some bug in lockdep itself that causes > > excessive false positives, it's better to limit the number of reports > > to one per bootup, so that it's not seen as a nuisance debugging > > facility. > > > > Or if lockdep gets extended that causes multiple previously unreported > > (but very much real) bugs to be reported, it's *still* better to > > handle them one by one: because lockdep doesn't know whether it's real > > Why do you think we cannot handle them one by one with multi-reporting? > We can handle them with the first one as we do with single-reporting. > And also that's how we work, for example, when building the kernel or > somethinig. Let me add a little bit more. I just said the fact that we are able to handle the bugs one by one as if we do with single-reporting. But the thing is multi-reporting could be more useful in some cases. More precisely speaking, bugs not caused by IRQ state will be reported without annoying nuisance. I bet you have experienced a ton of nuisances when multi-reporting Lockdep detected a deadlock by IRQ state. For some cases, multi-reporting is as useful as single-reporting, while for the other cases, multi-reporting is more useful. Then I think we have to go with mutil-reporting if there's no technical issue. Thanks, Byungchul