Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201111205349.24815-1-jcmvbkbc@gmail.com> <faf78325-3aef-e4aa-ddc6-c21e84a8c7ef@kernel.dk>
In-Reply-To: <faf78325-3aef-e4aa-ddc6-c21e84a8c7ef@kernel.dk>
From:   Max Filippov <jcmvbkbc@gmail.com>
Date:   Thu, 12 Nov 2020 01:12:36 -0800
Message-ID: <CAMo8BfL=3PEi3GWd6LR9kiKViN=t1KbgbkjEEwT8GAb-Uvnp0A@mail.gmail.com>
Subject: Re: [PATCH v2] xtensa: fix broken TIF_NOTIFY_SIGNAL assembly
To:     Jens Axboe <axboe@kernel.dk>
Cc:     "open list:TENSILICA XTENSA PORT (xtensa)" 
        <linux-xtensa@linux-xtensa.org>, Chris Zankel <chris@zankel.net>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, Nov 11, 2020 at 1:05 PM Jens Axboe <axboe@kernel.dk> wrote:
>
> On 11/11/20 1:53 PM, Max Filippov wrote:
> > TIF_NOTIFY_SIGNAL handling in xtensa assembly is implemented
> > incorrectly: there should be a call to do_notify_resume when either
> > TIF_SIGPENDING, TIF_NOTIFY_RESUME or TIF_NOTIFY_SIGNAL bit is set in the
> > thread_info::flags. The straightforward way to do it would be
> >
> >     _bbsi.l a4, TIF_NEED_RESCHED, 3f
> >     _bbsi.l a4, TIF_NOTIFY_RESUME, 2f
> >     _bbsi.l a4, TIF_NOTIFY_SIGNAL, 2f
> >     _bbci.l a4, TIF_SIGPENDING, 5f
> >
> > Optimize it a little bit and use bit mask and bnone opcode to skip
> > do_notify_resume invocation. Shuffle _TIF_* flags a bit so that used bit
> > mask fits into the immediate field of movi opcode.
>
> Thanks - do you mind if I fold this in with a reference to your
> changes? Seems like that'd be a better option than leaving it
> broken for a bit.

Sure Jens, by all means!

-- 
Thanks.
-- Max