Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp214928pxb; Thu, 12 Nov 2020 01:41:01 -0800 (PST) X-Google-Smtp-Source: ABdhPJyEvIMU4V4l1DW/UhvxgH0ymTeFzDU7DtofPBXujbRfOyIR3zrXgsiS0txfAyrAzD2bduFt X-Received: by 2002:a17:906:d0cd:: with SMTP id bq13mr28167800ejb.372.1605174061187; Thu, 12 Nov 2020 01:41:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605174061; cv=none; d=google.com; s=arc-20160816; b=wWsYn/JczI0i6/rcZj+uI32SevRm8tz+8/Crx3LWuOYvLWn0qoIsZcuNV/OY0z4ruV kkiGuebdOzZdOQCfM40TOHJWqM0G4liVTKLy7CqA7LIg33V/lzCNG4TeTsSF316xq4L4 sLQEKuDxp3an3scDdKF7iyKnZyXuQNu54pKiY2ADqt81iyLt+ZOAiaGU6XqWpiaoA4lP aAt87b5nKyOULFoLG43u9pwyQtuM92vwTd53aQ+WamxaurJPbFxYaWH3d9JLGqQx/FxN X/JG46AsvRAwXuE1iKheo5z9OAmMcHu9jasbwPS4yGvZ7APQDNZev7xH5i5a9Mk2/aPj /J1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=cnWNfTHVU4AEXtUdky7SzwT/9uPYUSiJsLa4+lGu8a8=; b=jekng1qv7TfxINLHjV0NZiWjL+0QpnS/gpTXXcYkoJTSgj5v6m/SPhcNBznNCJgaIR fXY4oSuVk1uT63FDIIDWdvWjIzaImxJKwW2sb2p3ltEPrt7o9dhCCtX9bfRdALMIY0dK ffj+qzn0neSMwbfAAVO6rvrnq6QpzPB1Vpp15IlhMR6tmTrb6krrdy7+guCVheD7jzAn wd1fFG4ETV7RKxDI0d1g+/vpOq9K3lrP8hpuG2Ti89ywe42P7RYIRuCEodxbPmJtaDsI zamlnmWNONnRbc9nX4C38yXJylcYmOw4igRqhbuMj+IS3EP98/i6Z0AiLgDzIid3h19h bsCg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=TS+osSOL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w5si3522469edr.174.2020.11.12.01.40.37; Thu, 12 Nov 2020 01:41:01 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=TS+osSOL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727656AbgKLJiD (ORCPT + 99 others); Thu, 12 Nov 2020 04:38:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41876 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725928AbgKLJiC (ORCPT ); Thu, 12 Nov 2020 04:38:02 -0500 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 92295C0613D1; Thu, 12 Nov 2020 01:38:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=cnWNfTHVU4AEXtUdky7SzwT/9uPYUSiJsLa4+lGu8a8=; b=TS+osSOLMCGS4fDhHQTgjKOJng BYlhxXc3gLOHA83cYAk937kLntXcC6InGwuROC6f3+DNXtadbsoCtWKcuJq+4QHBcbLIDJXRnhv3O TgwYa19YZrdoay+00fILS+4mXPV1zn86DlTvKunG6818dlenu1z6R3vqxPitwFciMy3bGiQGufPJV f85noQ79w/nqcaXyIVlVKqbi3tUtgKvqyDQXPbTV+4lGzFZl0h/X1Ata7YI/5k7OM45eG+xWULmyy Ae6xOmkLS4xDI8cDZW7qMIiesvh1sXT1IzJFPRfrYe107Ic/sVtMZqYTGKf16h6YLtppwPKFPMdAy wnh82Y0g==; Received: from hch by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kd93A-0006O5-8p; Thu, 12 Nov 2020 09:37:52 +0000 Date: Thu, 12 Nov 2020 09:37:52 +0000 From: Christoph Hellwig To: Tyrel Datwyler Cc: james.bottomley@hansenpartnership.com, martin.petersen@oracle.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, brking@linux.ibm.com, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH 1/6] ibmvfc: byte swap login_buf.resp values in attribute show functions Message-ID: <20201112093752.GA24235@infradead.org> References: <20201112010442.102589-1-tyreld@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201112010442.102589-1-tyreld@linux.ibm.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 11, 2020 at 07:04:37PM -0600, Tyrel Datwyler wrote: > Both ibmvfc_show_host_(capabilities|npiv_version) functions retrieve > values from vhost->login_buf.resp buffer. This is the MAD response > buffer from the VIOS and as such any multi-byte non-string values are in > big endian format. > > Byte swap these values to host cpu endian format for better human > readability. The whole series creates tons of pointlessly over 80 char lines. Please do a quick fixup.