Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 12 Nov 2020 10:54:22 +0100
From:   Maxime Ripard <maxime@cerno.tech>
To:     Frank Lee <frank@allwinnertech.com>
Cc:     robh+dt@kernel.org, wens@csie.org, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        tiny.windzz@gmail.com
Subject: Re: [PATCH] arm64: dts: allwinner: a64: fix sid node name
Message-ID: <20201112095422.in6s5ctgv7in35on@gilmour.lan>
References: <20201109122101.23302-1-frank@allwinnertech.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="ja54jhtdryuhpwu3"
Content-Disposition: inline
In-Reply-To: <20201109122101.23302-1-frank@allwinnertech.com>
Precedence: bulk


--ja54jhtdryuhpwu3
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Mon, Nov 09, 2020 at 08:21:01PM +0800, Frank Lee wrote:
> From: Yangtao Li <frank@allwinnertech.com>
>=20
> Sid should be an efuse type device accurately. And no one
> needs sid label, so delete it.
>=20
> Signed-off-by: Yangtao Li <frank@allwinnertech.com>
> ---
>  arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/b=
oot/dts/allwinner/sun50i-a64.dtsi
> index dc238814013c..96543df5d890 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> @@ -520,7 +520,7 @@ mmc2: mmc@1c11000 {
>  			#size-cells =3D <0>;
>  		};
> =20
> -		sid: eeprom@1c14000 {
> +		efuse@1c14000 {
>  			compatible =3D "allwinner,sun50i-a64-sid";
>  			reg =3D <0x1c14000 0x400>;
>  			#address-cells =3D <1>;

I agree with this on principle, but we should do it on all the SoCs at
once. Can you send another version doing so?

Thanks!
Maxime

--ja54jhtdryuhpwu3
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCX60GTgAKCRDj7w1vZxhR
xVERAP97kOrnqreDaUK+yUflbqy4M0PS2Zje0xX+CM4v2nj/EgD/XqZe6xQGR5vD
WBR+Qr+EY72WpPHKCiZQqgZN0IhPwg0=
=kh5v
-----END PGP SIGNATURE-----

--ja54jhtdryuhpwu3--