Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp257562pxb; Thu, 12 Nov 2020 03:07:40 -0800 (PST) X-Google-Smtp-Source: ABdhPJwvYfd5crXRgPiXGjvczEACi3c5RiwW0vX3RENHTYgPBJG7ZTD1sWXn4wHVQo5H2Y51Xxa4 X-Received: by 2002:a17:906:ae52:: with SMTP id lf18mr31450018ejb.9.1605179260357; Thu, 12 Nov 2020 03:07:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605179260; cv=none; d=google.com; s=arc-20160816; b=AmPLMqeGkSNSRyKhxPZfQxzter2kaf8NRfFJVQ1SXqt567HeuRVMF36BYqF0D/pvX3 1F2kgDmjdhhRcSpAQTkxDyk15jFIcbi4FOs1KPSdmH8kvZd9rUfi8kLerumndepSYGH0 XXHNFkCgeCuaf31yIKXZWneK6FWJDeJe0vP1qmOuyBpgidkdb0jGegbdch63wl6Mu4// oRei1inYQmt5ZnnOgrFsc0mG8KgSJ49hkwdfbD6kXrkv6HoXixhzm9r5kZNfeQJC4VNE ofdmFM32/QM1HNfbNUcDCIhr0i397Kv/CudvOpqBkKE8ymdI7KCwnywTtW9CivTJrqu/ 2zhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=lDq1ucxwNVdiyOuGDpG3UuS4AQsRLKqvrJ8cBQ65tp8=; b=AmJc2m19iwxmG8j85Sfgj1yHYZwkAhstCv0T4QGt8C7StZEu2u5aru+8CQ3fj7E0X/ ss4Rg5zmGkeo8CXPYM/xhfVcPCv0evxCbq1VHgJgubFEppPBI38dDbSnYwWJMtnkEnk+ oj5cNJfE9u2PnVMewIG0edEpFPGWwRs7y1HtVJnxGWOErSHY9JA6DNzdflPNYpf7xvDK FnFkgmX8VSkWnAqN3hGObGAM1pmzA/gOxGAcaeGAjPNBYCqa8q4XBoRQjl3bnM7rWIVc DKyCa9oLGQxjvk26Xc7wKwATscvYrUFUyxkJxWge7GkGS+R/NU1c0o7j4T/4NDZFiL5z 3YAg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=FztJ+8sX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f3si3325394ejc.451.2020.11.12.03.07.17; Thu, 12 Nov 2020 03:07:40 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=FztJ+8sX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728131AbgKLLCv (ORCPT + 99 others); Thu, 12 Nov 2020 06:02:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55122 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728074AbgKLLCb (ORCPT ); Thu, 12 Nov 2020 06:02:31 -0500 Received: from mail-wm1-x343.google.com (mail-wm1-x343.google.com [IPv6:2a00:1450:4864:20::343]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4F4B2C061A4F for ; Thu, 12 Nov 2020 03:02:27 -0800 (PST) Received: by mail-wm1-x343.google.com with SMTP id h62so5100219wme.3 for ; Thu, 12 Nov 2020 03:02:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=lDq1ucxwNVdiyOuGDpG3UuS4AQsRLKqvrJ8cBQ65tp8=; b=FztJ+8sXVteaVXQlm1MysT50leos1FgWA71xWpI6b3mwdJ/d/0+JXHOTe8qhRiYbwI EU+0NpeyNV3G3gR8P4TPI48MF+tY+7BYbiJSA2wHhPosXHVoYlZH7OIL9usqmtqgkjGT 0zEbOY0mQ1sM3RR+AuS/PBKBrI9okpRyT6BRUYl5O86GEmsFlHD8WFtDWUJ4Ph3Be7DA mnSaqE91cvIPS/6egGhg++TjpAaxQwfZaRU1GJGe58FesqMy6zdOrwyRWBTkglbWn13i C/Hrp2aUvP+O4mlHL4x2gx6sCS2HO2LazlfJc+cXrGtjovpeRgOxeZ2DwgaGj9Wv+gpT IdNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=lDq1ucxwNVdiyOuGDpG3UuS4AQsRLKqvrJ8cBQ65tp8=; b=JJ3KB9aUyzGIeNI4nLsl2h7tWA8wFP8c08Ispr+7qfGTrP5RwJ80dQ6uD9KYUj5hUN MjBcXxd6+5Euw9t5B6kZtOGlR5D4n9BBvIAKw+186MDJdcW+bum6gWf51xbNrp1BMi6h EnkNJOBw6BauNVFL7TT7EQx6fNVm61geAQsWKNCwJSg29y2EK0UPKRpHaJDV2p5qOgHH ssLYwfeua+yca8bx+nNJOTHr/mfuc6HxnwbtpZxoOCCATzndeYr2nW0B6r0bQGnaQlwx /n4+H/ldE1GBzvHyxh/PoVoAe/9BDW5aoMrdGIy9VRn7lhEiMrideBLQAiEdf+x0feuB oKow== X-Gm-Message-State: AOAM533zfm+eg0IaPNTs8rk0voG1i2vUWUrxbVkgxkRN7Jxxcf6TCdB6 xTudpQTIpE3Ltsbdvth8Q8MbC9xCJl+5P1UE X-Received: by 2002:a1c:87:: with SMTP id 129mr9252628wma.34.1605178946051; Thu, 12 Nov 2020 03:02:26 -0800 (PST) Received: from dell.default ([91.110.221.159]) by smtp.gmail.com with ESMTPSA id x81sm6515329wmg.5.2020.11.12.03.02.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Nov 2020 03:02:25 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Dmitry Torokhov , Henrik Rydberg , "Gustavo A. R. Silva" , linux-input@vger.kernel.org Subject: [PATCH 14/15] input: keyboard: applespi: Provide missing struct 'message' descriptions Date: Thu, 12 Nov 2020 11:02:03 +0000 Message-Id: <20201112110204.2083435-15-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201112110204.2083435-1-lee.jones@linaro.org> References: <20201112110204.2083435-1-lee.jones@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/input/keyboard/applespi.c:306: warning: Function parameter or member 'keyboard' not described in 'message' drivers/input/keyboard/applespi.c:306: warning: Function parameter or member 'touchpad' not described in 'message' drivers/input/keyboard/applespi.c:306: warning: Function parameter or member 'tp_info' not described in 'message' drivers/input/keyboard/applespi.c:306: warning: Function parameter or member 'tp_info_command' not described in 'message' drivers/input/keyboard/applespi.c:306: warning: Function parameter or member 'init_mt_command' not described in 'message' drivers/input/keyboard/applespi.c:306: warning: Function parameter or member 'capsl_command' not described in 'message' drivers/input/keyboard/applespi.c:306: warning: Function parameter or member 'bl_command' not described in 'message' drivers/input/keyboard/applespi.c:306: warning: Function parameter or member 'data' not described in 'message' Cc: Dmitry Torokhov Cc: Henrik Rydberg Cc: "Gustavo A. R. Silva" Cc: linux-input@vger.kernel.org Signed-off-by: Lee Jones --- drivers/input/keyboard/applespi.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/input/keyboard/applespi.c b/drivers/input/keyboard/applespi.c index 14362ebab9a9d..8053a3d2ff635 100644 --- a/drivers/input/keyboard/applespi.c +++ b/drivers/input/keyboard/applespi.c @@ -286,6 +286,15 @@ struct command_protocol_bl { * structure (after re-assembly in case of being split over * multiple spi-packets), minus the trailing crc. The total size * of the message struct is therefore @length + 10. + * + * @keyboard: Keyboard message + * @touchpad: Touchpad message + * @tp_info: Touchpad info (response) + * @tp_info_command: Touchpad info (CRC) + * @init_mt_command: Initialise Multitouch + * @capsl_command: Toggle caps-lock LED + * @bl_command: Keyboard brightness + * @data: Buffer data */ struct message { __le16 type; -- 2.25.1