Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp268878pxb; Thu, 12 Nov 2020 03:27:18 -0800 (PST) X-Google-Smtp-Source: ABdhPJyR39hW/Y6+3IV8+3NK8cJyAh1QG3yM9M7sDu+BXRD4gq/tCPhFfmZwsg0GiQwX7I3EPH8Z X-Received: by 2002:a17:906:d144:: with SMTP id br4mr1787920ejb.547.1605180438087; Thu, 12 Nov 2020 03:27:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605180438; cv=none; d=google.com; s=arc-20160816; b=CmXG7JhUwqXaPUrF11Z/CAp66QM3KbP5bo1w+ip7YXOH6QdtML9TnpdqD/uPnQtx56 xWlE/O25p3XBAbp6ywxlZXgdJkEScfjQfeeIHi0ZIFjyF/+xAcQE9r82OUrTqRFwiaYp uA1j+cQKr0UZLu42SE3RKS1j45d00ttVM3OUieOv/3etdpFBJRl0MYzbU5Ywjm0a+mxK Lr0p+IMHYFe5yG4At8vmsEGhs3F/nRwRKo/jGcoVAVy/AMOTSRd9UzjLsrFAKkev6VjB Fei6Ol/tJNm+UmHVyh1V1i+IQkPn5Wg+oxwtLnOudhcXqS3c+v627QKwIm94sH+/53VE rGRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=szqL77OyEVf5vlwPlO5u0pCoBC9WdDfxlvV/jS14f7E=; b=pyu/QG6qiC+8gP6o8nIYj/akdoN4LssXswPkPcpT0TNjT0T91oj0VovDL+m3+QKg9J hMySlZQ33KE01HUQKiVs1rWk+M8wUY3OT7Eh9KvGhIuoxTvuT2fjXWOky7uJ1rw3Ruxj PRiKXc00JjtBLd1oyhYXwUzl4WvWDx7pRM/cxRibZGbg+cVljuzzW8JMgYBp60rFpQWB H3XtZWj9/2FZ/ETbw0sLnTwiNU++FxMxnHDS3cLU/DUmOVDtUAKWB5D4CdEGZfB056dq LiT1j8P9j0pFMMmZQv6UCBCojmBThaFFVQKD3a1LGAwr+7mM6x3jFZlTvEsjDEv7xOna rygQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=W+eu3SDU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id mc1si3508605ejb.219.2020.11.12.03.26.55; Thu, 12 Nov 2020 03:27:18 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=W+eu3SDU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727925AbgKLLYL (ORCPT + 99 others); Thu, 12 Nov 2020 06:24:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58570 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725966AbgKLLYJ (ORCPT ); Thu, 12 Nov 2020 06:24:09 -0500 Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AC766C0613D1 for ; Thu, 12 Nov 2020 03:24:08 -0800 (PST) Received: by mail-wr1-x444.google.com with SMTP id b8so5627686wrn.0 for ; Thu, 12 Nov 2020 03:24:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=szqL77OyEVf5vlwPlO5u0pCoBC9WdDfxlvV/jS14f7E=; b=W+eu3SDUj96qApW3fPXVb+xDPNnyinb5iqfjnyWgB2qExiVq0mQwKnClSWWjqkt8OZ fJkNHuW70oPJ/doSMrRfRizxIy6jPW2wSlMD8toIvwPk5bh3fOAjgdTBYKG/Aus9N9t3 1bJoWq2anjY3zJZ1pi/FzmllzANSkW2psCgx/vfhv4AXT2YLr/yavichSFSXUCCwNrvZ BHE5035iiBFf6o7siVYZHXjfPiHIdnlGvxplVVriBuEdYHoBIAItWvqRUCeFfG2E6LEa boMBxnUabqFVx09Y8reV5qhqsNMi1rHBANv77VZJ8stUSMd8Y4OfMQ2Vnr292kt8GE6m oE2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=szqL77OyEVf5vlwPlO5u0pCoBC9WdDfxlvV/jS14f7E=; b=RCqfmYJDLz0pCQLEJ1X3/EJWdf0FYL1JqVsRF45jTdaWxQLo+5NHXJq4eXIrN5AFMM Xa6YVuYcSb4+LEQG/LLbE4QOhls5OGShAQJJpK5HjXJ1VmTS4LtsoBbBDbRBX2Qa4CWz d6m762DmN2Wng7hmrFr3tYkye5WYTNKWpa6aBJ2elPKuiNBEXnAHxiAiHEYXGZ8LAAON fMHVsrqM0s2v+UGTvsxzmO7gQZ1sk1BuKk2vfIV6HZ7SMcVD5LQkWIBKXPypqZmmUgtP gKEShwWvBiBbohmcyM1/00wm5b2MEx7fKRMlPgLN/xhXriawvBndYV7u0NhjOqk8r2kP 12HQ== X-Gm-Message-State: AOAM531RMT3N8ZzTknR89nHCVRRiG7m7Ujqx8O2TLZhwMBKQcQyfF45i 6Y6UgiC4KAztLID9kUmfNcLNJQ== X-Received: by 2002:a5d:444c:: with SMTP id x12mr23015463wrr.6.1605180247340; Thu, 12 Nov 2020 03:24:07 -0800 (PST) Received: from ?IPv6:2a01:e34:ed2f:f020:6971:b700:3764:fa96? ([2a01:e34:ed2f:f020:6971:b700:3764:fa96]) by smtp.googlemail.com with ESMTPSA id q7sm6837706wrg.95.2020.11.12.03.24.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Nov 2020 03:24:06 -0800 (PST) Subject: Re: [PATCH v2] thermal/drivers/cpufreq_cooling: Update cpufreq_state only if state has changed To: zhuguangqing83@gmail.com, viresh.kumar@linaro.org, amit.kachhap@gmail.com, javi.merino@kernel.org, rui.zhang@intel.com, amitk@kernel.org Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Zhuguangqing , "v5 . 4+" References: <20201106092243.15574-1-zhuguangqing83@gmail.com> From: Daniel Lezcano Message-ID: <55b484fb-1532-e130-3b05-5a7f5e18a536@linaro.org> Date: Thu, 12 Nov 2020 12:24:05 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201106092243.15574-1-zhuguangqing83@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/11/2020 10:22, zhuguangqing83@gmail.com wrote: > From: Zhuguangqing > > If state has not changed successfully and we updated cpufreq_state, > next time when the new state is equal to cpufreq_state (not changed > successfully last time), we will return directly and miss a > freq_qos_update_request() that should have been. > > Fixes: 5130802ddbb1 ("thermal: cpu_cooling: Switch to QoS requests for freq limits") > Cc: v5.4+ # v5.4+ > Signed-off-by: Zhuguangqing > Acked-by: Viresh Kumar > --- Applied, thanks -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog