Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp282735pxb; Thu, 12 Nov 2020 03:52:01 -0800 (PST) X-Google-Smtp-Source: ABdhPJzv7PlV8NKmElN9Peipo4Y1hcy0QsvG4huIPzD3bpwJstFpYfE5TGT0jaKYB9E2SWZi985k X-Received: by 2002:a17:907:2089:: with SMTP id pv9mr29371009ejb.34.1605181920915; Thu, 12 Nov 2020 03:52:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605181920; cv=none; d=google.com; s=arc-20160816; b=cT0Wo+9bgyvLtxfWJZsn2EEHblojeEP5wGWbDKTrl2Yk/YswVPr26Mm20z3oxmrTdf dUbW8u3tdTSqgDS65HsuhNDYZjWwg6j6ZjK/GhmDB4ESeX5jwShxxY2hskhqYn/46SdH ZAQAsKL0Lq3wYhhjyEKBwNc6WfpvZyFeVEQSAW6qrEoiMt9lKbFH1dU7uILBejwRDOIl xxGG4VYWv/gMjnd0apomE55u0X202GZTkcvsxGY5r53mhsFIGP8Ks6bqifWuwVXAm/zm XFYQsfnN3j/oKI08QKKTB/kGjOdxJe9An9SVR4/VAEcy8XoHIP70Xun3bOSX2SEbPDuT ++Aw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=WviE9e9OR3NAcUNk80zgUspLEQhtD49K6IPRnKJe5uk=; b=OIAeXPo76NNNKvmYyl7uJ1TeI0NCN7xBgbR1D+T8eKMxNB5DRS9XSodeIgZLN75QS/ jeDeIEhP7wcSdXH1JKUGasPCMVajTnYBIEB+0OKy0hQLp1U+Uht7rvvDnjaIEcDlA1Lw QzxMcF8y1xvAIXrtO0EhdVIiJoPscVIL/HBpyMP+I3i+UyDcGZ6jOqDVlO5FapHyCTW2 /Qok68jCNYt8fkRtC6hlxdjHd2BrHZBJvADyu76oFahYQJ2nY5VL5dKqe5NkhWqm+Bs7 mvOlSVTUh5J/vOdi5I42m9rnlZUrdVCK3d7Z7ypBAFZzvbNFQBX5r0cJ70vqbL/gRiRg rwjg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f10si3643897edu.449.2020.11.12.03.51.37; Thu, 12 Nov 2020 03:52:00 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728181AbgKLLuT (ORCPT + 99 others); Thu, 12 Nov 2020 06:50:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34226 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728226AbgKLLtU (ORCPT ); Thu, 12 Nov 2020 06:49:20 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3CB5AC0613D4 for ; Thu, 12 Nov 2020 03:48:57 -0800 (PST) Received: from pty.hi.pengutronix.de ([2001:67c:670:100:1d::c5]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kdB5w-0006Lf-Ft; Thu, 12 Nov 2020 12:48:52 +0100 Received: from ore by pty.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1kdB5v-0001Wn-VL; Thu, 12 Nov 2020 12:48:51 +0100 Date: Thu, 12 Nov 2020 12:48:51 +0100 From: Oleksij Rempel To: Dmitry Torokhov Cc: Alexandru Ardelean , David Jander , kernel@pengutronix.de, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org Subject: Re: [PATCH v2] Input: touchscreen: ads7846.c: Fix race that causes missing releases Message-ID: <20201112114851.mlhhxxjonhx5n4sz@pengutronix.de> References: <20201027105416.18773-1-o.rempel@pengutronix.de> <20201111190740.GY1003057@dtor-ws> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20201111190740.GY1003057@dtor-ws> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 12:48:21 up 363 days, 3:06, 30 users, load average: 0.03, 0.07, 0.01 User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 11, 2020 at 11:07:40AM -0800, Dmitry Torokhov wrote: > Hi Oleksij, > > On Tue, Oct 27, 2020 at 11:54:16AM +0100, Oleksij Rempel wrote: > > From: David Jander > > > > If touchscreen is released while busy reading HWMON device, the release > > can be missed. The IRQ thread is not started because no touch is active > > and BTN_TOUCH release event is never sent. > > > > Fixes: f5a28a7d4858f94a ("Input: ads7846 - avoid pen up/down when reading hwmon") > > Co-Developed-by: David Jander > > Since the patch is nominally attributed to David (via the From: tag) > I'll be changing Co-developed-by tag to your name, OK? OK. > > > Signed-off-by: David Jander > > Signed-off-by: Oleksij Rempel Regards, Oleksij -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |