Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1605180879-2573-1-git-send-email-zhangchangzhong@huawei.com>
In-Reply-To: <1605180879-2573-1-git-send-email-zhangchangzhong@huawei.com>
From:   Bartosz Golaszewski <bgolaszewski@baylibre.com>
Date:   Thu, 12 Nov 2020 12:41:26 +0100
Message-ID: <CAMpxmJXy3upa=xMpuTzoNdgCUyuZ7YQ6kSHtuji8hj7xGo5KGQ@mail.gmail.com>
Subject: Re: [PATCH net] net: ethernet: mtk-star-emac: fix error return code
 in mtk_star_enable()
To:     Zhang Changzhong <zhangchangzhong@huawei.com>
Cc:     nbd@nbd.name, John Crispin <john@phrozen.org>,
        Sean Wang <sean.wang@mediatek.com>,
        Mark Lee <Mark-MC.Lee@mediatek.com>,
        "David S . Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        netdev <netdev@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Nov 12, 2020 at 12:33 PM Zhang Changzhong
<zhangchangzhong@huawei.com> wrote:
>
> Fix to return a negative error code from the error handling
> case instead of 0, as done elsewhere in this function.
>
> Fixes: 8c7bd5a454ff ("net: ethernet: mtk-star-emac: new driver")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com>
> ---
>  drivers/net/ethernet/mediatek/mtk_star_emac.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/mediatek/mtk_star_emac.c b/drivers/net/ethernet/mediatek/mtk_star_emac.c
> index 1325055..2ebacb6 100644
> --- a/drivers/net/ethernet/mediatek/mtk_star_emac.c
> +++ b/drivers/net/ethernet/mediatek/mtk_star_emac.c
> @@ -966,6 +966,7 @@ static int mtk_star_enable(struct net_device *ndev)
>                                       mtk_star_adjust_link, 0, priv->phy_intf);
>         if (!priv->phydev) {
>                 netdev_err(ndev, "failed to connect to PHY\n");
> +               ret = -ENODEV;
>                 goto err_free_irq;
>         }
>
> --
> 2.9.5
>

Acked-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>