Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH V2 4/5] arm64: dts: ti: k3-am654-base-board: Fix up
 un-necessary status set to "okay" for USB
To:     Nishanth Menon <nm@ti.com>, Keerthy <j-keerthy@ti.com>,
        Jyri Sarha <jsarha@ti.com>,
        Tomi Valkeinen <tomi.valkeinen@ti.com>,
        Peter Ujfalusi <peter.ujfalusi@ti.com>,
        Lokesh Vutla <lokeshvutla@ti.com>,
        Rob Herring <robh+dt@kernel.org>,
        Tony Lindgren <tony@atomide.com>, Tero Kristo <t-kristo@ti.com>
CC:     <linux-arm-kernel@lists.infradead.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20201112014929.25227-1-nm@ti.com>
 <20201112014929.25227-5-nm@ti.com>
From:   Roger Quadros <rogerq@ti.com>
Message-ID: <ff878520-4939-0f51-dabf-7f7b5ff54311@ti.com>
Date:   Thu, 12 Nov 2020 15:01:45 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20201112014929.25227-5-nm@ti.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 12/11/2020 03:49, Nishanth Menon wrote:
> The default state of a device tree node is "okay". There is no specific
> use of explicitly adding status = "okay" in the board dts.
> 
> Fixes: 7e7e7dd51d06 ("arm64: dts: ti: k3-am654-base-board: enable USB1")
> Signed-off-by: Nishanth Menon <nm@ti.com>
> Cc: Roger Quadros <rogerq@ti.com>

Acked-by: Roger Quadros <rogerq@ti.com>

cheers,
-roger
> ---
> Changes since v1:
> - no change.
> 
> v1: https://lore.kernel.org/linux-arm-kernel/20201104224356.18040-5-nm@ti.com/
> 
>   arch/arm64/boot/dts/ti/k3-am654-base-board.dts | 8 --------
>   1 file changed, 8 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am654-base-board.dts b/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
> index 199c4d4e7539..744efcbb4f7f 100644
> --- a/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
> +++ b/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
> @@ -325,14 +325,6 @@ &sdhci1 {
>   	disable-wp;
>   };
>   
> -&dwc3_1 {
> -	status = "okay";
> -};
> -
> -&usb1_phy {
> -	status = "okay";
> -};
> -
>   &usb1 {
>   	pinctrl-names = "default";
>   	pinctrl-0 = <&usb1_pins_default>;
> 

-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki