Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751250AbWHUWLP (ORCPT ); Mon, 21 Aug 2006 18:11:15 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751249AbWHUWLP (ORCPT ); Mon, 21 Aug 2006 18:11:15 -0400 Received: from electric-eye.fr.zoreil.com ([213.41.134.224]:11209 "EHLO fr.zoreil.com") by vger.kernel.org with ESMTP id S1751245AbWHUWLN (ORCPT ); Mon, 21 Aug 2006 18:11:13 -0400 Date: Tue, 22 Aug 2006 00:07:35 +0200 From: Francois Romieu To: Henne Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: Linker error on via-velocity driver Message-ID: <20060821220735.GA12622@electric-eye.fr.zoreil.com> References: <44EA14BF.5090102@nachtwindheim.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <44EA14BF.5090102@nachtwindheim.de> User-Agent: Mutt/1.4.2.1i X-Organisation: Land of Sunshine Inc. Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1042 Lines: 33 Henne : [...] > I found a bug in the via-velocity driver, but I cant find a maintainer > for that, so I write to the lists. > This driver depends on CONFIG_INET (tcp/ip) if CONFIG_PM is enabled. > This is tested on i386 and x86_64. > I'm not familiar with network stuff but I don't believe a device should > depend on a protocol. See the comment on top of velocity_get_ip() related to wol and arp. How does it behave with the patch below: diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig index 3918990..30f21b6 100644 --- a/drivers/net/Kconfig +++ b/drivers/net/Kconfig @@ -2173,6 +2173,7 @@ config VIA_VELOCITY select CRC32 select CRC_CCITT select MII + select INET if PM help If you have a VIA "Velocity" based network card say Y here. -- Ueimor - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/