Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp392473pxb; Thu, 12 Nov 2020 06:31:20 -0800 (PST) X-Google-Smtp-Source: ABdhPJziDpfzjVRK42FxtMsXSFIHPkfozVPQiHwe/rwAMVBEkItTdxWfaEJeDn52J4DJfaTHnQW+ X-Received: by 2002:a50:ab5e:: with SMTP id t30mr5467212edc.314.1605191478468; Thu, 12 Nov 2020 06:31:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605191478; cv=none; d=google.com; s=arc-20160816; b=XFo2uDCOUiTiQCj55PEuS8qhwpmRPgdantSFkKdV1GDzcWJc60tcJi7xeLpmaBRSBT Rxc4Z6T9OpZ5bI4OULMmi5gZ/ii0eXokWeIiTXmbhhzjLHF8Rn7W/z1P7GWbW3Hy1IUY fxN51aq8Ly+qtWd4L+d9g9Yh1NzDP2HtIBgTvW1qttuTKjOFaTgeugSKmEcfVVdHnLvq NYzifv0XwtZ0YkfKuX/eRdmry7+0XSt5FHYBvvbHf7zuTakEYItDTFhIxGTHopvE2TgM MU/AtaECQrsuOOyneLF9Iqh1e5a4dyiV8IKs8DiCd0LNK3HAzu/jgkH+FfdNWUhElRlb kT6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:subject:cc:to:from; bh=0EBodTJyPP5oskHDTALGNg/sITrC/GYK/7SJzGiTvI4=; b=Go05O+Ym8wUUYmAM/VZs9Ne1pZ12rToC6oBlsiiY864gU5O6+qnfRBkEA8uthNTUat q3O59WZ1BaDe9i9HYY/zsUMWDpMMGbYzAm0iCWvfR9D9rGZwTehPqktsCtClVUBU5Kve fQu+2Fa03VJ8NYKPnvRf1vGUgWUJ6JeiHKPfq3Yp182uljaj0bGtWSL784kDdLrMvYou pjpM1h3+iSMbpA4hqQsNd7f8SZY/e3sHkdDJq7l71M13s5YscQmKTM5l7M/He746tUiI BhLDCH0KeQInBy7v5Vkdh5CDN3qcqt0o6R/xk/HtxbBQjTAwZgDUp6TM3qp8nqV9KFXt ZpXQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id re2si3602175ejb.378.2020.11.12.06.30.54; Thu, 12 Nov 2020 06:31:18 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728433AbgKLO3G (ORCPT + 99 others); Thu, 12 Nov 2020 09:29:06 -0500 Received: from szxga05-in.huawei.com ([45.249.212.191]:8075 "EHLO szxga05-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727035AbgKLO3G (ORCPT ); Thu, 12 Nov 2020 09:29:06 -0500 Received: from DGGEMS404-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4CX3r03f61zLtvy; Thu, 12 Nov 2020 22:28:48 +0800 (CST) Received: from localhost (10.174.176.180) by DGGEMS404-HUB.china.huawei.com (10.3.19.204) with Microsoft SMTP Server id 14.3.487.0; Thu, 12 Nov 2020 22:28:54 +0800 From: YueHaibing To: , , , , , CC: , , Subject: [PATCH net-next] net/mlx5: Fix passing zero to 'PTR_ERR' Date: Thu, 12 Nov 2020 22:28:45 +0800 Message-ID: <20201112142845.54580-1-yuehaibing@huawei.com> X-Mailer: git-send-email 2.10.2.windows.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.174.176.180] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix smatch warnings: drivers/net/ethernet/mellanox/mlx5/core/esw/acl/egress_lgcy.c:105 esw_acl_egress_lgcy_setup() warn: passing zero to 'PTR_ERR' drivers/net/ethernet/mellanox/mlx5/core/esw/acl/egress_ofld.c:177 esw_acl_egress_ofld_setup() warn: passing zero to 'PTR_ERR' drivers/net/ethernet/mellanox/mlx5/core/esw/acl/ingress_lgcy.c:184 esw_acl_ingress_lgcy_setup() warn: passing zero to 'PTR_ERR' drivers/net/ethernet/mellanox/mlx5/core/esw/acl/ingress_ofld.c:262 esw_acl_ingress_ofld_setup() warn: passing zero to 'PTR_ERR' esw_acl_table_create() never returns NULL, so NULL test should be removed. Signed-off-by: YueHaibing --- drivers/net/ethernet/mellanox/mlx5/core/esw/acl/egress_lgcy.c | 2 +- drivers/net/ethernet/mellanox/mlx5/core/esw/acl/egress_ofld.c | 2 +- drivers/net/ethernet/mellanox/mlx5/core/esw/acl/ingress_lgcy.c | 2 +- drivers/net/ethernet/mellanox/mlx5/core/esw/acl/ingress_ofld.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/esw/acl/egress_lgcy.c b/drivers/net/ethernet/mellanox/mlx5/core/esw/acl/egress_lgcy.c index d46f8b225ebe..2b85d4777303 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/esw/acl/egress_lgcy.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/esw/acl/egress_lgcy.c @@ -101,7 +101,7 @@ int esw_acl_egress_lgcy_setup(struct mlx5_eswitch *esw, vport->egress.acl = esw_acl_table_create(esw, vport->vport, MLX5_FLOW_NAMESPACE_ESW_EGRESS, table_size); - if (IS_ERR_OR_NULL(vport->egress.acl)) { + if (IS_ERR(vport->egress.acl)) { err = PTR_ERR(vport->egress.acl); vport->egress.acl = NULL; goto out; diff --git a/drivers/net/ethernet/mellanox/mlx5/core/esw/acl/egress_ofld.c b/drivers/net/ethernet/mellanox/mlx5/core/esw/acl/egress_ofld.c index c3faae67e4d6..4c74e2690d57 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/esw/acl/egress_ofld.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/esw/acl/egress_ofld.c @@ -173,7 +173,7 @@ int esw_acl_egress_ofld_setup(struct mlx5_eswitch *esw, struct mlx5_vport *vport table_size++; vport->egress.acl = esw_acl_table_create(esw, vport->vport, MLX5_FLOW_NAMESPACE_ESW_EGRESS, table_size); - if (IS_ERR_OR_NULL(vport->egress.acl)) { + if (IS_ERR(vport->egress.acl)) { err = PTR_ERR(vport->egress.acl); vport->egress.acl = NULL; return err; diff --git a/drivers/net/ethernet/mellanox/mlx5/core/esw/acl/ingress_lgcy.c b/drivers/net/ethernet/mellanox/mlx5/core/esw/acl/ingress_lgcy.c index b68976b378b8..d64fad2823e7 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/esw/acl/ingress_lgcy.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/esw/acl/ingress_lgcy.c @@ -180,7 +180,7 @@ int esw_acl_ingress_lgcy_setup(struct mlx5_eswitch *esw, vport->ingress.acl = esw_acl_table_create(esw, vport->vport, MLX5_FLOW_NAMESPACE_ESW_INGRESS, table_size); - if (IS_ERR_OR_NULL(vport->ingress.acl)) { + if (IS_ERR(vport->ingress.acl)) { err = PTR_ERR(vport->ingress.acl); vport->ingress.acl = NULL; return err; diff --git a/drivers/net/ethernet/mellanox/mlx5/core/esw/acl/ingress_ofld.c b/drivers/net/ethernet/mellanox/mlx5/core/esw/acl/ingress_ofld.c index 4e55d7225a26..548c005ea633 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/esw/acl/ingress_ofld.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/esw/acl/ingress_ofld.c @@ -258,7 +258,7 @@ int esw_acl_ingress_ofld_setup(struct mlx5_eswitch *esw, vport->ingress.acl = esw_acl_table_create(esw, vport->vport, MLX5_FLOW_NAMESPACE_ESW_INGRESS, num_ftes); - if (IS_ERR_OR_NULL(vport->ingress.acl)) { + if (IS_ERR(vport->ingress.acl)) { err = PTR_ERR(vport->ingress.acl); vport->ingress.acl = NULL; return err; -- 2.17.1