Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp411112pxb; Thu, 12 Nov 2020 06:56:51 -0800 (PST) X-Google-Smtp-Source: ABdhPJygn6k0z1D7RTZ5aD5E/m+j5oAoXKQUEBOT/tzq8iOqVRaU0nke2lUFfZ+j4BWx6D6iSrGh X-Received: by 2002:a17:906:a843:: with SMTP id dx3mr31816630ejb.313.1605193011625; Thu, 12 Nov 2020 06:56:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605193011; cv=none; d=google.com; s=arc-20160816; b=MRF0e9stcg+Wj9yZjD45exFRVJI++kfunYu3llQ7SENT013+mFWSeoTLPq3eSGXF7A GmFgVL67tGkQWoPwbLX6v0yg0Bod3V+wjYiJeK1OWFVJgm2I8HC+P+1O2pp8bUW/3zOO FQ6RwaVYYAx0dX7b4wJgbCf146kfkefoXu0PXzBMA6E1kRRH/2g6iRV3gzS2VEmFbFoW aXoReONxiLbtv8+itG7pDHdnIib/bCuTTabnjmZP59nM/HhoXqlK3YwN/P4SmpSl21Ui kFyTeNhchifVFNrCO3MUvElX0gRaCjjb59mtaFFGNqmo5bViHmsQmSbH724fNpDdtWGR bJ2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:subject:cc:to:from; bh=9DjTlr+oreGUKS3iVs5e1dVLhTnD92Vy931EQc2cMP0=; b=C11mYnr6dyYa9lOSCEyw/MFbhzyAbEB5XXzmYxHJmbT3UMIoFkSwt2Skk20KWzbwpj iTGdumMgx31LHOwifWrroryIa5JhlVcdMvGZ940YDrYtuziLp+ia7m9JMmfgCFi/2KrU v753XH1DVdjir/DhVbqDeg9jVTgs8g8vHxi5HE1oOFST2UcfkrAr7GkLeNb4WQDfvSu2 wHYDJFAImUpCZY8nKvyGiTik83/4A1u0yh+tmkq/uUzLuAAkmxwe1nfF4yFG1BrJXquV f48d8fA0v9KZ6yNmBau4vlSR2zukMQnG4HWarTEKbJggVAUJ7yf0uHqnI4+XeoGol2mH z6Qg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id mb12si3714791ejb.555.2020.11.12.06.56.28; Thu, 12 Nov 2020 06:56:51 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728500AbgKLOwr (ORCPT + 99 others); Thu, 12 Nov 2020 09:52:47 -0500 Received: from szxga05-in.huawei.com ([45.249.212.191]:7526 "EHLO szxga05-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728155AbgKLOwo (ORCPT ); Thu, 12 Nov 2020 09:52:44 -0500 Received: from DGGEMS404-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4CX4MN1WtwzhkLK; Thu, 12 Nov 2020 22:52:32 +0800 (CST) Received: from localhost (10.174.176.180) by DGGEMS404-HUB.china.huawei.com (10.3.19.204) with Microsoft SMTP Server id 14.3.487.0; Thu, 12 Nov 2020 22:52:33 +0800 From: YueHaibing To: , CC: , , YueHaibing Subject: [PATCH] loop: Fix passing zero to 'PTR_ERR' warning Date: Thu, 12 Nov 2020 22:52:33 +0800 Message-ID: <20201112145233.53060-1-yuehaibing@huawei.com> X-Mailer: git-send-email 2.10.2.windows.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.174.176.180] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix smatch warning: drivers/block/loop.c:799 loop_attr_backing_file_show() warn: passing zero to 'PTR_ERR' file_path() never returns 0, so use IS_ERR instead of IS_ERR_OR_NULL to fix this. Signed-off-by: YueHaibing --- drivers/block/loop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/block/loop.c b/drivers/block/loop.c index 83701c2ae3ca..65d392307c6a 100644 --- a/drivers/block/loop.c +++ b/drivers/block/loop.c @@ -795,7 +795,7 @@ static ssize_t loop_attr_backing_file_show(struct loop_device *lo, char *buf) p = file_path(lo->lo_backing_file, buf, PAGE_SIZE - 1); spin_unlock_irq(&lo->lo_lock); - if (IS_ERR_OR_NULL(p)) + if (IS_ERR(p)) ret = PTR_ERR(p); else { ret = strlen(p); -- 2.17.1