Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp411120pxb; Thu, 12 Nov 2020 06:56:52 -0800 (PST) X-Google-Smtp-Source: ABdhPJwNP7/ECeR1z+Ny66Rkp7f7URUtTHG70Yiej0V8ib9EV4+1SUBkJ0O0/LcppelC2QguHy7S X-Received: by 2002:a17:907:c05:: with SMTP id ga5mr25267940ejc.212.1605193012472; Thu, 12 Nov 2020 06:56:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605193012; cv=none; d=google.com; s=arc-20160816; b=EaS3toqAbmudqJWNZqxoeKZXOUdhPcSD1W3gl0FBixDgvPJIqQwPP5sqfzpP6dyCjG BNoHtlBLdVeB+MfMBb+H7i9FQpeutddVkMwyvNANTzzNOw/Om/sLv3OSvxfQdMNS40iw g/2zAyJBZrGwDXr38bgrrh34bQd25fCOTJOyD/Q4Kjr7o86WtRQw9sYMwg/06wK3UylR RHR4Nt544yrdYy/R1nkmMjpQcWIGaJiA4xSPjOEKY1Vi1QFjqGcqRXdHmK7TrlXHkItV 5Y6nSXbb2ZiJ6fRFU0IHtvhwANUIcxdK/J0/yAA4+j6FD4IEdfDr+99FG2iJWaE50xNu A91g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:subject:cc:to:from; bh=oSLh1sDLLiNbPOTKHghqfIibLYlZrs74RharUL/urRo=; b=ajjQMoo2xMpym5pMDWvtxSrt7HUjkOTIL28wv4sc9+OrkfL12DOK1geVFU02U499Wp jhEeX84+mPE9THJ1oAWxAVkacDDND2ArNndqAU7IO8q5R1iph9S+d6gmM0Rj/wY9clrm MxLtowzEL31YUrlayI6RHff5J1Ajrecr9CsdUfrjSFemOcdJhDRaRBjmchZqWU4mVH8P Bq+0nZrdIefGXfMYictjQRy6LZsANUezoQUfcBVVFJ1viHL+Zbx9scDOuLkVIl3SoLZH k43ifEAtTmX1iLga+4b41+FkD7DkNC44EG8bOCsBj9XIAVx45K9hnE3nUfDnYYBojZml YBeA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c1si3237200ejf.66.2020.11.12.06.56.29; Thu, 12 Nov 2020 06:56:52 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728545AbgKLOyJ (ORCPT + 99 others); Thu, 12 Nov 2020 09:54:09 -0500 Received: from szxga07-in.huawei.com ([45.249.212.35]:7891 "EHLO szxga07-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728198AbgKLOyJ (ORCPT ); Thu, 12 Nov 2020 09:54:09 -0500 Received: from DGGEMS410-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4CX4P118Mgz7658; Thu, 12 Nov 2020 22:53:57 +0800 (CST) Received: from localhost (10.174.176.180) by DGGEMS410-HUB.china.huawei.com (10.3.19.210) with Microsoft SMTP Server id 14.3.487.0; Thu, 12 Nov 2020 22:53:58 +0800 From: YueHaibing To: , CC: , , , YueHaibing Subject: [PATCH] nbd: Fix passing zero to 'PTR_ERR' warning Date: Thu, 12 Nov 2020 22:53:48 +0800 Message-ID: <20201112145348.51284-1-yuehaibing@huawei.com> X-Mailer: git-send-email 2.10.2.windows.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.174.176.180] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix smatch warning: drivers/block/nbd.c:698 nbd_read_stat() warn: passing zero to 'ERR_PTR' sock_xmit() never return 0, remove check 0 to fix this warning. Signed-off-by: YueHaibing --- drivers/block/nbd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c index aaae9220f3a0..1620d1217581 100644 --- a/drivers/block/nbd.c +++ b/drivers/block/nbd.c @@ -691,7 +691,7 @@ static struct nbd_cmd *nbd_read_stat(struct nbd_device *nbd, int index) reply.magic = 0; iov_iter_kvec(&to, READ, &iov, 1, sizeof(reply)); result = sock_xmit(nbd, index, 0, &to, MSG_WAITALL, NULL); - if (result <= 0) { + if (result < 0) { if (!nbd_disconnected(config)) dev_err(disk_to_dev(nbd->disk), "Receive control failed (result %d)\n", result); -- 2.17.1