Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp434459pxb; Thu, 12 Nov 2020 07:24:24 -0800 (PST) X-Google-Smtp-Source: ABdhPJyf2th9CFgyK+6Bu8vsSrAI2M9h75oZw3nqQIR9n0yJat8P4B3EA3G8GCHbBd2wuZKDHhyE X-Received: by 2002:a50:e087:: with SMTP id f7mr279844edl.96.1605194663793; Thu, 12 Nov 2020 07:24:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605194663; cv=none; d=google.com; s=arc-20160816; b=nbke/RqBWnRy2GG9NfBj+jVkZpQ88/U2JRhuTiO8StCuuJeBaeSSoPupJEssC0R5YM RDh+ziT6dd1/8LQyGm9s1J+ZJ7ZLQSeHjpBcIeYABpaT1hBMR/KdtJhGgy6ntoZvpxv4 Zg9Hv6u3jqxl6t78IPHUlKvrm3szbh9ttwBjHqdYs/joUTXowanDp3Ih+AMfbtjCn2D6 tIUa4U3hu5XQZgMD0EgyPenlMtU06FexW46CAny9WG6VkLz4OZf6y3uS49NzA5q2rLlN n5fXi/AxeHsfy2FCo3Y/4MVOWasBWbYAyaALHKUInG8NQjqnu39YuWUx7qsazxlbFDBb efaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=lDRYcXH2Tlj+IsIFX0IkGhrvzNzP1X0UM9xeo7JwYWg=; b=ohWJ4XH4+dJzghQ3tEBhVaJpqAnTZT489XFbe0X3KlcD0pu/eKTF5QgXVQfGa8tiyf a4O9+xHUiF5m2fQAjZYglgSHE0+r6OpJNS4sgisRRE0ZQXZOL5/8KOxFCYP4zANMgzir wm3e0KKPdNny3FkANPk3sgh/VUxuFOQn++RiODq6SAe1UV5+uhGpHtpaFjLhlTQFqloz 8I/qcznlsPBr3SnrfxspdTayNbDzsw6Jm8Bojs0a8bCrH1bO8+ro3dQu4SDahmakcgyr Qv/XnPW98QwoHmO74N2ezNgg9cCNdWDUqolvqviy18AYdG9YawWZktFJkafUKwRzrO8I HrbQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cmpxchg-org.20150623.gappssmtp.com header.s=20150623 header.b=qp58B68O; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=cmpxchg.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s16si4118886edt.488.2020.11.12.07.24.00; Thu, 12 Nov 2020 07:24:23 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@cmpxchg-org.20150623.gappssmtp.com header.s=20150623 header.b=qp58B68O; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=cmpxchg.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728620AbgKLPUV (ORCPT + 99 others); Thu, 12 Nov 2020 10:20:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38728 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727035AbgKLPUV (ORCPT ); Thu, 12 Nov 2020 10:20:21 -0500 Received: from mail-qv1-xf42.google.com (mail-qv1-xf42.google.com [IPv6:2607:f8b0:4864:20::f42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D4568C0613D1 for ; Thu, 12 Nov 2020 07:20:20 -0800 (PST) Received: by mail-qv1-xf42.google.com with SMTP id y11so2888018qvu.10 for ; Thu, 12 Nov 2020 07:20:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=lDRYcXH2Tlj+IsIFX0IkGhrvzNzP1X0UM9xeo7JwYWg=; b=qp58B68OPcq6WzCKL4Pxf4Cr2rWBYMhIbERa2fIh0ekx+BVEyeZ1gfxwljBJfv+0i+ FDpnQacMYMr6b8ydDk8N6u74cXlmI0bIANHfXGNa8s+7AAkL/IdR1kwaEQWwUMOCz1Wf fVKQFvFLdo+9bJraJJ5FXNKnSdpATqUvDGKoWj6WX1s8f2OlOUd6XEhUxTPdKhbxYwn0 Lhag4BnDc6o0IH25tzvxoqMZIBJ1sILoIw/c02tF+vwlIoAAvuXg0H2csYQyn5WOyf6O X7RRl/uK9LOCITHE0XPrpTfyrBonx23oEpvCJGqBsP+EanQVT55ivxKYFLsCcBRCBx2N GS9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=lDRYcXH2Tlj+IsIFX0IkGhrvzNzP1X0UM9xeo7JwYWg=; b=oS643Sozo/G/X75bNY/S0J6msn7FoJaSmZHOQ/bpPF3WmULnX1OIpOhU3GeTvVa1cP VLLM4KpNa5mf+Z4snRYz3WjvNU/z61klT5y7RP0QX2uqhzjoD8iIhquReEiZjqWGBzyA clsKsdFJEspBwvkQOIs35+7jTF/j9NJEKo2JDkN/3FUNsDhFmz4ovsi/TpaifQ/xYPcd KOb2qfxTyH4cOGCRtbKrkChCHOmEZEXCvfySAmW+/Y1hQdNFtKuS4LP9LCWXdqK+Lwmc vCW0vhKOYwpTtfuG59Y3WLgsIgzlCC1QyWfrOv/9SxFO053ihxH3WDRuQZyJzKTfF/Pa tdvw== X-Gm-Message-State: AOAM531+OU0Hpktz6zZ+lLvl8MUJKAwiNZqjwrwG3HgxTduOV7uK7u0R hpsWtbpcReLHHmwVJl9KDYe24w== X-Received: by 2002:ad4:524b:: with SMTP id s11mr223505qvq.3.1605194420152; Thu, 12 Nov 2020 07:20:20 -0800 (PST) Received: from localhost ([2620:10d:c091:480::1:7257]) by smtp.gmail.com with ESMTPSA id k31sm4693276qtd.40.2020.11.12.07.20.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Nov 2020 07:20:18 -0800 (PST) Date: Thu, 12 Nov 2020 10:18:28 -0500 From: Johannes Weiner To: Roman Gushchin Cc: Andrew Morton , linux-mm@kvack.org, Shakeel Butt , Michal Hocko , Christoph Lameter , linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: Re: [PATCH 1/2] mm: slub: call account_slab_page() after slab page initialization Message-ID: <20201112151828.GA873621@cmpxchg.org> References: <20201110195753.530157-1-guro@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201110195753.530157-1-guro@fb.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 10, 2020 at 11:57:52AM -0800, Roman Gushchin wrote: > It's convenient to have page->objects initialized before calling > into account_slab_page(). In particular, this information can be > used to pre-alloc the obj_cgroup vector. > > Let's call account_slab_page() a bit later, after the initialization > of page->objects. > > This commit doesn't bring any functional change, but is required for > further optimizations. > > Signed-off-by: Roman Gushchin Acked-by: Johannes Weiner