Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp434498pxb; Thu, 12 Nov 2020 07:24:26 -0800 (PST) X-Google-Smtp-Source: ABdhPJzqN6VXR2TLra+V0jmYl9XogticKZ6x9THztQhFyH8AKI0M9w9WsUcrq/7caA9Zp2bFJoVT X-Received: by 2002:aa7:d8c4:: with SMTP id k4mr267526eds.248.1605194666436; Thu, 12 Nov 2020 07:24:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605194666; cv=none; d=google.com; s=arc-20160816; b=Z5uKwsx/xoIxoR0O/9ymNRZNjtYMBX3MxieW6as8t71tFNSu4jDeus8F+jOUs6tgJg 3w2UE5fT1lDZXfB1xr2iVUrpGaOlwm+Jdh4JUbCnBZ8iBKke4+AfwBsLQ6fh6egYT1dC WlgFuaWOsqcAb96fUNegKt93wg41BAAy2e6JgIF/xKrHjlfv1IREZifghUqjUWZVuVfS zBKf93Hx9KhUNFIDW8Hk52w7Bq5aP2g/WAEXZ1hAtcgyQCMZM94nHe3cTXNFqWyfDO8X I20p6gPLp6gBZzVjgmuav1B/mxW4d2bmR+QdWzR+bpb+7L7zgBL6yAj3zGDpbm4NZFqg LWDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=x/Q46H/ynooBpbuB9J1VXUYfjp2QdhGYsHG24QRuNFM=; b=TP+AVFc5UW1jbJpLAReiyf5wrOXE0OBVS/2Ys8qxxrmqVh3ZjlpmleMKZ4LpHEPC0o F+MxH1tyCXRIh8suVo5CJP0mMQ1wPaKkVa1lCEWV5N7qspbNXZxwCsk8ERwvmFZ+ieQv QQTnlalFpwAiYF5FiVteo+xh46zdL4O15Mx5+JasP+D3jWwEuB9P9A9UOX8GK3wdISgk rVeF3zJGrIGAW57K0Mc4WxIspxdu1AhQdobvGenZ8vJ/YGC3+EVgAwZFaHMsqejT8K7D 39n7fPhOtfs4EkCCqQWLBNQbSvfkY5/jyPIZKtVKtWybANq/5CKLUYlq++xSUeMsld0X tjHw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t14si4212988edr.290.2020.11.12.07.24.03; Thu, 12 Nov 2020 07:24:26 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728233AbgKLPV7 (ORCPT + 99 others); Thu, 12 Nov 2020 10:21:59 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:50894 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727796AbgKLPV7 (ORCPT ); Thu, 12 Nov 2020 10:21:59 -0500 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1kdEQ3-006fss-LP; Thu, 12 Nov 2020 16:21:51 +0100 Date: Thu, 12 Nov 2020 16:21:51 +0100 From: Andrew Lunn To: Wong Vee Khee Cc: Heiner Kallweit , Russell King , "David S . Miller" , Jakub Kicinski , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Ong Boon Leong , Voon Wei Feng Subject: Re: [PATCH net-next 1/1] net: phy: Add additional logics on probing C45 PHY devices Message-ID: <20201112152151.GA1456319@lunn.ch> References: <20201112150351.12662-1-vee.khee.wong@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201112150351.12662-1-vee.khee.wong@intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 12, 2020 at 11:03:51PM +0800, Wong Vee Khee wrote: > For clause 45 PHY, introduce additional logics in get_phy_c45_ids() to > check if there is at least one valid device ID, return 0 on true, and > -ENODEV otherwise. So does this mean you have a device which uses c45 and does not have any valid IDs? What device is it? Can it be used via c22? I would like to know more about why this is needed, since it sounds like a workaround for a broken device. Andrew