Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp438704pxb;
        Thu, 12 Nov 2020 07:30:11 -0800 (PST)
X-Google-Smtp-Source: ABdhPJxU+v9eY4/lkDR4LVuk6lpWtvHZxVTOWjKqGmgcehVxELwLL9Ntr8SFMSsoDbSUwKZnzOex
X-Received: by 2002:aa7:c2d7:: with SMTP id m23mr302594edp.230.1605195011599;
        Thu, 12 Nov 2020 07:30:11 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1605195011; cv=none;
        d=google.com; s=arc-20160816;
        b=k+dF6RK0Gg7kpfqUEDCcLcfZjpJQoXV3GXMWTq94969Pj53f51+luZTA/RgW05KXGx
         nXuXka/RyJxxyLn62JHj1P6un0nL8C4yYHoca1FMbiGKmu3A56EcN5SWD04K+mHo08uX
         7emSMHd2QiO+M7Xdp3DgX8gpUXTgKqTSsG5vYUYzb3yIXJYS00rgbaIdMekPYzG8Obln
         vrNFsa2Xw9Jt2K6vV/ybqPXa7p1sTzTpRfKqOexaz+MQN9oRS6mFxbzAXvzsQN2jRf+/
         /VksygjmnClfTU4l9OT/iAAg8Rd5vVG0mOCvRljiZ7LMvd8oGmK4MY5rYmR0LRSXDWK2
         oITQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:mime-version:user-agent:references:message-id
         :in-reply-to:subject:cc:to:from:date:dkim-signature;
        bh=EiWTog9xCdEwDHlJkb5/lhNuo1+npcxuEPAo3lNzJTc=;
        b=D5edqvBg2SfF2WqG0v59BFmPg5XT7T4JT1HzqOgi8jlCi68Up4Dd0FY/tZUY/S7o9H
         UPCgmWWYJ1cnDRfZRRIZsPMNkxu8wK+q2XtLn82Wzq6ZxK0Kdh54f0l1yETWMkbxogYA
         ZRcqUrPZC+dfvPE8BlTg4FM79szsApZSj1eg8NKhupEMJu5cb3v520tjMMeLr+cENWTD
         NtztaaPx2EuctLUkYSHda6K3e2We3+q4TJ5N4NXTrVoXanaMoxMy9M3G563HDGn1oBFF
         XXaw5AYDtE7WK79suumFr+CK595IjActdJao1m41PXc9sRqOFjIiWlmknxZcCTbpxMqD
         fMww==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@kernel.org header.s=default header.b=rY0Qw6Pp;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id o22si4036193eds.598.2020.11.12.07.29.46;
        Thu, 12 Nov 2020 07:30:11 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@kernel.org header.s=default header.b=rY0Qw6Pp;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1728630AbgKLP11 (ORCPT <rfc822;xc.haze2010@gmail.com>
        + 99 others); Thu, 12 Nov 2020 10:27:27 -0500
Received: from mail.kernel.org ([198.145.29.99]:47134 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1727932AbgKLP1Z (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 12 Nov 2020 10:27:25 -0500
Received: from pobox.suse.cz (nat1.prg.suse.com [195.250.132.148])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by mail.kernel.org (Postfix) with ESMTPSA id AF97922248;
        Thu, 12 Nov 2020 15:27:23 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=default; t=1605194845;
        bh=KXMqFKActDUukVWA32+31xUPWeWnRqtfN6zbxzHPsXk=;
        h=Date:From:To:cc:Subject:In-Reply-To:References:From;
        b=rY0Qw6PpPBQzOurcEedRcmRR8Mcji6wqHIf6R3eOqZLb9fijc05dTp+YqX/l+2Exb
         vKqcw+8p5gwIawwIHA3uBjuu1IAZXjzPWWH1/d1h+VzbzWlJjVOn8ABkKrTyDelzH8
         auYNyNBogKu9PpjUX6wKpXxMOt3tbQFyqSXKOBNs=
Date:   Thu, 12 Nov 2020 16:27:11 +0100 (CET)
From:   Jiri Kosina <jikos@kernel.org>
To:     Colin King <colin.king@canonical.com>
cc:     Nehal Shah <nehal-bakulchandra.shah@amd.com>,
        Sandeep Singh <sandeep.singh@amd.com>,
        Benjamin Tissoires <benjamin.tissoires@redhat.com>,
        linux-input@vger.kernel.org, kernel-janitors@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] SFH: fix error return check for -ERESTARTSYS
In-Reply-To: <20201030143002.535531-1-colin.king@canonical.com>
Message-ID: <nycvar.YFH.7.76.2011121626590.6877@cbobk.fhfr.pm>
References: <20201030143002.535531-1-colin.king@canonical.com>
User-Agent: Alpine 2.21 (LSU 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 30 Oct 2020, Colin King wrote:

> From: Colin Ian King <colin.king@canonical.com>
> 
> Currently the check for the error return code -ERESTARTSYS is dead code
> and never executed because a previous check for ret < 0 is catching this
> and returning -ETIMEDOUT instead.  Fix this by checking for -ERESTARTSYS
> before the more generic negative error code.
> 
> Addresses-Coverity: ("Logically dead code")
> Fixes: 4b2c53d93a4b ("SFH:Transport Driver to add support of AMD Sensor Fusion Hub (SFH)")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Applied, thanks.

-- 
Jiri Kosina
SUSE Labs