Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 12 Nov 2020 11:31:19 -0500
From:   Johannes Weiner <hannes@cmpxchg.org>
To:     Roman Gushchin <guro@fb.com>
Cc:     Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org,
        Shakeel Butt <shakeelb@google.com>,
        Michal Hocko <mhocko@kernel.org>, linux-kernel@vger.kernel.org,
        David Rientjes <rientjes@google.com>, kernel-team@fb.com,
        Michal Hocko <mhocko@suse.com>
Subject: Re: [PATCH v1 1/3] mm: memcg: deprecate the non-hierarchical mode
Message-ID: <20201112163119.GC873621@cmpxchg.org>
References: <20201110220800.929549-1-guro@fb.com>
 <20201110220800.929549-2-guro@fb.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20201110220800.929549-2-guro@fb.com>
Precedence: bulk

On Tue, Nov 10, 2020 at 02:07:58PM -0800, Roman Gushchin wrote:
> The non-hierarchical cgroup v1 mode is a legacy of early days
> of the memory controller and doesn't bring any value today.
> However, it complicates the code and creates many edge cases
> all over the memory controller code.
> 
> It's a good time to deprecate it completely.
> 
> Functionally this patch enabled is by default for all cgroups
> and forbids switching it off. Nothing changes if cgroup v2 is used:
> hierarchical mode was enforced from scratch.
> 
> To protect the ABI memory.use_hierarchy interface is preserved
> with a limited functionality: reading always returns "1", writing
> of "1" passes silently, writing of any other value fails with
> -EINVAL and a warning to dmesg (on the first occasion).
> 
> Signed-off-by: Roman Gushchin <guro@fb.com>
> Acked-by: Michal Hocko <mhocko@suse.com>
> Reviewed-by: Shakeel Butt <shakeelb@google.com>
> Acked-by: David Rientjes <rientjes@google.com>

...and don't let the door hit you on the way out ;-)

Acked-by: Johannes Weiner <hannes@cmpxchg.org>