Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp494609pxb; Thu, 12 Nov 2020 08:45:10 -0800 (PST) X-Google-Smtp-Source: ABdhPJzbgphWSPt1kmP7RKrall15sMD57b18dmL88S1jM3xjXxkn7OYTsDJHMb0kuGiEa0FI1er4 X-Received: by 2002:a05:6402:1701:: with SMTP id y1mr652038edu.209.1605199510153; Thu, 12 Nov 2020 08:45:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605199510; cv=none; d=google.com; s=arc-20160816; b=hZrLGSFa+fmLO8zg+WxJ46oLzY5LITy/InVDiyltAWpml3l4ZR+lJ5CL1zy1p8di+d VaeC+GUabMr5ZRDiDAky9DfbJoYAheq9TgG6TVSS6GMDkH221hPvUcapZVZ7SwZzEdG2 9RROIUMOIrrx4BereOibeJHUcPbM19FEueshRi4HcYm5kiUEa+kVrQm0uFXEkBG6GEu/ 5cRWm6jD+2j32isH57mXYxRynzmIT7I4gs0ZOJzRD3QSIFkEBmp/Ctxh0RMt8ACvSFk/ Y+kcYdhlDP1ZHMsSMdGR2WrXtk2whci6gv35mou5kt2BcU3LCO0d5abDDyGtSM/BmIYY RPvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=yPvHPm93Zw/UrDr1lNEFjt3ew60EAe+oMWZhTYd6yn8=; b=WklwKOelKM9jcUkIYtOQ3i3fnWD59vSeNjhdNPMDq5NeiuzzauytLZe6aS2OZK40+B QgYVd2yWFxj6qLIqphzxY0xVI0YXf+FV8ynW7cQgvVSRSqJfpFjrpk9DazOWbFVDx5/y Gj6XdIq63ozvgGp8ZOTXiviiOCbbklEnpFtkxhS283PrWsy3xBXkq463ZQa3BFOxfupQ Sei85AcjcjHVh6JtHspKwHyFpiaxqTv7F8G0EWDzckvmlKiI2VPhBQAyWAiyCGTF9cKe mwGenQsrVmRN0HdPhr62r8FZxK52iiIptU+a87RGiDot/5BP0+exW6yAsnhBP6ImsHgP b8mA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s16si4286708edt.488.2020.11.12.08.44.46; Thu, 12 Nov 2020 08:45:10 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729061AbgKLQnS (ORCPT + 99 others); Thu, 12 Nov 2020 11:43:18 -0500 Received: from mx2.suse.de ([195.135.220.15]:46660 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727739AbgKLQnR (ORCPT ); Thu, 12 Nov 2020 11:43:17 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id B625EAFCB; Thu, 12 Nov 2020 16:43:15 +0000 (UTC) From: Nicolas Saenz Julienne To: u.kleine-koenig@pengutronix.de, linux-kernel@vger.kernel.org Cc: f.fainelli@gmail.com, linux-pwm@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, wahrenst@gmx.net, linux-input@vger.kernel.org, dmitry.torokhov@gmail.com, gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, p.zabel@pengutronix.de, linux-gpio@vger.kernel.org, linus.walleij@linaro.org, linux-clk@vger.kernel.org, sboyd@kernel.org, linux-rpi-kernel@lists.infradead.org, bgolaszewski@baylibre.com, andy.shevchenko@gmail.com, Nicolas Saenz Julienne Subject: [PATCH v4 06/11] soc: bcm: raspberrypi-power: Release firmware handle on unbind Date: Thu, 12 Nov 2020 17:36:24 +0100 Message-Id: <20201112163630.17177-7-nsaenzjulienne@suse.de> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201112163630.17177-1-nsaenzjulienne@suse.de> References: <20201112163630.17177-1-nsaenzjulienne@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use devm_rpi_firmware_get() so as to make sure we release RPi's firmware interface when unbinding the device. Signed-off-by: Nicolas Saenz Julienne --- Changes since v2: - Use devm_rpi_firmware_get(), instead of remove function drivers/soc/bcm/raspberrypi-power.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/soc/bcm/raspberrypi-power.c b/drivers/soc/bcm/raspberrypi-power.c index 5d1aacdd84ef..068715d6e66d 100644 --- a/drivers/soc/bcm/raspberrypi-power.c +++ b/drivers/soc/bcm/raspberrypi-power.c @@ -177,7 +177,7 @@ static int rpi_power_probe(struct platform_device *pdev) return -ENODEV; } - rpi_domains->fw = rpi_firmware_get(fw_np); + rpi_domains->fw = devm_rpi_firmware_get(&pdev->dev, fw_np); of_node_put(fw_np); if (!rpi_domains->fw) return -EPROBE_DEFER; -- 2.29.2