Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp513937pxb; Thu, 12 Nov 2020 09:11:31 -0800 (PST) X-Google-Smtp-Source: ABdhPJzTqmgKAMWOPcT1X20W1mmWwx/MSclbdgtbjNIjMrLmPUF6lsilVaqLOlHR/+G72fmb/c6i X-Received: by 2002:a17:906:e15:: with SMTP id l21mr214107eji.509.1605201091346; Thu, 12 Nov 2020 09:11:31 -0800 (PST) Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 18si4023787ejv.717.2020.11.12.09.11.06; Thu, 12 Nov 2020 09:11:31 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=bPlRU19d; arc=fail (signature failed); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726056AbgKLRHA (ORCPT + 99 others); Thu, 12 Nov 2020 12:07:00 -0500 Received: from nat-hk.nvidia.com ([203.18.50.4]:60403 "EHLO nat-hk.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725999AbgKLRHA (ORCPT ); Thu, 12 Nov 2020 12:07:00 -0500 Received: from HKMAIL103.nvidia.com (Not Verified[10.18.92.100]) by nat-hk.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Fri, 13 Nov 2020 01:06:58 +0800 Received: from HKMAIL101.nvidia.com (10.18.16.10) by HKMAIL103.nvidia.com (10.18.16.12) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 12 Nov 2020 17:06:54 +0000 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.105) by HKMAIL101.nvidia.com (10.18.16.10) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Thu, 12 Nov 2020 17:06:54 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YpsZu3418zlw9JBC1pID0s3eUtLVHnCuObfvnoK0qNLJtbarX6K5kTjp1bXLn8EmFNnUPJy4kuvkEXyR1r05s+uPfIfjouRlabXH0zf/98OVhQy93RFqkgBIClZ209OaFKm/ZJm1RifUszRUJ1bScWBboZwkoNx/h7jmrJMhq59c0hUK+9xdiSmRt++6hJKJuxfV2DPBI2qlv6KB7S2uFXSkLxj9y1IU/7tfojDass4g3z5w5ElNGvr2A6xs3hPzomLotUd3URSdJlgbmr85aYQ5iG4MU1k1yOxyLA6drM0MLgW9JWDbqpUl8zyVELSi1eBFmhiXUK2iNPstf4osLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5z7dMl7KkvuVL88iW/SxI6CsAU8go0L4m0fbFgGNIjo=; b=lFxl45eSzDSdrGzenFeR6jnmRqHB4Z5fGdlBF9wb1+yzrC3CRFbtur1vH8BJcrqoMijNdm2DMPLfw6MedQWxQkidxvBMiGJNLJMjIyyIMPuhpgN9IktoJsBp96h+zXKf6SbFgg25b1dwxdcTPWVX45ofd9iNne9SweQ6R0kjJX+/ZNeFUxUjlHAx847zpL1EJ2DZqlC9w+L7BlhRp5yHJTaqVl0tvGD+Zq9ePN0oC5tSk6EC05nXyTCb2d/1UZm+6+sfV69fiek+6Y7Q+pN6XNdFIEMVy4KBlbXexIKgX1fM/5PeyJfLuNnhNtDLCAGK+zZ6vPzvqHX77eXGB3ro8Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none Received: from DM6PR12MB3834.namprd12.prod.outlook.com (2603:10b6:5:14a::12) by DM6PR12MB4483.namprd12.prod.outlook.com (2603:10b6:5:2a2::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3541.21; Thu, 12 Nov 2020 17:06:52 +0000 Received: from DM6PR12MB3834.namprd12.prod.outlook.com ([fe80::cdbe:f274:ad65:9a78]) by DM6PR12MB3834.namprd12.prod.outlook.com ([fe80::cdbe:f274:ad65:9a78%7]) with mapi id 15.20.3499.032; Thu, 12 Nov 2020 17:06:52 +0000 Date: Thu, 12 Nov 2020 13:06:50 -0400 From: Jason Gunthorpe To: Qinglang Miao CC: Adit Ranadive , VMware PV-Drivers , Doug Ledford , , Subject: Re: [PATCH] RDMA/pvrdma: fix missing kfree in pvrdma_register_device Message-ID: <20201112170650.GA937057@nvidia.com> References: <20201111032202.17925-1-miaoqinglang@huawei.com> Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20201111032202.17925-1-miaoqinglang@huawei.com> X-ClientProxiedBy: BL1PR13CA0129.namprd13.prod.outlook.com (2603:10b6:208:2bb::14) To DM6PR12MB3834.namprd12.prod.outlook.com (2603:10b6:5:14a::12) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from mlx.ziepe.ca (156.34.48.30) by BL1PR13CA0129.namprd13.prod.outlook.com (2603:10b6:208:2bb::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3564.13 via Frontend Transport; Thu, 12 Nov 2020 17:06:51 +0000 Received: from jgg by mlx with local (Exim 4.94) (envelope-from ) id 1kdG3e-003vme-Eg; Thu, 12 Nov 2020 13:06:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1605200818; bh=5z7dMl7KkvuVL88iW/SxI6CsAU8go0L4m0fbFgGNIjo=; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Date: From:To:CC:Subject:Message-ID:References:Content-Type: Content-Disposition:In-Reply-To:X-ClientProxiedBy:MIME-Version: X-MS-Exchange-MessageSentRepresentingType; b=bPlRU19dwddTvR2WZMkVFVM0IbnOWN2EzRyrzTC8QsKyvaMEUZU6tzqeiTizXNdKP 8epmURAtFsjEZJMGNv1ZxYVA8rJhWKLeaT0f/Ry8eyNTiISikdEceoNKOviN95oj8Z HcXfzOhgLCHw71knCE4NnzDtBCvC9wWH5MSbz4FqIrOKeJb2dXIoVlU2h4AAARPf1W KrYlIwXdPCiah6KCRGKao/tV9NLAN/DYlD5NwdkDhwlkFWzKtrE+jEhcjGz1m64b5d e1b3ZdPXqcYjxCYEFfw10YdTs0Nupb6NDEdfk1pMdnWyzK15cMzgTm9J1XAmdR2FlL TrMJ1cOfaMEuw== Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 11, 2020 at 11:22:02AM +0800, Qinglang Miao wrote: > Fix missing kfree in pvrdma_register_device() when fails > to do ib_device_set_netdev. > > Fixes: 4b38da75e089 ("RDMA/drivers: Convert easy drivers to use ib_device_set_netdev()") > Reported-by: Hulk Robot > Signed-off-by: Qinglang Miao > --- > drivers/infiniband/hw/vmw_pvrdma/pvrdma_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied to for-rc with the 'goto err_srq_free' from Adit Thanks, Jason