Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 12 Nov 2020 11:01:33 -0700
From:   Nathan Chancellor <natechancellor@gmail.com>
To:     Nick Desaulniers <ndesaulniers@google.com>
Cc:     Russell King <linux@armlinux.org.uk>,
        clang-built-linux@googlegroups.com,
        Dmitry Safonov <0x7f454c46@gmail.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: unwind: remove old check for GCC <= 4.2
Message-ID: <20201112180133.GB934688@ubuntu-m3-large-x86>
References: <20201111025120.1694158-1-ndesaulniers@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20201111025120.1694158-1-ndesaulniers@google.com>
Precedence: bulk

On Tue, Nov 10, 2020 at 06:51:20PM -0800, 'Nick Desaulniers' via Clang Built Linux wrote:
> Since
> commit 0bddd227f3dc ("Documentation: update for gcc 4.9 requirement")
> the minimum supported version of GCC is gcc-4.9. It's now safe to remove
> this code.
> 
> Link: https://github.com/ClangBuiltLinux/linux/issues/427
> Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>

Reviewed-by: Nathan Chancellor <natechancellor@gmail.com>

> ---
>  arch/arm/kernel/unwind.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/arch/arm/kernel/unwind.c b/arch/arm/kernel/unwind.c
> index f35eb584a18a..59fdf257bf8b 100644
> --- a/arch/arm/kernel/unwind.c
> +++ b/arch/arm/kernel/unwind.c
> @@ -18,9 +18,6 @@
>  #warning Your compiler does not have EABI support.
>  #warning    ARM unwind is known to compile only with EABI compilers.
>  #warning    Change compiler or disable ARM_UNWIND option.
> -#elif (__GNUC__ == 4 && __GNUC_MINOR__ <= 2) && !defined(__clang__)
> -#warning Your compiler is too buggy; it is known to not compile ARM unwind support.
> -#warning    Change compiler or disable ARM_UNWIND option.
>  #endif
>  #endif /* __CHECKER__ */
>  
> -- 
> 2.29.2.222.g5d2a92d10f8-goog
>