Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp604240pxb; Thu, 12 Nov 2020 11:27:46 -0800 (PST) X-Google-Smtp-Source: ABdhPJzCyRNI1wfRa0t/BKCmYhMrinlvJWNKdVEzALAElmNv/xxYVT4Q5KpFzk8VvoHVTyfpx1Pg X-Received: by 2002:aa7:ca44:: with SMTP id j4mr1568450edt.354.1605209266387; Thu, 12 Nov 2020 11:27:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605209266; cv=none; d=google.com; s=arc-20160816; b=oLYbpCR0Bq+qf49nUXECl85OxxtSfXZj0KZiPZq+mOr7Bnv4rXFSy7EJXETzWDuAAy vYg22W0NGCOTdxszqSYPn6yd9yOxX4W+92a6vMFlpYDHhcN/2x1uMTqLE1VQn6tD5sy9 oj+Hg8uzePTI/GW7ofMFbo6WBNfJPZAK37Gy9zgn44hB2/sS+f6nfydNVk6ZflCJKuUW 6C8s3rNg3yJtab3H07HNnq8TVVfPMFZ7iB/rLoO+c1qAJAVQSmkyofO5jXwk70LFUzrZ KVFzjShn/r4mKm+IHFP1JFD7rl6j7WMm6fu+JlVRd1YSzTyTs8DexG9VsizzUnMWFJvJ FxcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=iPa7ZBUaGaARRKR7L27jSDdemFE2B2dwONdHOPBXVR4=; b=fvVKXaRFILTSJ56T8UA4CKqTvtAsPsns+Cq4YZr+ydHmxVm6854gavPL9JjLDGVsG5 FawkZFfbMfzJJvFKxtlmTGTMM8d9UQXOFWjC32HZwvoQnGVx9giqmxHR3m9hUssDli71 jrPW7n4ytDH5SiMiE2m/JxfP+8kKLOvMcp6Q/iachq/Z/bly/dEtM787n6zKcafraiBY fLkFvFJgluCPu8YeJJuT5YUfTI/IVJpKyazhHyAiJMLYXdEyNwwIznyKAzkBvJboORy5 Qrzg2MOI+h5G9LJNQq5YdTboiC2sSfblq/tH/Plnq3pUbN76eRxBFkG36Wiru9a24g+w qvhQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id hr40si4077634ejc.353.2020.11.12.11.27.23; Thu, 12 Nov 2020 11:27:46 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726629AbgKLTXD (ORCPT + 99 others); Thu, 12 Nov 2020 14:23:03 -0500 Received: from netrider.rowland.org ([192.131.102.5]:33539 "HELO netrider.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1726697AbgKLTXD (ORCPT ); Thu, 12 Nov 2020 14:23:03 -0500 Received: (qmail 287939 invoked by uid 1000); 12 Nov 2020 14:23:02 -0500 Date: Thu, 12 Nov 2020 14:23:02 -0500 From: Alan Stern To: John Boero Cc: Greg Kroah-Hartman , Felipe Balbi , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] usb: core: Null deref in kernel with USB webcams. Message-ID: <20201112192302.GA287229@rowland.harvard.edu> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 12, 2020 at 05:13:30PM +0000, John Boero wrote: > Sorry header was generated by git email and I should have > paid closer attention to it before sending. > Long time listener, first time caller. > > Yes the patch is backwards sorry. Testing alt proposal from > stern@rowland.harvard.edu. It may be a buggy driver > but it would be nice if a buggy driver couldn't bring down > the entire usb core. lsusb hangs until reboot or reset of usb. > > It seems to behave fine on first use. Run Zoom or cheese > works fine first time. Subsequent runs, no device found > and usb is crashed with trace in dmesg. The whole point of asking you to try out that change was to see the trace in dmesg. What does it say? Alan Stern