Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp676001pxb; Thu, 12 Nov 2020 13:28:36 -0800 (PST) X-Google-Smtp-Source: ABdhPJwazzGaEYyokU9vZp7xbjWIZiRbV4+vvjjLzzbd+1GhLWMDkpmpvLiyj5UNNWgG9nVJpQk0 X-Received: by 2002:a50:fc89:: with SMTP id f9mr2080617edq.89.1605216516347; Thu, 12 Nov 2020 13:28:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605216516; cv=none; d=google.com; s=arc-20160816; b=ZunJhAIIojeuB7wyXc2/Tb/vU4rJM3tqiAzID9WgxQjiicxGLw7Ly0DVo3ou6pOj36 w5/hluptVJNlxCtfV4sTJz/9H72YVmUXT8jdgRFVbIlmgfJNQCw5K2mUmbMzpaRzB1lD JJiwUcy1A1XAbJhSibspq8/QGtcDeZo6PPzF8amRuaxXLJT+jFxJ/tU1fJ+0iVZDsH4d FjLF7yhMG7IKDqRSah/srOG3VfpPDl9vWIbJhP82s8iSmhFYrJAq5euaoOWAgAI2USzN FBi4RSOysv6nEUglRFmgKYhpIDjD8QYm+sR0dk3aqj9QZxOVxXibjLExnNxmvn6mvbXs d+Fw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=HziF5y2Ho33ipPGe8JAMvCvqv1ktqhXSvBiNR5cyKKo=; b=YbKakvbM/7FDIB5CJjb44jozOg7WGC7gLQwVEBVkpHE30/4KphBkln68V68IWbWMab ZBX3nkqNZAva7thwnvgUubTMyrvdjsjpUulcOs2Govy9M09vWnGq6UmJp0Ur6hnZhJG1 PRihCzazXfLGBnPTcPcOAcosu83Daa4xYONAc7NT4ZBRCtYyxBm8b85dFO/jsAbMsKoL V2SmQ7wO/gg3xURda86RNdDuXdq0kxY1EbuijnF5btQD3CLeekIWnN+NQlgADfGFlVnE ry4ZAFZcbj/Darz9aaCjViOsEXCKhe6zjP+LI+EGrl+af3z2ePTBIYMeG3TuOv8tFPd5 b8KQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=oP8LyXkz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t22si4601871ejb.186.2020.11.12.13.28.13; Thu, 12 Nov 2020 13:28:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=oP8LyXkz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727354AbgKLV0j (ORCPT + 99 others); Thu, 12 Nov 2020 16:26:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39398 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726963AbgKLV0i (ORCPT ); Thu, 12 Nov 2020 16:26:38 -0500 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C3DACC0613D1; Thu, 12 Nov 2020 13:26:37 -0800 (PST) Received: by mail-wr1-x443.google.com with SMTP id r17so7567059wrw.1; Thu, 12 Nov 2020 13:26:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=HziF5y2Ho33ipPGe8JAMvCvqv1ktqhXSvBiNR5cyKKo=; b=oP8LyXkztYBwHuxXBbqefGv8Wv5Fkb4Baq8EfEKsKe2PUk0Ltwt3L4hW18aV0JDyUL 7G67vt3f5kB4hiR3wG/Wo+dsNIc2rlySaKnYnNM8RAfrG33fcGqgZNQSYiQdS8Mq+Kxo W4Sa11T2vGBy1D8MuHB+mBgFqRennqN9Ej6m3JIVKzGmfMv51XJ65nOXlALFIynTXN8L x2PtmDcc2RQ9TQX916x77GXA9v8fBaVPdJ6MIB/ZtHYlvRcY+HtmkhI52Pm8N4PYTb94 FTuGobt/Y9fjLTtKwWosYliZTbteFvO25y4oyZBqGF3+83qXsilDEFjf353n+6WP+3UL Yuog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=HziF5y2Ho33ipPGe8JAMvCvqv1ktqhXSvBiNR5cyKKo=; b=f9JDRl6GlxygQhh2tvq81r5f9tXedb/JIlyL0EPeDj2QL9cdTTDKmAqaDWZQoKQtK7 gI8ourOBO1Za2NNkzyqGcGZs5MgjkLj89tQne9z2AK4tHFPgFsE2LIEfaWWVyD5r/vud KXVs2hynEwDuIhwsplFfxWk8PO1DXj4BS4/woEaMHAHxME3suG2L7cTXpKB40sPwhqUd WA265vMM3MAyjkGlCYNsi32DE6LSRyS0lrZ1aNn6oM8jeoxhbwQC3MLNutty405IQawi QywneCtri0V0eeT83d0HRl2ZEUeNWDwVIp+AO9ZcQsYrWa9tUf/5ZOjwAZko1hOnY97X /gqg== X-Gm-Message-State: AOAM532uyrYsUgNqgw4ojSrdXKJIJKq8bHu8DOLn3DlxkEcJGrxtQJ3d Z1rHnEGzkA0fQInGzHemtHuW6R7vbBVsTITeijo= X-Received: by 2002:adf:804e:: with SMTP id 72mr1869161wrk.114.1605216396614; Thu, 12 Nov 2020 13:26:36 -0800 (PST) MIME-Version: 1.0 References: <20201112190039.2785914-1-lee.jones@linaro.org> <20201112190039.2785914-16-lee.jones@linaro.org> In-Reply-To: <20201112190039.2785914-16-lee.jones@linaro.org> From: Alex Deucher Date: Thu, 12 Nov 2020 16:26:25 -0500 Message-ID: Subject: Re: [PATCH 15/30] drm/amd/amdgpu/amdgpu_display: Remove pointless header To: Lee Jones Cc: David Airlie , LKML , amd-gfx list , =?UTF-8?Q?Christian_K=C3=B6nig?= , "moderated list:DMA BUFFER SHARING FRAMEWORK" , Maling list - DRI developers , Alex Deucher , report to , linux-media Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 12, 2020 at 2:01 PM Lee Jones wrote: > > It seems only to repeat the function name. > > Fixes the following W=3D1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/amdgpu_display.c:450: warning: Function param= eter or member 'amdgpu_connector' not described in 'amdgpu_display_ddc_prob= e' > drivers/gpu/drm/amd/amdgpu/amdgpu_display.c:450: warning: Function param= eter or member 'use_aux' not described in 'amdgpu_display_ddc_probe' > > Cc: Alex Deucher > Cc: "Christian K=C3=B6nig" > Cc: David Airlie > Cc: Daniel Vetter > Cc: Sumit Semwal > Cc: report to > Cc: amd-gfx@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Cc: linux-media@vger.kernel.org > Cc: linaro-mm-sig@lists.linaro.org > Signed-off-by: Lee Jones Applied. Thanks! Alex > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c b/drivers/gpu/dr= m/amd/amdgpu/amdgpu_display.c > index 0b134598b3a65..f4de4b41adcfd 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c > @@ -441,10 +441,6 @@ void amdgpu_display_print_display_setup(struct drm_d= evice *dev) > drm_connector_list_iter_end(&iter); > } > > -/** > - * amdgpu_display_ddc_probe > - * > - */ > bool amdgpu_display_ddc_probe(struct amdgpu_connector *amdgpu_connector, > bool use_aux) > { > -- > 2.25.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel