Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 12 Nov 2020 22:25:54 +0100
From:   Jiri Olsa <jolsa@redhat.com>
To:     Arnaldo Carvalho de Melo <acme@kernel.org>
Cc:     Andi Kleen <ak@linux.intel.com>, Jiri Olsa <jolsa@kernel.org>,
        lkml <linux-kernel@vger.kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Ingo Molnar <mingo@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Namhyung Kim <namhyung@kernel.org>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Michael Petlan <mpetlan@redhat.com>,
        Song Liu <songliubraving@fb.com>,
        Ian Rogers <irogers@google.com>,
        Stephane Eranian <eranian@google.com>,
        Alexey Budankov <alexey.budankov@linux.intel.com>,
        Adrian Hunter <adrian.hunter@intel.com>
Subject: Re: [PATCH 24/24] perf record: Add --buildid-mmap option to enable
 mmap's build id
Message-ID: <20201112212554.GA753418@krava>
References: <20201109215415.400153-1-jolsa@kernel.org>
 <20201109215415.400153-25-jolsa@kernel.org>
 <20201111170046.GB466880@tassilo.jf.intel.com>
 <20201112115710.GE619201@krava>
 <20201112203952.GA393548@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20201112203952.GA393548@kernel.org>
Precedence: bulk

On Thu, Nov 12, 2020 at 05:39:52PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Thu, Nov 12, 2020 at 12:57:10PM +0100, Jiri Olsa escreveu:
> > On Wed, Nov 11, 2020 at 09:00:46AM -0800, Andi Kleen wrote:
> > > On Mon, Nov 09, 2020 at 10:54:15PM +0100, Jiri Olsa wrote:
> > > > Adding --buildid-mmap option to enable build id in mmap2 events.
> > > > It will only work if there's kernel support for that and it disables
> > > > build id cache (implies --no-buildid).
> 
> > > What's the point of the option? Why not enable it by default
> > > if the kernel supports it?
>  
> > > With the option most user won't get the benefit.
>  
> > > The only reason I can think of for an option would be to disable
> > > so that old tools can still process.
>  
> > yes, that was request in the rfc post, we want the new default
> > perf.data be still readable by older perf tools
> 
> We need to change perf so that when it finds some option it doesn't
> grok, it just ignores extra things in a record like MMAP2 and just warns
> the user that things are being ignored.
> 
> So that we can add new stuff by default without requiring an ever longer
> command line option, like with --all-cgroups, etc.
> 
> And provide the options to avoid using new stuff if we know that the
> perf.data file will be processed by someone with an older tool that
> can't update.

hum, can we just stop being this way compatible? ;-)

I can't see too much benefit in it, but not sure how common is
to report perf.data with older perf than it was recorded with

most of the time it will probably work anyway, just big changes
list this one will screw that

jirka