Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: ZhNaBVOnEN+OzWUQiYMOSC0XPE9znLjb0fsscKvtHNyW4HRFoK/RUGDLwkuMNtCDJhiEnsaiCD
 hgKKSFuRsjVw==
IronPort-SDR: bXhT6qBaEZfDW1oQovu5ykP34GJQAMF9D7Aesc95KCgiaoffnAH0e/cboIheMZfDlrnyQnY9IT
 Yfr2+KLuVDQg==
Date:   Thu, 12 Nov 2020 13:54:42 -0800
From:   "Raj, Ashok" <ashok.raj@intel.com>
To:     Chen Yu <yu.c.chen@intel.com>
Cc:     Borislav Petkov <bp@alien8.de>, Len Brown <len.brown@intel.com>,
        "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        Tony Luck <tony.luck@intel.com>, x86@kernel.org,
        linux-kernel@vger.kernel.org, Ashok Raj <ashok.raj@intel.com>,
        Dave Hansen <dave.hansen@intel.com>,
        Andy Lutomirski <luto@amacapital.net>
Subject: Re: [PATCH][RFC] x86/microcode/intel: check cpu stepping and
 processor flag before saving microcode
Message-ID: <20201112215442.GA40035@otc-nc-03>
References: <20201110135247.422-1-yu.c.chen@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20201110135247.422-1-yu.c.chen@intel.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Precedence: bulk

Hi ChenYu

I think you can drop the RFC tag.

I suppose you can add Cc stable as well. Boris should return next week to
take a look.


On Tue, Nov 10, 2020 at 09:52:47PM +0800, Chen Yu wrote:
> Currently scan_microcode() leverages microcode_matches() to check if the
> microcode matches the CPU by comparing the family and model. However before
> saving the microcode in scan_microcode(), the processor stepping and flag
> of the microcode signature should also be considered in order to avoid
> incompatible update and caused the failure of microcode update.
> 
> 
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=208535
> Fixes: 06b8534cb728 ("x86/microcode: Rework microcode loading")
> Suggested-by: "Raj, Ashok" <ashok.raj@intel.com>
> Cc: Borislav Petkov <bp@alien8.de>
> Cc: Len Brown <len.brown@intel.com>
> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
> Cc: "Raj, Ashok" <ashok.raj@intel.com>
> Cc: Tony Luck <tony.luck@intel.com>
> Signed-off-by: Chen Yu <yu.c.chen@intel.com>
> --

Reviewed-by: Ashok Raj <ashok.raj@intel.com>

Cheers,
Ashok