Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 12 Nov 2020 13:57:42 -0800
From:   Martin KaFai Lau <kafai@fb.com>
To:     Florent Revest <revest@chromium.org>
CC:     <bpf@vger.kernel.org>, <ast@kernel.org>, <daniel@iogearbox.net>,
        <yhs@fb.com>, <andrii@kernel.org>, <kpsingh@chromium.org>,
        <jackmanb@chromium.org>, <linux-kernel@vger.kernel.org>,
        Florent Revest <revest@google.com>
Subject: Re: [PATCH] bpf: Expose bpf_sk_storage_* to iterator programs
Message-ID: <20201112215742.mzznj7py3fmnl5ia@kafai-mbp>
References: <20201112200914.2726327-1-revest@chromium.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20201112200914.2726327-1-revest@chromium.org>
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from kafai-mbp (2620:10d:c090:400::5:b515) by MWHPR13CA0005.namprd13.prod.outlook.com (2603:10b6:300:16::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3564.21 via Frontend Transport; Thu, 12 Nov 2020 21:57:49 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: fc3298fd-ee56-4f3e-7b4f-08d88755ff99
X-MS-TrafficTypeDiagnostic: BYAPR15MB2773:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <BYAPR15MB27730F5FA6EDB74DDDE07F78D5E70@BYAPR15MB2773.namprd15.prod.outlook.com>
X-FB-Source: Internal
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: UNOHBi58c5Hdyu2TD6kualrUFDinAx/F8qSxa1b700tmL1JE/PnP+gk4xk8Th5v925uYF89aer/ow3cfCYhJ4IHftSJlUHriI/LpG3N4i6I6q3jmra+emHT+ISDZQYKudnGxMjjqXybSFyjl/cLzX6kI2BdNc7zzTFxsK3SLumX/L2bY4tTSOfCzqB4jxHRRqHeqXGGOG9nGwK3wsvzfiyfrUHkDJ1GvojTMfpZXLKYMyQX3q3mO8Aqld5mTXn0bTehcl2oL0DagSaf8R1FMst6SIF+hAVBIzMw1WqoS6JjUZQKzjUFzkMwIBDs9TRdBpTkeDRc5kN1D8RCV/F6/bJawTTNyScely4y4QN3fJyQUEJFPRTDwkdxKkNNCJ06d8b2IrE4LXuvEV0CyItE2WA==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BY5PR15MB3571.namprd15.prod.outlook.com;PTR:;CAT:NONE;SFS:(376002)(346002)(396003)(39860400002)(366004)(136003)(66476007)(5660300002)(66556008)(16526019)(52116002)(33716001)(316002)(186003)(966005)(8676002)(55016002)(6496006)(66946007)(2906002)(6916009)(478600001)(6666004)(83380400001)(86362001)(4326008)(9686003)(8936002)(1076003);DIR:OUT;SFP:1102;
X-MS-Exchange-AntiSpam-MessageData: IIkYqmZWiVL3DvVCQa54sdHRtCTQjTuL5YHvC4/hTgiAgAxmGqKaFuNMnSsWZ9qvV4vO/tH5e5dj2wyRr+V+3PacK/G4HMYVzY+ZbwowP6aZleSTiZsxLmdIYoN4lVDqboHii/gnrzrsO4gu199hQvONXkdywo4krDFz5TtJKj8v+wY1vtD0SAV/47skUitIdkeI6baQMrblGaz1km8Hcnbd1vlhjQ0E3DyPo6ahqA4Z0rKe9tneN3QoOEfrvfzAqi3W5YtOHDC3AyMd/k142MpoBytOrMGfQbp8TA7Q00oy+vRQkalOWaPfKtT6rA0mqzArZ/Whj6f5ZPtFYchckbXWw1ixHkioRjxKOPLKBXz7pUIZ2dTLsV2URdCcqg8qKqrdHdJU2IlYThWAdrJccpVvdEdO6JTdfWAmxE5MKaFXTVNe9Ya+PX7ofYcNFhTTWaQQtxFkxKtXuBvEym4mKIqfqm1Z1q3dEq8SvR+Am4aZuuQjwdvjw/Iistx4MzP8DRaiUM8tbzGI4ZYHCKU+fgWN2ZK5RQEueD7mn8aX3MIrmQa1y7bZbiny2+hB9JZByaUMWcX29gFIbSlItVsUy0DsF7gC0Tz9wNYMjX7tSG8nOOyNzi9J8kQqhPygcGopZwBwGC1lipMC6Kn/i9Qp8JXBetmh4BeQk4kQ6GVxZVfv8wV2HxFZR+EHSpcUcd+FWh3e+h9addr6kBtspNdgw6YottKM38SvQVSM2J6ghRk9VcBY8B1jOXr0sJttR2EWHp7/+jdc3dGAnYIws0t1guJ9orB0FtJw1QGSZHeyQUbJCNAbUR5UtSBetaT8yupU8Q/kcZZxi5+xNgIfi2FUJvl+Zuc3fjwoQyL2GeMecoh/f9Qt2kHViukIyF5P5g0L9urEEniORSokcfEfYhzgR1LZakK+15TeP9ysh15EQi0=
X-MS-Exchange-CrossTenant-Network-Message-Id: fc3298fd-ee56-4f3e-7b4f-08d88755ff99
X-MS-Exchange-CrossTenant-AuthSource: BY5PR15MB3571.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Nov 2020 21:57:50.7131
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: W3EMn0ky8fD2A145U60KXjlWtiYLmtPzdF3oh+2ZyOmljWO9lY4hZXFw7cAEHjmX
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR15MB2773
X-OriginatorOrg: fb.com
X-Proofpoint-UnRewURL: 0 URL was un-rewritten
MIME-Version: 1.0
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.312,18.0.737
 definitions=2020-11-12_13:2020-11-12,2020-11-12 signatures=0
X-Proofpoint-Spam-Details: rule=fb_default_notspam policy=fb_default score=0 lowpriorityscore=0
 priorityscore=1501 phishscore=0 mlxlogscore=999 malwarescore=0
 adultscore=0 clxscore=1011 bulkscore=0 impostorscore=0 suspectscore=0
 spamscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2009150000 definitions=main-2011120125
X-FB-Internal: deliver
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Nov 12, 2020 at 09:09:14PM +0100, Florent Revest wrote:
> From: Florent Revest <revest@google.com>
> 
> Iterators are currently used to expose kernel information to userspace
> over fast procfs-like files but iterators could also be used to
> initialize local storage. For example, the task_file iterator could be
> used to store associations between processes and sockets.
> 
> This exposes the socket local storage helpers to all iterators. Martin
> Kafai checked that this was safe to call these helpers from the
> sk_storage_map iterators.
> 
> Signed-off-by: Florent Revest <revest@google.com>
> ---
>  kernel/trace/bpf_trace.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/kernel/trace/bpf_trace.c b/kernel/trace/bpf_trace.c
> index e4515b0f62a8..3530120fa280 100644
> --- a/kernel/trace/bpf_trace.c
> +++ b/kernel/trace/bpf_trace.c
> @@ -17,6 +17,8 @@
>  #include <linux/error-injection.h>
>  #include <linux/btf_ids.h>
>  
> +#include <net/bpf_sk_storage.h>
> +
>  #include <uapi/linux/bpf.h>
>  #include <uapi/linux/btf.h>
>  
> @@ -1750,6 +1752,14 @@ tracing_prog_func_proto(enum bpf_func_id func_id, const struct bpf_prog *prog)
>  		       NULL;
>  	case BPF_FUNC_d_path:
>  		return &bpf_d_path_proto;
> +	case BPF_FUNC_sk_storage_get:
> +		return prog->expected_attach_type == BPF_TRACE_ITER ?
> +		       &bpf_sk_storage_get_proto :
> +		       NULL;
> +	case BPF_FUNC_sk_storage_delete:
> +		return prog->expected_attach_type == BPF_TRACE_ITER ?
> +		       &bpf_sk_storage_delete_proto :
> +		       NULL;
Test(s) is needed.  e.g. iterating a bpf_sk_storage_map and also
calling bpf_sk_storage_get/delete.

I would expect to see another test/example
showing how it works end-to-end to solve the problem you have in hand.
This patch probably belongs to a longer series.

BTW, I am also enabling bpf_sk_storage_(get|delete) for FENTRY/FEXIT/RAW_TP
but I think the conflict should be manageable.
https://patchwork.ozlabs.org/project/netdev/patch/20201112211313.2587383-1-kafai@fb.com/