Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp723438pxb;
        Thu, 12 Nov 2020 14:59:34 -0800 (PST)
X-Google-Smtp-Source: ABdhPJzLpY8Ioo6B53J5ETUpGEmZBMd9cElW/hNLWK34UGWiyd+9RhmjIhralg0AqUiXStnv2Sjo
X-Received: by 2002:aa7:cc0e:: with SMTP id q14mr2325869edt.181.1605221973830;
        Thu, 12 Nov 2020 14:59:33 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1605221973; cv=none;
        d=google.com; s=arc-20160816;
        b=tXfVXo8CEI8YorbDsCMVyZH/CZAELx+6lCqCQ1QbyOTbMOHOTIckQWOhS2ktgrdV5P
         ucJJVac2wQlxxjCCp/8heZrhe/NJFipsoPn+lXHITt0xeSA4WhZ2JI6W5qkaH+ks99Lp
         hdSHh8bvUDVV/5IoS3y6qVHewNSH8xhQz4pjggxmarvUAo78bc/D3Mqz58gRGBLXAHlc
         59EawC7G9YaIvkL8MQJibhfCgvYSdX7uasqWsGH9Ex8MeVdM89eWuNj8VYZ5KzBBHI8U
         2WPGM8u+sxTKc/f91AiW279wMKrrj8Z1PU+gnntwb3xXCGQ5iR7glaugq3u5B8Gmzzc4
         qhYg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:content-transfer-encoding:mime-version
         :references:in-reply-to:message-id:subject:cc:to:from:date
         :dkim-signature;
        bh=KbFQDnLFV8NG56Dr2S2YGSqv6aVKDVj7P1ONa7qkiDs=;
        b=NedMUB5fk8SHS+KjTGc9gRphkDSygQ6YxKTgZU7IyaXo3wEivLlPiCq12k2FIMODmf
         81GDM2S4/uMbD+Nt+DSN1k3pDP2hwbSog9hbzBAgXL2WjkrKeWf3k62P6jqlCFg7i6ju
         a76xl0Df5AL3OQO/bXCKYQHEEv1hg1xVTNLx9cvwOhpW7IC/wXyIRLayarQQlI3BVyh4
         SiTbUkWlMz0yE6EBh86MAhU1fYuxc805zWbkMhiatM/BEoRDS4FHJioCXg/v0Xlm7LL8
         /L9Ss5Ax08b9IBubEZmgpFfw/zDRdRp6wI4AGABcpPRlcMqkI8QZ7lKDQwVybewGwsB7
         +o7g==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@kernel.org header.s=default header.b=ydfDKZRo;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id r10si4219823edt.313.2020.11.12.14.59.11;
        Thu, 12 Nov 2020 14:59:33 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@kernel.org header.s=default header.b=ydfDKZRo;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726885AbgKLW5K (ORCPT <rfc822;xc.haze2010@gmail.com>
        + 99 others); Thu, 12 Nov 2020 17:57:10 -0500
Received: from mail.kernel.org ([198.145.29.99]:50692 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1726611AbgKLW5K (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 12 Nov 2020 17:57:10 -0500
Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by mail.kernel.org (Postfix) with ESMTPSA id 80B1C20872;
        Thu, 12 Nov 2020 22:56:50 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=default; t=1605221811;
        bh=qyrksHKsDkON9A2dFh/FzxMGbEbdaxKiptmd9uwhFpQ=;
        h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
        b=ydfDKZRoTdcGhT8pZExOdxMueL888zbl3NizoJH4yLQf9340UTy2ShCMV74dYist9
         sGvAYW5RMq+nyQ3d9Pzt/YdChvaHcctBj7WmE6B3KpLmNJNMQVhf9UZvrjq3jfMnJR
         +KX0QnTPyihu5GQt30d5bLOUuVCDIZIPgr59H/g0=
Date:   Thu, 12 Nov 2020 14:56:49 -0800
From:   Andrew Morton <akpm@linux-foundation.org>
To:     Vijayanand Jitta <vjitta@codeaurora.org>
Cc:     Minchan Kim <minchan@kernel.org>, linux-mm <linux-mm@kvack.org>,
        glider@google.com, Dan Williams <dan.j.williams@intel.com>,
        broonie@kernel.org, mhiramat@kernel.org,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Yogesh Lal <ylal@codeaurora.org>,
        Vinayak Menon <vinmenon@codeaurora.org>
Subject: Re: [PATCH] lib: stackdepot: Add support to configure
 STACK_HASH_SIZE
Message-Id: <20201112145649.3fcd9dc4d6d3db4bd26245bb@linux-foundation.org>
In-Reply-To: <ed4a1e75-3e3a-4950-7bb5-3d83db7bf054@codeaurora.org>
References: <1603372546-27118-1-git-send-email-vjitta@codeaurora.org>
        <CAEwNFnBvxu7+oNkcO9D70OFrxQXswcJG4OvDPyzNf7kpXfpSuw@mail.gmail.com>
        <282d7028-498d-50b3-37d4-2381571f9f9e@codeaurora.org>
        <ed4a1e75-3e3a-4950-7bb5-3d83db7bf054@codeaurora.org>
X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 12 Nov 2020 18:26:24 +0530 Vijayanand Jitta <vjitta@codeaurora.org> wrote:

> >> 1. page_owner=off, stackdepot_stack_hash=0 -> no more wasted memory
> >> when we don't use page_owner
> >> 2. page_owner=on, stackdepot_stack_hash=8M -> reasonable hash size
> >> when we use page_owner.
> >>
> >>
> > 
> > This idea looks fine to me. Andrew and others would like to hear your
> > comments as well on this before implementing.
> > 
> > Thanks,
> > Vijay
> > 
> 
> Awaiting for comments from Andrew and others.

I don't actually understand the problem.

What is it about page-owner that causes stackdepot to consume
additional memory?  As far as I can tell, sizeof(struct stack_record)
isn't affected by page-owner?