Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 12 Nov 2020 15:34:03 -0800
From:   Andrew Morton <akpm@linux-foundation.org>
To:     Yicong Yang <yangyicong@hisilicon.com>
Cc:     <viro@zeniv.linux.org.uk>, <linux-fsdevel@vger.kernel.org>,
        <akinobu.mita@gmail.com>, <linux-kernel@vger.kernel.org>,
        <linuxarm@huawei.com>, <prime.zeng@huawei.com>
Subject: Re: [RESEND PATCH] libfs: fix error cast of negative value in
 simple_attr_write()
Message-Id: <20201112153403.ea479704feb70d99dc114a10@linux-foundation.org>
In-Reply-To: <0b3954a4-1ac9-c454-a0ea-1fa1be5975b8@hisilicon.com>
References: <1605000324-7428-1-git-send-email-yangyicong@hisilicon.com>
        <20201110111842.1bc76e9def94279d4453ff67@linux-foundation.org>
        <0b3954a4-1ac9-c454-a0ea-1fa1be5975b8@hisilicon.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Wed, 11 Nov 2020 18:18:31 +0800 Yicong Yang <yangyicong@hisilicon.com> wrote:

> Hi,
> 
> Thanks for reviewing this.
> 
> 
> On 2020/11/11 3:18, Andrew Morton wrote:
> > On Tue, 10 Nov 2020 17:25:24 +0800 Yicong Yang <yangyicong@hisilicon.com> wrote:
> >
> >> The attr->set() receive a value of u64, but simple_strtoll() is used
> >> for doing the conversion. It will lead to the error cast if user inputs
> >> a negative value.
> >>
> >> Use kstrtoull() instead of simple_strtoll() to convert a string got
> >> from the user to an unsigned value. The former will return '-EINVAL' if
> >> it gets a negetive value, but the latter can't handle the situation
> >> correctly.
> >>
> >> ...
> >>
> >> --- a/fs/libfs.c
> >> +++ b/fs/libfs.c
> >> @@ -977,7 +977,9 @@ ssize_t simple_attr_write(struct file *file, const char __user *buf,
> >>  		goto out;
> >>  
> >>  	attr->set_buf[size] = '\0';
> >> -	val = simple_strtoll(attr->set_buf, NULL, 0);
> >> +	ret = kstrtoull(attr->set_buf, 0, &val);
> >> +	if (ret)
> >> +		goto out;
> >>  	ret = attr->set(attr->data, val);
> >>  	if (ret == 0)
> >>  		ret = len; /* on success, claim we got the whole input */
> > kstrtoull() takes an `unsigned long long *', but `val' is a u64.
> >
> > I think this probably works OK on all architectures (ie, no 64-bit
> > architectures are using `unsigned long' for u64).  But perhaps `val'
> > should have type `unsigned long long'?
> 
> the attr->set() takes 'val' as u64, so maybe we can stay it unchanged here
> if it works well.

Sure.  But the compiler will convert an unsigned long long into a u64
quite happily, regardless of how u64 was actually implemented.

However the compiler will not convert a `u64 *' into an `unsigned long
long *' if the underlying type of u64 happens to be `unsigned long'. 
It will warn.