Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp757351pxb; Thu, 12 Nov 2020 16:04:10 -0800 (PST) X-Google-Smtp-Source: ABdhPJzMFoK/uY43iB7Wxb6rnQtg0diK6//4PtEIvMJ/hlF0BOPVZZv6qYDPS+GlG07+GK6Y4ClR X-Received: by 2002:a17:906:1383:: with SMTP id f3mr1795612ejc.489.1605225849949; Thu, 12 Nov 2020 16:04:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605225849; cv=none; d=google.com; s=arc-20160816; b=BkUz+acbb5JEbvIbRSe/OPww+vzcmFiDBK+6hsaukilaU83wfJd02Ddo5SEccVEE6V F1pIjfGwcfnJKurR+kTvB5iLan8LGODmc2jG01z6I/R9qHX+N6JSno8thAjYOJu0DHw9 3c9ep5G7a3MewLYUcsXVI6ByqC1mRtgTZwwz+gtTa5hQZ/15Rf5cA+2uyB9bIeCBqaK1 OdVju86eK4yMyaaspDOdCRqeQd7RetgvSWZOBV96Vvr3PEhEte7wwj0z3enaXr99RXmp FfXhdv9PwJucTldCx4mt47KPd25FBz0vlLLtwdBqIAIVXHcE0ojvCgAiZ+T1ZqxfzfXt wB+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:date:cc:to:from:subject :message-id:dkim-signature; bh=2fG0bgIkc6xzGiA7DSPHw1GSMhCLb6WBbk3ensaoufw=; b=qznDTVnQGih1DQz4ofQinqF497iKyTfMR+yYILpe8+iu2y5BrTMCp+BkxRtgSDbf8W DN8OwN61rsDCqpHrNYoDsnGC0RM4a77MADACCttiJWC3Y18slb/7C3iF6ytQsCWXF4Lo jULngXi0PjAjz0a/EF0CuR3X22OEbEwKFrilzVd11eijzHm/AGtF4lSdDRhFFujtaQ6v C0+VvoNYFGepM2gmibPU+A43mtvnDUjEens9Jx1wKKpGf5X52Ujqz2Zwaq1nC8EHw2jG S2FCELu5fLPUb9jexL3zl5+MzWnI1W6MWj6qm4xwOO+Puqyo/pTDiYULHFbQPuM2MXaH UTJA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=S4FV+tZp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id hr12si4316855ejc.562.2020.11.12.16.03.47; Thu, 12 Nov 2020 16:04:09 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=S4FV+tZp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726253AbgKLX6N (ORCPT + 99 others); Thu, 12 Nov 2020 18:58:13 -0500 Received: from mail.kernel.org ([198.145.29.99]:36948 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726017AbgKLX6M (ORCPT ); Thu, 12 Nov 2020 18:58:12 -0500 Received: from lt-jalone-7480.mtl.com (c-24-6-56-119.hsd1.ca.comcast.net [24.6.56.119]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B9D4C20723; Thu, 12 Nov 2020 23:58:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1605225492; bh=D7BWy4zT3PbHd0AJ1nIJLQwiLiRhReaFI7Ef1rnHFDs=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=S4FV+tZpTU+OfMLs2eYEKR/CDcjXZHX5syjhq2Y0dg4O6sRfU0+rSRJ9V1wkm+ZH/ mWp0vPD6Cl+vZen2NfpjleqxROKHz9dRNanmiLu2VcYdvdeRCowDxEXrF0kC5n5veA ASJDWZSBPF3ztBAaCeFYVeT7zJFondbYRcZJkU4I= Message-ID: <06f889297f97217961e4e563d2715f28d1e8d953.camel@kernel.org> Subject: Re: [PATCH net-next] net/mlx5: Fix passing zero to 'PTR_ERR' From: Saeed Mahameed To: YueHaibing , leon@kernel.org, davem@davemloft.net, kuba@kernel.org, vuhuong@mellanox.com Cc: netdev@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Date: Thu, 12 Nov 2020 15:58:10 -0800 In-Reply-To: <20201112142845.54580-1-yuehaibing@huawei.com> References: <20201112142845.54580-1-yuehaibing@huawei.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.5 (3.36.5-1.fc32) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2020-11-12 at 22:28 +0800, YueHaibing wrote: > Fix smatch warnings: > > drivers/net/ethernet/mellanox/mlx5/core/esw/acl/egress_lgcy.c:105 > esw_acl_egress_lgcy_setup() warn: passing zero to 'PTR_ERR' > drivers/net/ethernet/mellanox/mlx5/core/esw/acl/egress_ofld.c:177 > esw_acl_egress_ofld_setup() warn: passing zero to 'PTR_ERR' > drivers/net/ethernet/mellanox/mlx5/core/esw/acl/ingress_lgcy.c:184 > esw_acl_ingress_lgcy_setup() warn: passing zero to 'PTR_ERR' > drivers/net/ethernet/mellanox/mlx5/core/esw/acl/ingress_ofld.c:262 > esw_acl_ingress_ofld_setup() warn: passing zero to 'PTR_ERR' > > esw_acl_table_create() never returns NULL, so > NULL test should be removed. > > Signed-off-by: YueHaibing > Applied to net-next-mlx5 thanks