Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 12 Nov 2020 17:46:22 -0800
From:   Roman Gushchin <guro@fb.com>
To:     Andrew Morton <akpm@linux-foundation.org>
CC:     Johannes Weiner <hannes@cmpxchg.org>, <linux-mm@kvack.org>,
        Shakeel Butt <shakeelb@google.com>,
        Michal Hocko <mhocko@kernel.org>,
        Christoph Lameter <cl@linux.com>,
        <linux-kernel@vger.kernel.org>, <kernel-team@fb.com>
Subject: Re: [PATCH 2/2] mm: memcg/slab: pre-allocate obj_cgroups for slab
 caches with SLAB_ACCOUNT
Message-ID: <20201113014622.GA2942851@carbon.DHCP.thefacebook.com>
References: <20201110195753.530157-1-guro@fb.com>
 <20201110195753.530157-2-guro@fb.com>
 <20201112162303.GB873621@cmpxchg.org>
 <20201113001926.GA2934489@carbon.dhcp.thefacebook.com>
 <20201112171239.4f8ef107f741c3462556731f@linux-foundation.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20201112171239.4f8ef107f741c3462556731f@linux-foundation.org>
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from carbon.DHCP.thefacebook.com (2620:10d:c090:400::5:b498) by MW4PR03CA0085.namprd03.prod.outlook.com (2603:10b6:303:b6::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3541.21 via Frontend Transport; Fri, 13 Nov 2020 01:46:26 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: ae0a2209-3b28-449e-b81f-08d88775ef78
X-MS-TrafficTypeDiagnostic: BYAPR15MB3397:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <BYAPR15MB33975474D8A7897785E09732BEE60@BYAPR15MB3397.namprd15.prod.outlook.com>
X-FB-Source: Internal
X-MS-Oob-TLC-OOBClassifiers: OLM:9508;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: xe+KeQARKsEsS2Ceki+j2fPo3/Fzw53CQiwSfk28aO/0QSS1OtK1ncu4pnQNI01FtvnQgXPiCqRoQpq/Lr8636YLICGz2c2cMx4YawZLGd1zE4/z0oYWk/5OVfMQ3OfN5NNBOBCggYqBwcFdnkN3PHgl0Igeackl/dgJKLuX95Wcfr5VD33RIhzxCo31W7IKClBs+wZnmFKHuEKSF5xekRjvqfTzPpFlJe0vtgjyL3eTKD9962g798MfqjhBqcjUtAbMl2gD1B1RZBAxt7/TiLr+EnQ+xR1AMhhp+TsiFIjEhO/9sK9owhSU+jA73ZmtwvH3eoE2ELUqN80RVw2fDw==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR15MB4136.namprd15.prod.outlook.com;PTR:;CAT:NONE;SFS:(346002)(376002)(366004)(396003)(136003)(39860400002)(16526019)(33656002)(8936002)(6506007)(53546011)(52116002)(5660300002)(6666004)(4326008)(66476007)(66556008)(6916009)(186003)(1076003)(478600001)(54906003)(316002)(83380400001)(7696005)(55016002)(86362001)(2906002)(9686003)(8676002)(66946007);DIR:OUT;SFP:1102;
X-MS-Exchange-AntiSpam-MessageData: YsRzN/aKPRbrdO6hYJvzbROhiA855RHro+v9CEId2NIJqJPQdZV/hxkahedM8MgpZKTc6LXVguJX2SKMEKycNOcIOYyxeiBEPE+P6/cBzebgypZ8KkGZThDRtReqyfgYAaVqJiEknVETwoq79e4mdq6N3F+fDP5GF3sBJWsiZhofKhLkVbwa6cas8efRNH9VyBKQqR+ysm7lFlRxuyShqASTT49lToCr1+Ry+YxKZ/dyUE5XL7XyUI8twKjhZJBvt8CMfpUBVKCGQrvaDy2+pe/FLr1Oa7fCj5/lEjddAuGgSvoycTjj4dASlezyhymd3ku4mQm82y27JrUcyuFy7cyneBbNHPPoP9FIN+mw9U7gxkXput0h44SQBRAk9Q1qj0ZHjGlkuAMoTUUXnkTQC35GIGjQJvJKA+mH/+ATRiTL74jzOBEcNkWlRB0I6Lbnp+bgXDPVD6P1Hp+Iq0jtbnno+Sjip2AG0057WLCQVJhPiUnTrmCnU5Ht0KdNRrtxyZ2l+3OgBy8VpfVkFDOQejV2Jb1BpeJkBK1fmFhio98DyaAUhRiwWMt8hpxi86tQwOVXYBPNXszGbO6Y8S2Jz+taYg0CfW3kkGvC5mbZ8FntyXIA1ApPcxF6rUiVXOGAQN93MMfr/HPf3ZjWaXx4XowOFrIOKVIvYg07ryJ/qc52zLf0AAfNPA9ThyvEX5o2
X-MS-Exchange-CrossTenant-Network-Message-Id: ae0a2209-3b28-449e-b81f-08d88775ef78
X-MS-Exchange-CrossTenant-AuthSource: BYAPR15MB4136.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Nov 2020 01:46:27.3913
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6FbXfaBqZaeMt0mbvm26JWcadmp/ZdXDOZ+vGAo0rCVNhuCo2aDrVtvZXDTgynh+
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR15MB3397
X-OriginatorOrg: fb.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.312,18.0.737
 definitions=2020-11-12_16:2020-11-12,2020-11-12 signatures=0
X-Proofpoint-Spam-Details: rule=fb_default_notspam policy=fb_default score=0 mlxlogscore=999
 priorityscore=1501 spamscore=0 phishscore=0 impostorscore=0 mlxscore=0
 adultscore=0 suspectscore=1 bulkscore=0 clxscore=1015 lowpriorityscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2009150000 definitions=main-2011130008
X-FB-Internal: deliver
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Nov 12, 2020 at 05:12:39PM -0800, Andrew Morton wrote:
> On Thu, 12 Nov 2020 16:19:26 -0800 Roman Gushchin <guro@fb.com> wrote:
> 
> > >From 8b28d91475d54c552e503e66f169e1e00475c856 Mon Sep 17 00:00:00 2001
> > From: Roman Gushchin <guro@fb.com>
> > Date: Wed, 16 Sep 2020 15:43:48 -0700
> > Subject: [PATCH v2 2/2] mm: memcg/slab: pre-allocate obj_cgroups for slab
> >  caches with SLAB_ACCOUNT
> > 
> > In general it's unknown in advance if a slab page will contain
> > accounted objects or not. In order to avoid memory waste, an
> > obj_cgroup vector is allocated dynamically when a need to account
> > of a new object arises. Such approach is memory efficient, but
> > requires an expensive cmpxchg() to set up the memcg/objcgs pointer,
> > because an allocation can race with a different allocation on another
> > cpu.
> > 
> > But in some common cases it's known for sure that a slab page will
> > contain accounted objects: if the page belongs to a slab cache with a
> > SLAB_ACCOUNT flag set. It includes such popular objects like
> > vm_area_struct, anon_vma, task_struct, etc.
> > 
> > In such cases we can pre-allocate the objcgs vector and simple assign
> > it to the page without any atomic operations, because at this early
> > stage the page is not visible to anyone else.
> > 
> > v2: inline set_page_objcgs() and add some comments, by Johannes
> 
> Had me confused!  I was looking for the inlined function
> set_page_objcgs().  I think "open-code" is a better term here than
> "inline".

Sorry for the confusion! And thanks for picking up the new version!

Roman