Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: b8NHag+Yl4fwJEbXg+kbXUw32vA/UOUiBu38x5WQ1C4llqibfSq4R2VH/eRatGLpCZqQTTPJ6O
 NqRyZ/AkpmTg==
IronPort-SDR: lhQaDtiYD5QTwHsKDflNoO4Uf8hm9c3qI0Z+yXcqoI+4Ugnxedda6XCa6nP2T0dIFtWbjDtyY+
 OR9589kNzF9A==
From:   "Sia, Jee Heng" <jee.heng.sia@intel.com>
To:     Rob Herring <robh@kernel.org>
CC:     "vkoul@kernel.org" <vkoul@kernel.org>,
        "Eugeniy.Paltsev@synopsys.com" <Eugeniy.Paltsev@synopsys.com>,
        "andriy.shevchenko@linux.intel.com" 
        <andriy.shevchenko@linux.intel.com>,
        "dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: RE: [PATCH v3 10/15] dt-binding: dma: dw-axi-dmac: Add support for
 Intel KeemBay AxiDMA
Thread-Topic: [PATCH v3 10/15] dt-binding: dma: dw-axi-dmac: Add support for
 Intel KeemBay AxiDMA
Thread-Index: AQHWuQQ2tbhfyVk2xESCGm8n37pqB6nFUm5A
Date:   Fri, 13 Nov 2020 02:12:29 +0000
Message-ID: <CO1PR11MB5026867ECF7693C7DC86571ADAE60@CO1PR11MB5026.namprd11.prod.outlook.com>
References: <20201112084953.21629-1-jee.heng.sia@intel.com>
 <20201112084953.21629-11-jee.heng.sia@intel.com>
 <20201112145800.GB3583607@bogus>
In-Reply-To: <20201112145800.GB3583607@bogus>
Accept-Language: en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-reaction: no-action
dlp-version: 11.5.1.3
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: f2da1620-1c05-4a25-b54a-08d887799312
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Nov 2020 02:12:29.9392
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: USJNr1KHoKNPB/qg3WL5iRRss5r8lCOtfs38RHiWoxi9L7iRuNDCVNu6jwGbSZ7XzFLPO1tjslGlMsgVwe3zAw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1101MB2157
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Rob Herring <robh@kernel.org>
> Sent: 12 November 2020 10:58 PM
> To: Sia, Jee Heng <jee.heng.sia@intel.com>
> Cc: vkoul@kernel.org; Eugeniy.Paltsev@synopsys.com;
> andriy.shevchenko@linux.intel.com; dmaengine@vger.kernel.org; linux-
> kernel@vger.kernel.org; devicetree@vger.kernel.org
> Subject: Re: [PATCH v3 10/15] dt-binding: dma: dw-axi-dmac: Add support f=
or
> Intel KeemBay AxiDMA
>=20
> On Thu, Nov 12, 2020 at 04:49:48PM +0800, Sia Jee Heng wrote:
> > Add support for Intel KeemBay AxiDMA to the dw-axi-dmac Schemas DT
> > binding.
> >
> > Signed-off-by: Sia Jee Heng <jee.heng.sia@intel.com>
> > ---
> >  .../bindings/dma/snps,dw-axi-dmac.yaml        | 25 +++++++++++++++++++
> >  1 file changed, 25 insertions(+)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
> > b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
> > index 481ef0dacf5f..18e9422095bb 100644
> > --- a/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
> > +++ b/Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.yaml
> > @@ -8,6 +8,7 @@ title: Synopsys DesignWare AXI DMA Controller
> >
> >  maintainers:
> >    - Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com
> > +  - Jee Heng Sia <jee.heng.sia@intel.com>
> >
> >  description: |
> >   Synopsys DesignWare AXI DMA Controller DT Binding @@ -16,6 +17,7 @@
> > properties:
> >    compatible:
> >      enum:
> >        - snps,axi-dma-1.01a
> > +      - intel,kmb-axi-dma
> >
> >    reg:
> >      items:
> > @@ -24,6 +26,7 @@ properties:
> >    reg-names:
> >      items:
> >        - const: axidma_ctrl_regs
> > +      - const: axidma_apb_regs
>=20
> You need 'minItems: 1' here or everyone has to have 2 entries.
>=20
> Also, doesn't 'reg' need updating?
>=20
> >
> >    interrupts:
> >      maxItems: 1
> > @@ -124,3 +127,25 @@ examples:
> >           snps,priority =3D <0 1 2 3>;
> >           snps,axi-max-burst-len =3D <16>;
> >       };
> > +
> > +  - |
> > +     #include <dt-bindings/interrupt-controller/arm-gic.h>
> > +     #include <dt-bindings/interrupt-controller/irq.h>
> > +     /* example with intel,kmb-axi-dma */
> > +     #define KEEM_BAY_PSS_AXI_DMA
> > +     #define KEEM_BAY_PSS_APB_AXI_DMA
> > +     axi_dma: dma@28000000 {
> > +         compatible =3D "intel,kmb-axi-dma";
> > +         reg =3D <0x28000000 0x1000 0x20250000 0x24>;
>=20
> reg =3D <0x28000000 0x1000>, <0x20250000 0x24>;
[>>] Thanks Rob for the invaluable comments. Will update the changes in v4.
>=20
> > +         reg-names =3D "axidma_ctrl_regs", "axidma_apb_regs";
> > +         interrupts =3D <GIC_SPI 88 IRQ_TYPE_LEVEL_HIGH>;
> > +         clock-names =3D "core-clk", "cfgr-clk";
> > +         clocks =3D <&scmi_clk KEEM_BAY_PSS_AXI_DMA>, <&scmi_clk
> KEEM_BAY_PSS_APB_AXI_DMA>;
> > +         #dma-cells =3D <1>;
> > +         dma-channels =3D <8>;
> > +         snps,dma-masters =3D <1>;
> > +         snps,data-width =3D <4>;
> > +         snps,priority =3D <0 0 0 0 0 0 0 0>;
> > +         snps,block-size =3D <1024 1024 1024 1024 1024 1024 1024 1024>=
;
> > +         snps,axi-max-burst-len =3D <16>;
> > +     };
> > --
> > 2.18.0
> >