Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: ozH8TAbQxLoNpOwGo5IAFDWg8BV+A+VOQcR+xgkCwLbs7eSOg8w+GOWWzrf0QNEP5ibZPwDzCx
 KA6V9rwGxWlQ==
IronPort-SDR: TSpJAJPs47O0Gv8XrS7IA0lrbbqBwWenyPm2ObzikSNe9rG3vMx+4VWG83hktEITKVAmt4tIy3
 9w8gLGiOrFpA==
From:   "Wan Mohamad, Wan Ahmad Zainie" 
        <wan.ahmad.zainie.wan.mohamad@intel.com>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
CC:     "kishon@ti.com" <kishon@ti.com>,
        "vkoul@kernel.org" <vkoul@kernel.org>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "mgross@linux.intel.com" <mgross@linux.intel.com>,
        "Raja Subramanian, Lakshmi Bai" 
        <lakshmi.bai.raja.subramanian@intel.com>
Subject: RE: [PATCH v3 2/2] phy: intel: Add Keem Bay USB PHY support
Thread-Topic: [PATCH v3 2/2] phy: intel: Add Keem Bay USB PHY support
Thread-Index: AQHWuNqoNSM8nZrIJk+7EJr9fv7yMKnEjqOAgADdxgA=
Date:   Fri, 13 Nov 2020 03:46:48 +0000
Message-ID: <BN8PR11MB37141DA30718CA4A3243489ADDE60@BN8PR11MB3714.namprd11.prod.outlook.com>
References: <20201112095821.27110-1-wan.ahmad.zainie.wan.mohamad@intel.com>
 <20201112095821.27110-3-wan.ahmad.zainie.wan.mohamad@intel.com>
 <20201112142905.GH4077@smile.fi.intel.com>
In-Reply-To: <20201112142905.GH4077@smile.fi.intel.com>
Accept-Language: en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-reaction: no-action
dlp-version: 11.5.1.3
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: c0f878ce-c016-4af9-a9ae-08d88786bfaf
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Nov 2020 03:46:48.3193
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 6XrTpvrcIWnYN9xwqwjPYE+VGsmFNw32JUMjPbG+KHUQZQcw/AxV4ub2ydPwZ5MeOhTU34fY7b4EUEVcDZ8eLdW2O4RV+jXXdH+vCIX7fauZhegCSS2m2Fxn6gRMLlnQ
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR11MB3715
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Andy.

> -----Original Message-----
> From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Sent: Thursday, November 12, 2020 10:29 PM
> To: Wan Mohamad, Wan Ahmad Zainie
> <wan.ahmad.zainie.wan.mohamad@intel.com>
> Cc: kishon@ti.com; vkoul@kernel.org; robh+dt@kernel.org; linux-
> kernel@vger.kernel.org; devicetree@vger.kernel.org;
> mgross@linux.intel.com; Raja Subramanian, Lakshmi Bai
> <lakshmi.bai.raja.subramanian@intel.com>
> Subject: Re: [PATCH v3 2/2] phy: intel: Add Keem Bay USB PHY support
>=20
> On Thu, Nov 12, 2020 at 05:58:21PM +0800, Wan Ahmad Zainie wrote:
> > Add support for USB PHY on Intel Keem Bay SoC.
>=20
> Any elaboration here? What is this PHY (USB2 or USB3 or?.. etc)?

Yes, I can elaborate this.

>=20
> ...
>=20
> > +config PHY_INTEL_KEEMBAY_USB
> > +	tristate "Intel Keem Bay USB PHY driver"
>=20
> > +	depends on ARCH_KEEMBAY || (ARM64 && COMPILE_TEST)
>=20
> It seems other drivers that are not using ARM specific calls moved to
>=20
> 	depends on ARCH_KEEMBAY || COMPILE_TEST

I will fix in v4.

>=20
> > +	depends on HAS_IOMEM
> > +	select GENERIC_PHY
> > +	select REGMAP_MMIO
>=20
> ...
>=20
> > +#define USS_CPR_MASK		0x7f
>=20
> GENMASK() ?

I will fix in v4.

>=20
> ...
>=20
> > +static const struct regmap_config keembay_regmap_config =3D {
> > +	.reg_bits =3D 32,
> > +	.val_bits =3D 32,
> > +	.reg_stride =3D 4,
>=20
> .max_register?

It is optional. But yes, I can add,
.max_register =3D USS_USB_TIEOFFS_CONSTANTS_REG1

>=20
> > +};
>=20
> --
> With Best Regards,
> Andy Shevchenko
>=20

Best regards,
Zainie