Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201112110204.2083435-1-lee.jones@linaro.org>
 <20201112110204.2083435-9-lee.jones@linaro.org> <20201113074028.GI356503@dtor-ws>
In-Reply-To: <20201113074028.GI356503@dtor-ws>
From:   Benjamin Tissoires <benjamin.tissoires@gmail.com>
Date:   Fri, 13 Nov 2020 08:42:37 +0100
Message-ID: <CAN+gG=FjNfV9D9tYgMNYbCe6kgjFc0jDnreFsqOZ=2vnOv9eGA@mail.gmail.com>
Subject: Re: [PATCH 08/15] input: touchscreen: surface3_spi: Remove set but
 unused variable 'timestamp'
To:     Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        Peter Hutterer <peter.hutterer@who-t.net>
Cc:     Lee Jones <lee.jones@linaro.org>,
        lkml <linux-kernel@vger.kernel.org>,
        Henrik Rydberg <rydberg@bitmath.org>,
        linux-input <linux-input@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, Nov 13, 2020 at 8:40 AM Dmitry Torokhov
<dmitry.torokhov@gmail.com> wrote:
>
> On Thu, Nov 12, 2020 at 11:01:57AM +0000, Lee Jones wrote:
> > Fixes the following W=3D1 kernel build warning(s):
> >
> >  drivers/input/touchscreen/surface3_spi.c: In function =E2=80=98surface=
3_spi_process_touch=E2=80=99:
> >  drivers/input/touchscreen/surface3_spi.c:97:6: warning: variable =E2=
=80=98timestamp=E2=80=99 set but not used [-Wunused-but-set-variable]
> >
> > Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> > Cc: Henrik Rydberg <rydberg@bitmath.org>
> > Cc: Benjamin Tissoires <benjamin.tissoires@gmail.com>
> > Cc: linux-input@vger.kernel.org
> > Signed-off-by: Lee Jones <lee.jones@linaro.org>
> > ---
> >  drivers/input/touchscreen/surface3_spi.c | 2 --
> >  1 file changed, 2 deletions(-)
> >
> > diff --git a/drivers/input/touchscreen/surface3_spi.c b/drivers/input/t=
ouchscreen/surface3_spi.c
> > index ce4828b1415a8..72dc4c562a4e1 100644
> > --- a/drivers/input/touchscreen/surface3_spi.c
> > +++ b/drivers/input/touchscreen/surface3_spi.c
> > @@ -94,9 +94,7 @@ static void surface3_spi_report_touch(struct surface3=
_ts_data *ts_data,
> >
> >  static void surface3_spi_process_touch(struct surface3_ts_data *ts_dat=
a, u8 *data)
> >  {
> > -     u16 timestamp;
> >       unsigned int i;
> > -     timestamp =3D get_unaligned_le16(&data[15]);
>
> Benjamin, should we pass timing data on to userspace instead?

Last time I checked, libinput was not using the HW timestamp. So I
don't mind dropping it.

Not sure if chrome/android uses it.

Cheers,
Benjamin

>
> >
> >       for (i =3D 0; i < 13; i++) {
> >               struct surface3_ts_data_finger *finger;
> > --
> > 2.25.1
> >
>
> Thanks.
>
> --
> Dmitry