Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp960405pxb; Thu, 12 Nov 2020 23:49:59 -0800 (PST) X-Google-Smtp-Source: ABdhPJzEzUnrhkEVFd5HgFVJKbajDAPfgxTof1Ljk0ASF17hN61KieBja9MzNnVXBo+sbjRIyHOJ X-Received: by 2002:a05:6402:1f1:: with SMTP id i17mr1261714edy.60.1605253799159; Thu, 12 Nov 2020 23:49:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605253799; cv=none; d=google.com; s=arc-20160816; b=v8+MUUYZjYmGQojoKqjo3z+yXiUYVzzEhmo80/v+BIe+CsyGNw+7uVL6XB4cgef301 PuqKKY5F0fDUrDQMshcn79paZKJKaHzu1SVzw/VFxdN6JbjF+TBd57IOEjKI+xhaKeba 3FcQ/mbPc9j2KqGo9ENDavn17wmeIUif0paBkgu2PF8xwMD23Zfld2PzR7df7EjSAest jE2BI4KlHVz5/W/rZ+ZKqPMC1Y/Gz0asVLhsmDwx1C3owo8hwIIlJwlrzbVqd8ipUw9Q t+GPfv8vLzxxUe7gvpe5oNEnTNkyCH/wK55dtGDMPuWGAcS53gxOIvcPm1VJMxWVuG3y 1buw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=nGAimDzEBNWysE8mhqjzkFRe88ztaqY7YxvWjaG+bRg=; b=p0aYYBwGnM5HopuD9kZM17Nz58JKKmmJzYkbOs5sjidkg/x/Gh7meVWkE1F7REWy/Q SLOycCkh3LubnK4utwNuW0CqJyaj8hg5Ff2MtQoILvPlfLYv+ukotQziVv0xWfTGxLTJ KjBGb2bfjf9UNsu0v7kjJ3mp0cyoAjSjmAIDEXIcrypyfHh/erSLVE4BvscAem6dRjSU u5iv71U2mQPsFArZWWoMHR0Z5PNX6/I5RU4t5Dz4XASENWXPMi5SEWDDk7asap+E9AVm tNPwTksTo1qSLOet8m8xM697aWiRZ4yCMcx0v2orer5mk1ckIarC3UrFbSsHYjnsZ9CL nwww== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q11si5060697ejb.550.2020.11.12.23.49.36; Thu, 12 Nov 2020 23:49:59 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726221AbgKMHqB (ORCPT + 99 others); Fri, 13 Nov 2020 02:46:01 -0500 Received: from smtp25.cstnet.cn ([159.226.251.25]:56614 "EHLO cstnet.cn" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725866AbgKMHqB (ORCPT ); Fri, 13 Nov 2020 02:46:01 -0500 Received: from localhost.localdomain (unknown [124.16.141.242]) by APP-05 (Coremail) with SMTP id zQCowAC3ypylOa5fu3bMAA--.60550S2; Fri, 13 Nov 2020 15:45:42 +0800 (CST) From: Xu Wang To: a.zummo@towertech.it, alexandre.belloni@bootlin.com, f.fainelli@gmail.com, bcm-kernel-feedback-list@broadcom.com, linux-rtc@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org Subject: [PATCH] rtc: brcmstb-waketimer: Remove redundant null check before clk_disable_unprepare Date: Fri, 13 Nov 2020 07:45:38 +0000 Message-Id: <20201113074538.65028-1-vulab@iscas.ac.cn> X-Mailer: git-send-email 2.17.1 X-CM-TRANSID: zQCowAC3ypylOa5fu3bMAA--.60550S2 X-Coremail-Antispam: 1UD129KBjvdXoWrZFy8CFy8Aw43Ary8uFyUJrb_yoW3urb_CF 1UWa1fGa1Durs2kw15Cwsxur92q3WxZr4kXFy0ga93AasFqrs8u3y8tr4SkFWkX3y5tFn8 AF1UKrySyrnI9jkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUb2kYjsxI4VWDJwAYFVCjjxCrM7AC8VAFwI0_Gr0_Xr1l1xkIjI8I 6I8E6xAIw20EY4v20xvaj40_Wr0E3s1l1IIY67AEw4v_Jr0_Jr4l8cAvFVAK0II2c7xJM2 8CjxkF64kEwVA0rcxSw2x7M28EF7xvwVC0I7IYx2IY67AKxVW5JVW7JwA2z4x0Y4vE2Ix0 cI8IcVCY1x0267AKxVW8JVWxJwA2z4x0Y4vEx4A2jsIE14v26F4UJVW0owA2z4x0Y4vEx4 A2jsIEc7CjxVAFwI0_Cr1j6rxdM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI 64kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r106r15McIj6I8E87Iv67AKxVWUJVW8Jw Am72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IYc2Ij64vIr41lc2xSY4AK67AK6r4xMxAIw28I cxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2 IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUAVWUtwCIc40Y0x0EwIxGrwCI 42IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267AKxVWUJVW8JwCI42 IY6xAIw20EY4v20xvaj40_Wr1j6rW3Jr1lIxAIcVC2z280aVAFwI0_Jr0_Gr1lIxAIcVC2 z280aVCY1x0267AKxVW8JVW8JrUvcSsGvfC2KfnxnUUI43ZEXa7IU8YhF7UUUUU== X-Originating-IP: [124.16.141.242] X-CM-SenderInfo: pyxotu46lvutnvoduhdfq/1tbiCAsTA18J9x6ybQABsy Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Because clk_disable_unprepare() already checked NULL clock parameter, so the additional check is unnecessary, just remove it. Signed-off-by: Xu Wang --- drivers/rtc/rtc-brcmstb-waketimer.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/rtc/rtc-brcmstb-waketimer.c b/drivers/rtc/rtc-brcmstb-waketimer.c index 4fee57c51280..375a9987a1d6 100644 --- a/drivers/rtc/rtc-brcmstb-waketimer.c +++ b/drivers/rtc/rtc-brcmstb-waketimer.c @@ -264,8 +264,7 @@ static int brcmstb_waketmr_probe(struct platform_device *pdev) unregister_reboot_notifier(&timer->reboot_notifier); err_clk: - if (timer->clk) - clk_disable_unprepare(timer->clk); + clk_disable_unprepare(timer->clk); return ret; } -- 2.17.1