Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp973601pxb; Fri, 13 Nov 2020 00:18:05 -0800 (PST) X-Google-Smtp-Source: ABdhPJw4KjM7dmEpZiEhzAC3uv91tV2mp4uNi/xWz7jEbSJsAsL7GcVobIAUqdpqUjhHOeTwXQqy X-Received: by 2002:a50:cf82:: with SMTP id h2mr1327006edk.142.1605255485219; Fri, 13 Nov 2020 00:18:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605255485; cv=none; d=google.com; s=arc-20160816; b=zQjHEpmNHS/PfKKnW3JqxJyaNEPeyattd9bgl0JJx5aCkQhCyb7XS4ZnIMCSvAbOXy 7Av01m5swXIMOFem0iK40YXSIRiuUsHSFwgvtNIxv3vZntXxNpfjVxqY4GnnrYTuchxg VpTsz5x6vc9e5vIU5rfb/b3WKvrOvswbGBSTZqU4O1prF3m8X8MqHJ3fD34dUNziwuf5 AH2SFXoTnuWz4aiEP19wrxbaPzsPwGZWPQ0K45PajdMcmYkFx0j63s9MqZxQE2Erlboa AIQomZMYzYCJXmEjwTuoxzWx22on8D0s7cpDBXb6puu+JTH7ViNX+4AUChl08pCpygg/ Np8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=MDyVzegpc4gJFi+F7DljksK9JMAxLaCSM7Hw8hvgCRc=; b=waKemsQCP0yixRbT/Y46H8my8iVwKPcrDCFUl/29L0B6Pjzd9gvYLJ6T9osbGP0jdO UHP491P5aN9BOGghnwfD+/BqrxK6DHsJm4YxSJ0//TUbRVRPMbcYt7PwDVTAgQwAxG9D noI3nMsKmGqExYiMft38mYFVl3V/flJr6/hPhhCQJiBPFxYWYHk0EsfqFYbRH/cxutDR SQchSN+8NqGtw/AbrPDVJCvs2SG0Kw+9slO3M1mTZRcOUZz2RQj3xlPSTp8g9bvuzoaX yxCChe6EdtHHhT/Qi+xcC/anHx+UQlXa8vwy+3DGHqozJhe9cK2BttxSwM2/NiEF5frd ElAA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 4si5677097edh.521.2020.11.13.00.17.41; Fri, 13 Nov 2020 00:18:05 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726207AbgKMIQB (ORCPT + 99 others); Fri, 13 Nov 2020 03:16:01 -0500 Received: from muru.com ([72.249.23.125]:48202 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725866AbgKMIQB (ORCPT ); Fri, 13 Nov 2020 03:16:01 -0500 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id A87178096; Fri, 13 Nov 2020 08:16:05 +0000 (UTC) Date: Fri, 13 Nov 2020 10:15:56 +0200 From: Tony Lindgren To: Grygorii Strashko Cc: "David S. Miller" , netdev@vger.kernel.org, Jakub Kicinski , Sekhar Nori , linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, Vignesh Raghavendra Subject: Re: [PATCH] net: ethernet: ti: cpsw: fix cpts irq after suspend Message-ID: <20201113081556.GW26857@atomide.com> References: <20201112111546.20343-1-grygorii.strashko@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201112111546.20343-1-grygorii.strashko@ti.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Grygorii Strashko [201112 11:15]: > Depending on the SoC/platform the CPSW can completely lose context after a > suspend/resume cycle, including CPSW wrapper (WR) which will cause reset of > WR_C0_MISC_EN register, so CPTS IRQ will became disabled. > > Fix it by moving CPTS IRQ enabling in cpsw_ndo_open() where CPTS is > actually started. > > Fixes: 84ea9c0a95d7 ("net: ethernet: ti: cpsw: enable cpts irq") > Reported-by: Tony Lindgren > Signed-off-by: Grygorii Strashko Thanks this works for me: Tested-by: Tony Lindgren