Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp991891pxb; Fri, 13 Nov 2020 01:00:29 -0800 (PST) X-Google-Smtp-Source: ABdhPJydtE4z5z3aTkCiLfLnxCKwXZAIQUSDLwZvcF35dQWNFOAU4G6gQ/7SSF06YOAK7Z10sNnK X-Received: by 2002:a17:907:2063:: with SMTP id qp3mr1004038ejb.314.1605258029069; Fri, 13 Nov 2020 01:00:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605258029; cv=none; d=google.com; s=arc-20160816; b=qZH+4yNMWaiM3qKnC2YTzAQwSPlhGr87olhMvE7lOWH7/93qL6nJIhn7ofdKVc8UHz 4Dh1y/+dcwe2aLl/FGYP8CtxvJqk+YusaaVaxCGEb3nSo/66J04YhlPYsKzQ5pVv9rDg JsAJuAENr2vdNsDbMnSOSskFKD1SasJJYl4w/jlJgc995EK1qcowA4dqIvh9GomFMLdG 941HW8a8eIB2eHdCbihQN+2Mt7IN+ZEh8I05jgrQUlCgOYKBBXLwXjNG8NqXn1TYS2P8 MxCzCVoJs3M4c6ilF0GknNdGcpvRRqkVyzNXGgrmd/AC4lF6qxTyC+n4Bj8ER4BbnfA0 Htmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=SwzVdaD4qmRQxRTP49JhRejAhaIgmj809pgAMbT4+q4=; b=RA3OiCX65KcKmjjt70Pp2DKPvQxx//YZzVjgg5tgFhL70AEMQ6+h68ALQdNyqEghQn w+BHnvnjSH5rmbjKNokZ/0I18ApuAVoELtlg0oTjFwX/JMS2eFRSaF16pfm8cg3s2Jj9 kSkYiuK4xrqOR010jYGhijWE+Es+pJEM5qWpw2+hqkis7NZjk5iHK7ExAWYQP4Irmr18 ldqSNPxJDjaFiCadjjKJsHcjy/sHZVjqfLuid0LynCsP5aLYXnHAS3gUPhNG6TV8PtAU OPvXU8xD62XHgTtiRfbgbjMO31Yy1mK3u+/w9kF7tQJz5IzLJGnmqMOrKrW1MXr7ulSu 3CWQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id x2si6126402ejy.195.2020.11.13.01.00.06; Fri, 13 Nov 2020 01:00:29 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=collabora.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726187AbgKMI4g (ORCPT + 99 others); Fri, 13 Nov 2020 03:56:36 -0500 Received: from bhuna.collabora.co.uk ([46.235.227.227]:44084 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726160AbgKMI4f (ORCPT ); Fri, 13 Nov 2020 03:56:35 -0500 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: eballetbo) with ESMTPSA id B89A21F4680B From: Enric Balletbo i Serra To: Benson Leung , Stephen Boyd Cc: kernel@collabora.com, Alessandro Zummo , Guenter Roeck , linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org, Alexandre Belloni Subject: Re: [PATCH] platform/chrome: Don't treat RTC events as wakeup sources Date: Fri, 13 Nov 2020 09:56:25 +0100 Message-Id: <160521341449.487210.11292541473208275402.b4-ty@collabora.com> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20201030232523.2654478-1-swboyd@chromium.org> References: <20201030232523.2654478-1-swboyd@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 30 Oct 2020 16:25:23 -0700, Stephen Boyd wrote: > The EC sends an RTC host event when the RTC fires, but we don't need to > treat that as a wakeup event here. The RTC class already properly > handles activating and deactivating a wakeup source in rtc_update_irq() > by calling pm_stay_awake() at the start of processing and pm_relax() > once all expired RTC timers have been processed. This reduces one wakeup > increment but not much else. I noticed this while debugging RTC wakeups > and how they always incremented the wakeup count by two instead of one > because this is duplicated. Applied, thanks! [1/1] platform/chrome: Don't treat RTC events as wakeup sources commit: 853c1a789f5fe8e783586a5c2dcc2ad1b57ac20f Best regards, -- Enric Balletbo i Serra