Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 13 Nov 2020 10:12:48 +0000
From:   Lee Jones <lee.jones@linaro.org>
To:     michael.srba@seznam.cz
Cc:     Beomho Seo <beomho.seo@samsung.com>,
        Chanwoo Choi <cw00.choi@samsung.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: rt5033: fix errorneous defines
Message-ID: <20201113101248.GD3718728@dell>
References: <20201110130047.8097-1-michael.srba@seznam.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20201110130047.8097-1-michael.srba@seznam.cz>
Precedence: bulk

On Tue, 10 Nov 2020, michael.srba@seznam.cz wrote:

> From: Michael Srba <Michael.Srba@seznam.cz>
> 
> Fix regulators on rt5033 by converting some values to bitmasks which were 
> errorneously not defined as such in the header file.
> 
> Cc: Beomho Seo <beomho.seo@samsung.com>
> Fixes: 0b271258544b ("mfd: rt5033: Add Richtek RT5033 driver core.")
> Signed-off-by: Michael Srba <Michael.Srba@seznam.cz>
> ---
> 
> Tested on Samsung Galaxy A3 (sm-a3ulte).
> 
> Other areas (e.g "RT5033 use internal timer need to set time") still look
> suspicious, but without access to a datasheet it's unfortunately hard
> to evaluate. Moreover, these values are not currently utilized so it's not
> clear what format would be expected. (it's however hard to argue for
> the removal of said values, since with the datasheet not being publicly
> available, this file may be the best documentation of them)
> 
> ---
>  include/linux/mfd/rt5033-private.h | 28 ++++++++++++++--------------
>  1 file changed, 14 insertions(+), 14 deletions(-)

Applied, thanks.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog