Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] tipc: fix -Wstringop-truncation warnings
To:     Kang Wenlin <wenlin.kang@windriver.com>, jmaloy@redhat.com,
        davem@davemloft.net, kuba@kernel.org
Cc:     netdev@vger.kernel.org, tipc-discussion@lists.sourceforge.net,
        linux-kernel@vger.kernel.org
References: <20201112093442.8132-1-wenlin.kang@windriver.com>
From:   Ying Xue <ying.xue@windriver.com>
Autocrypt: addr=ying.xue@windriver.com; keydata=
 xjMEX1nnURYJKwYBBAHaRw8BAQdAZxROH3r87AOhslT5tP2cdYcg89+pbHiYf+LIny/C0fLN
 GDx5aW5nLnh1ZUB3aW5kcml2ZXIuY29tPsJ3BBAWCgAfBQJfWedRBgsJBwgDAgQVCAoCAxYC
 AQIZAQIbAwIeAQAKCRC3Qmz/Z9beRSLiAP9kPgF+mG4F3elbrVTen/sybJfZidnvF1YVq5Ho
 sUbt+wEA6ByAVvGqlEbt4SE1JP6xVgTzwlwihyCgl/byRAQzeg7OOARfWedREgorBgEEAZdV
 AQUBAQdAsdHm3QQyX4RnhnVEmywHpipu0cUyHWeuAkYuLavc5QYDAQgHwmEEGBYIAAkFAl9Z
 51ECGwwACgkQt0Js/2fW3kXZKAEA0jTzhaLbmprQxi1BbUmAYtlpQCrrjCWdpFGwt5O3yO8A
 /jVE1VxnEgu71mYXX1QE1Lngk+SPVEfLm0BVZFk9fBAA
Message-ID: <11e23a8d-766d-fb65-40ce-c7a1fdf00c3c@windriver.com>
Date:   Fri, 13 Nov 2020 20:26:13 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
In-Reply-To: <20201112093442.8132-1-wenlin.kang@windriver.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from [128.224.155.152] (60.247.85.82) by HK2PR0401CA0008.apcprd04.prod.outlook.com (2603:1096:202:2::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3541.21 via Frontend Transport; Fri, 13 Nov 2020 12:26:20 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: d80f7892-834d-412e-a385-08d887cf5562
X-MS-TrafficTypeDiagnostic: DM6PR11MB4075:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <DM6PR11MB4075DEFB00F9E438692E3CD984E60@DM6PR11MB4075.namprd11.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:4125;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: gYvjYCZuUquf6FsZ7hsKBEJcR0OhWhFvi1Jth0xZWabkkTPq1l2iCOtv5etvrZI6qgPT+m/ChoiSe0jLZzNDWyh+GgPlfCSLA8VxIcPK/HXYvTehRlJPekBl41gpzc27ZGM8Ub9tCM0rk38h3mZUVrpWaOLzmci91d8xjXgWpkhWcjae1MXMUHqOdCU99/jO+PmAWoQYpZV1vfBpTqgDSTo1lWpgEDbZxGO2WX9VszykkK3LUShfWrvilPvmsvzE2XZDj+p0uoU+5an1TxjUHnWCpGBMVLeu4XQ3T3NhvxtNPNj8Zwur6USJG3k1iFjQQz1d/ILKjNkZPd2i6xmpmzxKcVAbmLcOb7lDkiFI0sux3AbnAdyJDtuYVRl2RhuDwPye8ZE8HupMUNKtIboezA==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR11MB2603.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(366004)(396003)(376002)(39850400004)(136003)(2616005)(5660300002)(66476007)(16576012)(8936002)(83380400001)(52116002)(8676002)(66556008)(66946007)(6706004)(36756003)(478600001)(956004)(316002)(6666004)(86362001)(44832011)(31696002)(53546011)(6486002)(186003)(2906002)(26005)(31686004)(16526019)(4326008)(78286007)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: JxFoefKlfe2VglSU4S3O5NzRhpoGl5q1PV5DsKaxK5ZwzeH9KiXRqQbAwyPSlpufs9yRI+DtJ3S2gapxKdaLvLj4ayxEACg95L5olWeQpC1DlsZVslU33gpDzS6mIMk+0WYVgdIFtU5MTIMAqDTQ+XWOtYOuRjevxD2lk058iLRYpCVRy102322n6HsHBtGkSDMZJO8lrRul9GVK4NQxsezKt6r0CKtcxxH+hIPDensBZVI6WTMAWtLqf5EI64KJ5pN3mhIWahJsRQlCxntMz/NQDPfQjEZN62pYYmmMfyCQw0vXKLMx5LBknaI6YchOSfNBuzbUBQjHulOkEo7andKKegNTtPHpBiNrzH4AqxWGlQA5Q3YaWN2FGQj8/N4SdM8+iRTduf1RwiSJH3NBuEnZOhUDtwbwcDYn/ymG2JU1wT4TU4IQnPW+8VGu0RV2aJlmP+2ozLHi2zuXC6tL6JaHzNG+J5+XZLYG13BZ5TkvWFtSUbhxdLZE2It1zeXu4WgVKKJGqzJhsNaaWQgQb/3f0Cx3ZoL9SISQzY36e37XfkWpGwNxpNr2bc3ApKLZAZmhpz/z2G1y3Efr0OX+KFam7xeXyux/H+ex0Fb6DLghLsgcDhoKs0DF6+uvOcqs0sfidxJcF978Lh5DTbzDVA==
X-OriginatorOrg: windriver.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d80f7892-834d-412e-a385-08d887cf5562
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB2603.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Nov 2020 12:26:23.7890
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ddb2873-a1ad-4a18-ae4e-4644631433be
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: x1MJfQc9CkkftZlyzvFaUEYNpV9ePVAXrTaPOwXN6XiRqr7lIFi7PljZyMG3vTRrfKq36nCMBJIWoGZM/YWsAg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4075
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 11/12/20 5:34 PM, Kang Wenlin wrote:
> From: Wenlin Kang <wenlin.kang@windriver.com>
> 
> Replace strncpy() with strscpy(), fixes the following warning:
> 
> In function 'bearer_name_validate',
>     inlined from 'tipc_enable_bearer' at net/tipc/bearer.c:246:7:
> net/tipc/bearer.c:141:2: warning: 'strncpy' specified bound 32 equals destination size [-Wstringop-truncation]
>   strncpy(name_copy, name, TIPC_MAX_BEARER_NAME);
>   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> Signed-off-by: Wenlin Kang <wenlin.kang@windriver.com>

Acked-by: Ying Xue <ying.xue@windriver.com>

> ---
>  net/tipc/bearer.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/net/tipc/bearer.c b/net/tipc/bearer.c
> index 650414110452..2241d5a38f7b 100644
> --- a/net/tipc/bearer.c
> +++ b/net/tipc/bearer.c
> @@ -139,10 +139,7 @@ static int bearer_name_validate(const char *name,
>  	u32 if_len;
>  
>  	/* copy bearer name & ensure length is OK */
> -	name_copy[TIPC_MAX_BEARER_NAME - 1] = 0;
> -	/* need above in case non-Posix strncpy() doesn't pad with nulls */
> -	strncpy(name_copy, name, TIPC_MAX_BEARER_NAME);
> -	if (name_copy[TIPC_MAX_BEARER_NAME - 1] != 0)
> +	if (strscpy(name_copy, name, TIPC_MAX_BEARER_NAME) < 0)
>  		return 0;
>  
>  	/* ensure all component parts of bearer name are present */
>