Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
References: <20201113113236.71678-1-wanghai38@huawei.com>
User-agent: mu4e 1.2.0; emacs 26.3
From:   Vadym Kochan <vadym.kochan@plvision.eu>
To:     Wang Hai <wanghai38@huawei.com>
Cc:     davem@davemloft.net, kuba@kernel.org, oleksandr.mazur@plvision.eu,
        vadym.kochan@plvision.eu, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net: marvell: prestera: fix error return code in prestera_pci_probe()
In-reply-to: <20201113113236.71678-1-wanghai38@huawei.com>
Date:   Fri, 13 Nov 2020 14:50:03 +0200
Message-ID: <vrcxh2d00hto90.fsf@plvision.eu>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from pc60716vkochan (217.20.186.93) by AM6PR10CA0024.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:209:89::37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3541.21 via Frontend Transport; Fri, 13 Nov 2020 12:50:03 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 3782fd77-918b-4b92-2205-08d887d2a46d
X-MS-TrafficTypeDiagnostic: HE1P190MB0393:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <HE1P190MB03938DB8DACBD5583682986095E60@HE1P190MB0393.EURP190.PROD.OUTLOOK.COM>
X-MS-Oob-TLC-OOBClassifiers: OLM:7691;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: YWnRAMPijRt8BIlYIAMKiJ7TMJXd1Yyyb77HrKu8qHV9VkIv+3BYXp15uFGuIbSqA6wLoPsFeCtZYkiWMJt1lATnSgue2hjsvnwsiBfSTA6WquR+vQqKDnKgxPmKg9+lFOPQpLJT8s0jsT173/+bVn/3snrUXORnjWp5WV3531anwjwkpYQnVjjHwUiPKoLva82zRfbnSHIqVgG49f+LriSA/TvZ+WB9v+C9IJy2JWUuWX5PkdgXl1BHIenrFh/NCitv2NjxBeDzCHjy23rmP4kZyfqT2Jf9sCYP/rsdhVnkFMAxxYOWU3iJBS1tC0QOu0hz1RWswYH1Qg6UqYaR3w==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:HE1P190MB0539.EURP190.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(376002)(39830400003)(346002)(366004)(136003)(396003)(478600001)(4326008)(2616005)(6916009)(26005)(66476007)(66556008)(66946007)(8936002)(86362001)(8676002)(52116002)(316002)(83380400001)(5660300002)(186003)(6486002)(44832011)(16526019)(36756003)(2906002)(956004)(6496006);DIR:OUT;SFP:1102;
X-MS-Exchange-AntiSpam-MessageData: BfTzHMVEhzgmaEAIzjPmDrpeUCycZjP3qnN1u59X6L4EptM7FXR8W3n+F0fNBQwmO3Wmp4Py7Uo6xA0VncpXD6xfbjs6htmxTMfJ9h+TVw4d31wvqKUqitjdxNClVPnCXmsP+XkZ+dXT/dhJOt7SuHmSfm8mB2LU2CdQ6oZb1pIIlN3IQb0itbAanSGFV7N/TEUTwmUao0oPsxkEfM9WZG+J828ieAg5mOEsOFqM+NsQzFN+X1x240zi8GfEafqoHsIz++RFqJExx376hwrM5nOHCOdvvJ8jqvNp3tvm6UNVyV4h1/GqUBUQDL5GSUYvRdfK8ngfHHEM0BybRLMhz+NLM+7+Mbd07EAvRhKcwNy6xIMr8AISKD0IaRnwDo2rH71jkQLsFApBwV1vdv5gK63gTLBTQ/QSDpyUG0Gcp6LWSD7VqNh0c4+1cyic9QfJd1JyNZSLjJxUQF2TWNuHk471ZrjkDhz+FgVPp29rW9OVNbUzInH8wRxXFkL9e9qLcjtoHX/QbQtvNcuz53cH2aYQ9vQDn3vuisvH0iPDmr96lkHBpFBmFSaPycivfARts+1d4FW0miv/gGIoQ0ED9KGHp36j1f0qzrBSvNiq2AcDGAlNoXkh3td2At1G7Cuui9G9P02q0y86rQWiOq5hGZTUWXSLf0YHlYw42GT8UK+oNNR7iEGbn8o+g9wJq8JosbOv7fz1i/HKaP/joUNTo1KpeHHrMeBhM/dgzD+EBHiMfElrkYWulolu0Nk3p7066gA2Pw+LHJ/8+jrqZP8GPcXhln/kbQum6hk7i5LyRqN4gFT8o6jaoDGDBgILaCRrTNgbk7glSSYTM7RE5bmg2zh1T/eDx/IEuSVvjIs68pikTKkKAKd8sX6q2XplnAjqKGDGGq67YhZCJU1g87kIXA==
X-OriginatorOrg: plvision.eu
X-MS-Exchange-CrossTenant-Network-Message-Id: 3782fd77-918b-4b92-2205-08d887d2a46d
X-MS-Exchange-CrossTenant-AuthSource: HE1P190MB0539.EURP190.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Nov 2020 12:50:04.6608
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 03707b74-30f3-46b6-a0e0-ff0a7438c9c4
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: hGe1D7SLxZ2KVI+aUVynlKvw73BTZVMlUIwZN23KXOhnT2MpY4sQRAkpTvvxOP3cHUMlo0DgnYsLuNzV5JYV7hknn/yDEddoVsbFosDljPI=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1P190MB0393
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Hi Wang,

Wang Hai <wanghai38@huawei.com> writes:

> Fix to return a negative error code from the error handling
> case instead of 0, as done elsewhere in this function.
>
> Fixes: 4c2703dfd7fa ("net: marvell: prestera: Add PCI interface support")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wang Hai <wanghai38@huawei.com>
> ---
>  drivers/net/ethernet/marvell/prestera/prestera_pci.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/marvell/prestera/prestera_pci.c b/drivers/net/ethernet/marvell/prestera/prestera_pci.c
> index 1b97adae542e..be5677623455 100644
> --- a/drivers/net/ethernet/marvell/prestera/prestera_pci.c
> +++ b/drivers/net/ethernet/marvell/prestera/prestera_pci.c
> @@ -676,7 +676,8 @@ static int prestera_pci_probe(struct pci_dev *pdev,
>  	if (err)
>  		return err;
>  
> -	if (dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(30))) {
> +	err = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(30));
> +	if (err) {
>  		dev_err(&pdev->dev, "fail to set DMA mask\n");
>  		goto err_dma_mask;
>  	}
> @@ -702,8 +703,10 @@ static int prestera_pci_probe(struct pci_dev *pdev,
>  	dev_info(fw->dev.dev, "Prestera FW is ready\n");
>  
>  	fw->wq = alloc_workqueue("prestera_fw_wq", WQ_HIGHPRI, 1);
> -	if (!fw->wq)
> +	if (!fw->wq) {
> +		err = -ENOMEM;
>  		goto err_wq_alloc;
> +	}
>  
>  	INIT_WORK(&fw->evt_work, prestera_fw_evt_work_fn);

Thank you!

Just in case it is needed:

Reviewed-by: Vadym Kochan <vadym.kochan@plvision.eu>
Acked-by: Vadym Kochan <vadym.kochan@plvision.eu>